From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56AB4ECAAA1 for ; Fri, 28 Oct 2022 12:29:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229588AbiJ1M3g (ORCPT ); Fri, 28 Oct 2022 08:29:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43608 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229706AbiJ1M3f (ORCPT ); Fri, 28 Oct 2022 08:29:35 -0400 Received: from mail-lj1-x232.google.com (mail-lj1-x232.google.com [IPv6:2a00:1450:4864:20::232]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4031B60CB for ; Fri, 28 Oct 2022 05:29:29 -0700 (PDT) Received: by mail-lj1-x232.google.com with SMTP id s24so8127356ljs.11 for ; Fri, 28 Oct 2022 05:29:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xhh2GfNPqccqHt9z7S0/T4lVRI1pm6I0GIyqBlDEE6Q=; b=Gv3mhdHv4vTqTawNHz1Bsh6DyvFILad7+MCdXJ/Kg9Hu8zE08m6fZ8RGYRwg76Qt7h xiVKcxSf9tQQxNOF007MpB2BTQUVbn3dCwuaS2V+PFtS2nPi0x0fe7DPKouC0o8+IPtF aKKWJX/UxIDkAf7/FTMYLYItVomf7DtW17XMYNjmxuMmB6cerpTlO1ofsONDt2eJoXSR peDoWokbyIryddPi1EUHNAj8obcrkfrzSmbmaEYDSy8nNcGWxisgLP0d77xdEaUIfyjX AC5eXEc1PmLjCOg7c3rOVB0LocXqV6ephnuD692n+5j0VW3Kfs6fluKoG3wpY47ezLvl cluA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xhh2GfNPqccqHt9z7S0/T4lVRI1pm6I0GIyqBlDEE6Q=; b=jNZaLdDrF/yMTCaFmfQpwo1GDEFoiJic1o1AB2lLUqSOe6LdQSEOXLG2kB9JrtXM8r hflEXw1JSF04XmHzpjG2/yNYwg/APzxd15EL1WuMCpXJT0j6KU7e/r8wqCiKK9dXXG5y UlPmA0HrmwvcKuefk4n4RibS6Yk7njxnCsIfF0dvk8PcIcv9JerNphK9SGap38rHHCl8 DZNMvCsD7oVtLtur+2E8s+ljedOfC8Hx2bRaslFSN88tNOUDdniT/q8/ZcDEE289YPHE cpFMvA5f9XoafgUBeA7p74teXf5Nvqrmjpw/INoWKAmI3zVopnoSDjmDCder8fIqzeYA owzA== X-Gm-Message-State: ACrzQf3CCeyajvk7Bpsw+wVqAK9O5+OqMWKBCF60cmIyXy9zdz1zDExZ 9eAINnBXbMHfiXjAzp7Awvp8TQ== X-Google-Smtp-Source: AMsMyM4cqflCH7VKbXl6GhfGyt9BzQJBZMw3rl9thrFiCIpESo5T+Xin/zo7hOdtAxup19xhLpLF2w== X-Received: by 2002:a05:651c:111:b0:277:2451:816c with SMTP id a17-20020a05651c011100b002772451816cmr4467514ljb.17.1666960167619; Fri, 28 Oct 2022 05:29:27 -0700 (PDT) Received: from [10.10.15.130] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id z10-20020a05651c11ca00b00277074c12ddsm621018ljo.125.2022.10.28.05.29.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 05:29:27 -0700 (PDT) Message-ID: <09a049cc-0514-2db3-0e8b-ff3dfa61d585@linaro.org> Date: Fri, 28 Oct 2022 15:29:26 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 Subject: Re: [PATCH v1 1/9] drm/msm: Add compatibles for SM8350 display Content-Language: en-GB From: Dmitry Baryshkov To: Robert Foss , agross@kernel.org, bjorn.andersson@linaro.org, konrad.dybcio@somainline.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, robdclark@gmail.com, quic_abhinavk@quicinc.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, quic_kalyant@quicinc.com, swboyd@chromium.org, angelogioacchino.delregno@somainline.org, loic.poulain@linaro.org, quic_vpolimer@quicinc.com, vkoul@kernel.org, dianders@chromium.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, Jonathan Marek , vinod.koul@linaro.org, quic_jesszhan@quicinc.com References: <20221028120812.339100-1-robert.foss@linaro.org> <20221028120812.339100-2-robert.foss@linaro.org> <0f8e73f6-d005-7e0b-ba38-c4d0161c1acd@linaro.org> In-Reply-To: <0f8e73f6-d005-7e0b-ba38-c4d0161c1acd@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/10/2022 15:19, Dmitry Baryshkov wrote: > On 28/10/2022 15:08, Robert Foss wrote: >> Add compatible string for "qcom,sm8350-dpu" and >> "qcom,sm8350-mdss". >> >> Signed-off-by: Robert Foss >> --- >>   drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 + >>   drivers/gpu/drm/msm/msm_mdss.c          | 1 + >>   2 files changed, 2 insertions(+) > > [skipped] > >> diff --git a/drivers/gpu/drm/msm/msm_mdss.c >> b/drivers/gpu/drm/msm/msm_mdss.c >> index e13c5c12b775..fd5a95cace16 100644 >> --- a/drivers/gpu/drm/msm/msm_mdss.c >> +++ b/drivers/gpu/drm/msm/msm_mdss.c >> @@ -447,6 +447,7 @@ static const struct of_device_id mdss_dt_match[] = { >>       { .compatible = "qcom,sc8180x-mdss" }, >>       { .compatible = "qcom,sm8150-mdss" }, >>       { .compatible = "qcom,sm8250-mdss" }, >> +    { .compatible = "qcom,sm8350-mdss" }, >>       {} >>   }; >>   MODULE_DEVICE_TABLE(of, mdss_dt_match); > > > BTW: you probably also have to update the msm_mdss_enable() function > with the 8350-specific code. > For mdss changes you can depend on [1], I plan to merge this patch in this window. [1] https://patchwork.freedesktop.org/patch/489578/?series=105162&rev=1 Also with the mdss changes, it would be good to split this patch into dpu and mdss parts. -- With best wishes Dmitry