Re: [PATCH v2 1/2] dt-bindings: mfd: add Traverse Ten64 board controller

[Krzysztof Kozlowski <krzk@kernel.org>]

On 13/08/2025 04:34, Mathew McBride wrote:
> This adds the device tree binding for the board

Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95


> (micro)controller on Ten64 family boards[1].
> 
> The schema is simple and is (presently) only
> consumed by U-Boot, but it is possible that
> it could be consumed by nvmem or other type
> drivers in the future, as well as extended
> to future Traverse boards.

Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597

> 
> [1] https://ten64doc.traverse.com.au/hardware/microcontroller/
> 
> Signed-off-by: Mathew McBride <matt@traverse.com.au>
> ---
>  .../mfd/traverse,ten64-controller.yaml        | 44 +++++++++++++++++++
>  1 file changed, 44 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/traverse,ten64-controller.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/traverse,ten64-controller.yaml b/Documentation/devicetree/bindings/mfd/traverse,ten64-controller.yaml
> new file mode 100644
> index 000000000000..13fed94e8406
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/traverse,ten64-controller.yaml
> @@ -0,0 +1,44 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/traverse,ten64-controller.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Traverse Ten64 board microontroller

typo

> +
> +maintainers:
> +  - Mathew McBride <matt@traverse.com.au>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  The board microcontroller on the Ten64 board family is
> +  reponsible for management of power sources on the board,

typo

> +  as well as signalling the SoC to power on and reset.
> +  It also implements useful auxiliary functions like bootcount,
> +  serial/MAC address storage and scratch registers.
> +
> +properties:
> +  compatible:
> +    const: traverse,ten64-controller
> +
> +  reg:
> +    description:
> +      I2C device address.

Drop description, obvious.

> +    maxItems: 1
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        board-controller@7e {
> +          compatible = "traverse,ten64-controller";

Inconsistent indentation.

> +          reg = <0x7e>;
> +        };
> +    };


Best regards,
Krzysztof