* Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 [not found] ` <20221104074443.26172-2-Elvis.Wang@mediatek.com> @ 2022-11-04 9:12 ` AngeloGioacchino Del Regno 2022-11-06 10:27 ` Krzysztof Kozlowski 1 sibling, 0 replies; 5+ messages in thread From: AngeloGioacchino Del Regno @ 2022-11-04 9:12 UTC (permalink / raw) To: Elvis.Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: jason-jh . lin, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group Il 04/11/22 08:44, Elvis.Wang ha scritto: > From: Elvis Wang <Elvis.Wang@mediatek.com> > > add gce header file to define the gce thread priority, gce subsys id, > event and constant for mt8188. > > Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 [not found] ` <20221104074443.26172-2-Elvis.Wang@mediatek.com> 2022-11-04 9:12 ` [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 AngeloGioacchino Del Regno @ 2022-11-06 10:27 ` Krzysztof Kozlowski 2022-11-07 11:18 ` Matthias Brugger 1 sibling, 1 reply; 5+ messages in thread From: Krzysztof Kozlowski @ 2022-11-06 10:27 UTC (permalink / raw) To: Elvis.Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski, Matthias Brugger Cc: jason-jh . lin, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group On 04/11/2022 08:44, Elvis.Wang wrote: > From: Elvis Wang <Elvis.Wang@mediatek.com> > > add gce header file to define the gce thread priority, gce subsys id, > event and constant for mt8188. > > Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com> > --- > Thanks for the reviews, I have removed the incorrect reviewed message. > --- > include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 ++++++++++++++++++ > 1 file changed, 966 insertions(+) > create mode 100644 include/dt-bindings/gce/mediatek,mt8188-gce.h > > diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h b/include/dt-bindings/gce/mediatek,mt8188-gce.h > new file mode 100644 > index 000000000000..e2e2c56016a1 > --- /dev/null > +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h What is a "gce" subsystem or type of hardware? Why do you put headers in "gce"? Don't continue this pattern. Mediatek devices do not get specific folders... Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 2022-11-06 10:27 ` Krzysztof Kozlowski @ 2022-11-07 11:18 ` Matthias Brugger 2022-11-22 9:10 ` Elvis Wang (王军) 0 siblings, 1 reply; 5+ messages in thread From: Matthias Brugger @ 2022-11-07 11:18 UTC (permalink / raw) To: Krzysztof Kozlowski, Elvis.Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski Cc: jason-jh . lin, Yongqiang Niu, linux-kernel, devicetree, linux-arm-kernel, linux-mediatek, Project_Global_Chrome_Upstream_Group On 06/11/2022 11:27, Krzysztof Kozlowski wrote: > On 04/11/2022 08:44, Elvis.Wang wrote: >> From: Elvis Wang <Elvis.Wang@mediatek.com> >> >> add gce header file to define the gce thread priority, gce subsys id, >> event and constant for mt8188. >> >> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com> >> --- >> Thanks for the reviews, I have removed the incorrect reviewed message. >> --- >> include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 ++++++++++++++++++ >> 1 file changed, 966 insertions(+) >> create mode 100644 include/dt-bindings/gce/mediatek,mt8188-gce.h >> >> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h b/include/dt-bindings/gce/mediatek,mt8188-gce.h >> new file mode 100644 >> index 000000000000..e2e2c56016a1 >> --- /dev/null >> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h > > > What is a "gce" subsystem or type of hardware? Why do you put headers in > "gce"? > Yes, I think we should move all header files from the gce folder into the mailbox folder. Regards, Matthias > Don't continue this pattern. Mediatek devices do not get specific folders... > > Best regards, > Krzysztof > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 2022-11-07 11:18 ` Matthias Brugger @ 2022-11-22 9:10 ` Elvis Wang (王军) 2022-11-22 9:25 ` Krzysztof Kozlowski 0 siblings, 1 reply; 5+ messages in thread From: Elvis Wang (王军) @ 2022-11-22 9:10 UTC (permalink / raw) To: jassisinghbrar@gmail.com, matthias.bgg@gmail.com, krzysztof.kozlowski@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason-JH Lin (林睿祥), Yongqiang Niu (牛永强), linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group On Mon, 2022-11-07 at 12:18 +0100, Matthias Brugger wrote: > > On 06/11/2022 11:27, Krzysztof Kozlowski wrote: > > On 04/11/2022 08:44, Elvis.Wang wrote: > > > From: Elvis Wang <Elvis.Wang@mediatek.com> > > > > > > add gce header file to define the gce thread priority, gce subsys > > > id, > > > event and constant for mt8188. > > > > > > Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com> > > > --- > > > Thanks for the reviews, I have removed the incorrect reviewed > > > message. > > > --- > > > include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 > > > ++++++++++++++++++ > > > 1 file changed, 966 insertions(+) > > > create mode 100644 include/dt-bindings/gce/mediatek,mt8188- > > > gce.h > > > > > > diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h > > > b/include/dt-bindings/gce/mediatek,mt8188-gce.h > > > new file mode 100644 > > > index 000000000000..e2e2c56016a1 > > > --- /dev/null > > > +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h > > > > > > What is a "gce" subsystem or type of hardware? Why do you put > > headers in > > "gce"? > > > > Yes, I think we should move all header files from the gce folder into > the > mailbox folder. > > Regards, > Matthias There are still a lot of header files undre gce. If all of them are moved, it will also involve the modification of yaml and corresponding project dts files, which requires more effort. Can we deal with the 8188 part first? Best regards, Elvis > > > Don't continue this pattern. Mediatek devices do not get specific > > folders... > > > > Best regards, > > Krzysztof > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 2022-11-22 9:10 ` Elvis Wang (王军) @ 2022-11-22 9:25 ` Krzysztof Kozlowski 0 siblings, 0 replies; 5+ messages in thread From: Krzysztof Kozlowski @ 2022-11-22 9:25 UTC (permalink / raw) To: Elvis Wang (王军), jassisinghbrar@gmail.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jason-JH Lin (林睿祥), Yongqiang Niu (牛永强), linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, Project_Global_Chrome_Upstream_Group On 22/11/2022 10:10, Elvis Wang (王军) wrote: > On Mon, 2022-11-07 at 12:18 +0100, Matthias Brugger wrote: >> >> On 06/11/2022 11:27, Krzysztof Kozlowski wrote: >>> On 04/11/2022 08:44, Elvis.Wang wrote: >>>> From: Elvis Wang <Elvis.Wang@mediatek.com> >>>> >>>> add gce header file to define the gce thread priority, gce subsys >>>> id, >>>> event and constant for mt8188. >>>> >>>> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com> >>>> --- >>>> Thanks for the reviews, I have removed the incorrect reviewed >>>> message. >>>> --- >>>> include/dt-bindings/gce/mediatek,mt8188-gce.h | 966 >>>> ++++++++++++++++++ >>>> 1 file changed, 966 insertions(+) >>>> create mode 100644 include/dt-bindings/gce/mediatek,mt8188- >>>> gce.h >>>> >>>> diff --git a/include/dt-bindings/gce/mediatek,mt8188-gce.h >>>> b/include/dt-bindings/gce/mediatek,mt8188-gce.h >>>> new file mode 100644 >>>> index 000000000000..e2e2c56016a1 >>>> --- /dev/null >>>> +++ b/include/dt-bindings/gce/mediatek,mt8188-gce.h >>> >>> >>> What is a "gce" subsystem or type of hardware? Why do you put >>> headers in >>> "gce"? >>> >> >> Yes, I think we should move all header files from the gce folder into >> the >> mailbox folder. >> >> Regards, >> Matthias > > There are still a lot of header files undre gce. If all of them are > moved, it will also involve the modification of yaml and corresponding > project dts files, which requires more effort. Can we deal with the > 8188 part first? Sure, just put the new bindings in proper location (mailbox if this is a Mailbox). Best regards, Krzysztof ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-11-22 9:25 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20221104074443.26172-1-Elvis.Wang@mediatek.com>
[not found] ` <20221104074443.26172-2-Elvis.Wang@mediatek.com>
2022-11-04 9:12 ` [PATCH v3 1/2] dt-bindings: gce: add gce header file for mt8188 AngeloGioacchino Del Regno
2022-11-06 10:27 ` Krzysztof Kozlowski
2022-11-07 11:18 ` Matthias Brugger
2022-11-22 9:10 ` Elvis Wang (王军)
2022-11-22 9:25 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).