From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>,
Johan Hovold <johan@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 01/16] dt-bindings: phy: migrate QMP USB PHY bindings to qcom,sc8280xp-qmp-usb3-uni-phy.yaml
Date: Mon, 21 Aug 2023 08:16:50 +0200 [thread overview]
Message-ID: <09b4909d-686d-3e3d-f4c5-12e5cba3dd19@linaro.org> (raw)
In-Reply-To: <20230821002535.585660-2-dmitry.baryshkov@linaro.org>
On 21/08/2023 02:25, Dmitry Baryshkov wrote:
> Migrate legacy bindings (described in qcom,msm8996-qmp-usb3-phy.yaml)
> to qcom,sc8280xp-qmp-usb3-uni-phy.yaml. This removes a need to declare
> the child PHY node or split resource regions.
>
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> index f99fbbcd68fb..60cbcf3c19b3 100644
> --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml
> @@ -16,20 +16,33 @@ description:
> properties:
> compatible:
> enum:
> + - qcom,ipq6018-qmp-usb3-phy
> + - qcom,ipq8074-qmp-usb3-phy
> - qcom,ipq9574-qmp-usb3-phy
> + - qcom,msm8996-qmp-usb3-phy
> + - qcom,msm8998-qmp-usb3-phy
> - qcom,qcm2290-qmp-usb3-phy
> - qcom,sa8775p-qmp-usb3-uni-phy
> - qcom,sc8280xp-qmp-usb3-uni-phy
> + - qcom,sdm845-qmp-usb3-uni-phy
> + - qcom,sdx55-qmp-usb3-uni-phy
> + - qcom,sdx65-qmp-usb3-uni-phy
> - qcom,sm6115-qmp-usb3-phy
> + - qcom,sm8150-qmp-usb3-uni-phy
> + - qcom,sm8250-qmp-usb3-uni-phy
> + - qcom,sm8350-qmp-usb3-uni-phy
> +
>
Just one blank line
> reg:
> maxItems: 1
>
> clocks:
> - maxItems: 4
> + minItems: 4
> + maxItems: 5
The clocks become now variable, so you need to constrain the number in
allOf:if:then per each variant. At least one if: cases lack such
constrains (qcom,ipq9574-qmp-usb3-phy, if I am looking at correct revision)
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-08-21 6:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-21 0:25 [PATCH v2 00/16] phy: qcom-qmp-usb: convert to newer style of bindings Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 01/16] dt-bindings: phy: migrate QMP USB PHY bindings to qcom,sc8280xp-qmp-usb3-uni-phy.yaml Dmitry Baryshkov
2023-08-21 6:16 ` Krzysztof Kozlowski [this message]
2023-08-21 0:25 ` [PATCH v2 02/16] phy: qcom-qmp-usb: simplify clock handling Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 03/16] phy: qcom-qmp-usb: rework reset handling Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 04/16] phy: qcom-qmp-usb: make QPHY_PCS_MISC_CLAMP_ENABLE access conditional Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 05/16] phy: qcom-qmp: move PCS MISC V4 registers to separate header Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 06/16] phy: qcom-qmp-usb: populate offsets configuration Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 07/16] arm64: dts: qcom: ipq6018: switch USB QMP PHY to new style of bindings Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 08/16] arm64: dts: qcom: ipq8074: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 09/16] arm64: dts: qcom: msm8996: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 10/16] arm64: dts: qcom: msm8998: " Dmitry Baryshkov
2023-08-23 18:20 ` Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 11/16] arm64: dts: qcom: sdm845: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 12/16] arm64: dts: qcom: sm8150: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 13/16] arm64: dts: qcom: sm8250: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 14/16] arm64: dts: qcom: sm8350: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 15/16] ARM: dts: qcom-sdx55: " Dmitry Baryshkov
2023-08-21 0:25 ` [PATCH v2 16/16] ARM: dts: qcom-sdx65: " Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09b4909d-686d-3e3d-f4c5-12e5cba3dd19@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=johan@kernel.org \
--cc=kishon@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).