From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECC87EE49A0 for ; Mon, 21 Aug 2023 06:16:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231613AbjHUGQz (ORCPT ); Mon, 21 Aug 2023 02:16:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230159AbjHUGQz (ORCPT ); Mon, 21 Aug 2023 02:16:55 -0400 Received: from mail-ed1-x529.google.com (mail-ed1-x529.google.com [IPv6:2a00:1450:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE294A2 for ; Sun, 20 Aug 2023 23:16:53 -0700 (PDT) Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5280ef23593so3491638a12.3 for ; Sun, 20 Aug 2023 23:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692598612; x=1693203412; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=v2DHyxVTCML6SgQFmf5PrsWXwq96mK2/2B8sy/Z+uk8=; b=C2TLrPHZmARwktMNeniUL0KRM2S0lGuotVl5NAtWMyV2lPtA9ulYwCm28+Lxg6mW7t tc6Xh4ksk/vbqObq6ch/Ati18gnFFMzH14RIALu5McnjYOL3qjUG7c47tp4baaNcT4BL 20Zd0s2s1Z93Dcc68qNYv4RppsTuk09AO95KsqlZlgE8tJlvaFZ7KXchNUznWT0Sr75F eA2IuDL7SIfGtYAM3bcWEFF1h5jaN0f1667Dz9iZs6EabBS/DKe+aaLd/Z0BJgkmG4mY g4s+pe9fn+iAwCU8Y0FEBxn2DvK6lYUMowp+k4luRedN2Kq9xhi+yCW2wpzI7K+GlMvG w2dQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692598612; x=1693203412; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=v2DHyxVTCML6SgQFmf5PrsWXwq96mK2/2B8sy/Z+uk8=; b=dy+6UduyAAMkmbcPE4HBVW/uceAVsAI7keUTRUoiorwNVz5QcMBYOrBRMYRjWdj+6l ZrFtrv84Kq/uuAp28KFXOHa2cRWAoM1vSHyC8tHl20xIk8hVTpdf7bQ7XX/Mxh2ecjiO nAu05nn5boEPWCMk++wnVyypdbdhbK4B8e7VsUd4PcpPTtczQAKz8Jir0JYVMYberim4 NeDKx9AnTZQCwwFcyQG4KVKXQB+AQpmkeoLKwH43Z5lAcQFZhez2R10dmHZwIRsd9q84 ayDtvt9ynFHWIpSOJFpQA4vU8BleCKPBUIGGsOsRhBoNVXcX4llUMK17OM+vOHyY1qh9 9XwA== X-Gm-Message-State: AOJu0Yw+ipP9h99JGj8TICLJ9zmB7DBlrDesgyGxtUnQ/Pn1RIPoruRX GCt/9VRUnMlgGh/vynwZgvyYaRi6zrt5YDstsFQ= X-Google-Smtp-Source: AGHT+IEOgpV7Sr7hyl2V7Utgz/9q0+j+gDRYIgrp8qYMaflN3noIyg4RZtchBkGl08PCwFfZja/qyA== X-Received: by 2002:a17:906:3caa:b0:99d:f7f3:5218 with SMTP id b10-20020a1709063caa00b0099df7f35218mr4050827ejh.25.1692598612112; Sun, 20 Aug 2023 23:16:52 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.198]) by smtp.gmail.com with ESMTPSA id um6-20020a170906cf8600b0098d2f703408sm5966631ejb.118.2023.08.20.23.16.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Aug 2023 23:16:51 -0700 (PDT) Message-ID: <09b4909d-686d-3e3d-f4c5-12e5cba3dd19@linaro.org> Date: Mon, 21 Aug 2023 08:16:50 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v2 01/16] dt-bindings: phy: migrate QMP USB PHY bindings to qcom,sc8280xp-qmp-usb3-uni-phy.yaml Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Philipp Zabel , Johan Hovold , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, devicetree@vger.kernel.org References: <20230821002535.585660-1-dmitry.baryshkov@linaro.org> <20230821002535.585660-2-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20230821002535.585660-2-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21/08/2023 02:25, Dmitry Baryshkov wrote: > Migrate legacy bindings (described in qcom,msm8996-qmp-usb3-phy.yaml) > to qcom,sc8280xp-qmp-usb3-uni-phy.yaml. This removes a need to declare > the child PHY node or split resource regions. > > Signed-off-by: Dmitry Baryshkov > diff --git a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > index f99fbbcd68fb..60cbcf3c19b3 100644 > --- a/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > +++ b/Documentation/devicetree/bindings/phy/qcom,sc8280xp-qmp-usb3-uni-phy.yaml > @@ -16,20 +16,33 @@ description: > properties: > compatible: > enum: > + - qcom,ipq6018-qmp-usb3-phy > + - qcom,ipq8074-qmp-usb3-phy > - qcom,ipq9574-qmp-usb3-phy > + - qcom,msm8996-qmp-usb3-phy > + - qcom,msm8998-qmp-usb3-phy > - qcom,qcm2290-qmp-usb3-phy > - qcom,sa8775p-qmp-usb3-uni-phy > - qcom,sc8280xp-qmp-usb3-uni-phy > + - qcom,sdm845-qmp-usb3-uni-phy > + - qcom,sdx55-qmp-usb3-uni-phy > + - qcom,sdx65-qmp-usb3-uni-phy > - qcom,sm6115-qmp-usb3-phy > + - qcom,sm8150-qmp-usb3-uni-phy > + - qcom,sm8250-qmp-usb3-uni-phy > + - qcom,sm8350-qmp-usb3-uni-phy > + > Just one blank line > reg: > maxItems: 1 > > clocks: > - maxItems: 4 > + minItems: 4 > + maxItems: 5 The clocks become now variable, so you need to constrain the number in allOf:if:then per each variant. At least one if: cases lack such constrains (qcom,ipq9574-qmp-usb3-phy, if I am looking at correct revision) Best regards, Krzysztof