* [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2
@ 2022-04-12 15:44 SHIMAMOTO Takayoshi
2022-04-12 17:49 ` Rafał Miłecki
0 siblings, 1 reply; 4+ messages in thread
From: SHIMAMOTO Takayoshi @ 2022-04-12 15:44 UTC (permalink / raw)
To: takayoshi.shimamoto.360
Cc: Florian Fainelli, Hauke Mehrtens, Rafał Miłecki,
bcm-kernel-feedback-list, Rob Herring, Krzysztof Kozlowski,
linux-arm-kernel, devicetree, linux-kernel
Buffalo WZR-1166DHP2 wireless router with
- BCM4708A0
- 256MiB DDR2 SDRAM
- 128MiB NAND flash
- 2T2R 11ac/a/b/g/n Wi-Fi
- 4x 10/100M ethernet switch
The hardware configuration is very similar to the WZR-1750DHP,
except for memory size and number of antennas.
Signed-off-by: SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>
---
.../boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts | 189 ++++++++++++++++++
1 file changed, 189 insertions(+)
create mode 100644 arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
new file mode 100644
index 000000000000..22e54a0a202a
--- /dev/null
+++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
@@ -0,0 +1,189 @@
+// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
+/*
+ * Broadcom BCM470X / BCM5301X ARM platform code.
+ * DTS for Buffalo WZR-1166DHP2
+ *
+ * Copyright (C) 2014 Rafał Miłecki <zajec5@gmail.com>
+ * Copyright (C) 2022 SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>
+ */
+
+/dts-v1/;
+
+#include "bcm4708.dtsi"
+#include "bcm5301x-nand-cs0-bch8.dtsi"
+
+/ {
+ compatible = "buffalo,wzr-1166dhp2", "brcm,bcm4708";
+ model = "Buffalo WZR-1166DHP2 (BCM4708)";
+
+ chosen {
+ bootargs = "console=ttyS0,115200";
+ };
+
+ memory@0 {
+ device_type = "memory";
+ reg = <0x00000000 0x08000000>,
+ <0x88000000 0x08000000>;
+ };
+
+ spi {
+ compatible = "spi-gpio";
+ num-chipselects = <1>;
+ gpio-sck = <&chipcommon 7 0>;
+ gpio-mosi = <&chipcommon 4 0>;
+ cs-gpios = <&chipcommon 6 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ hc595: gpio_spi@0 {
+ compatible = "fairchild,74hc595";
+ reg = <0>;
+ registers-number = <1>;
+ spi-max-frequency = <100000>;
+
+ gpio-controller;
+ #gpio-cells = <2>;
+
+ };
+ };
+
+ leds {
+ compatible = "gpio-leds";
+
+ usb {
+ label = "bcm53xx:blue:usb";
+ gpios = <&hc595 0 GPIO_ACTIVE_HIGH>;
+ trigger-sources = <&ohci_port1>, <&ehci_port1>,
+ <&xhci_port1>, <&ohci_port2>,
+ <&ehci_port2>;
+ linux,default-trigger = "usbport";
+ };
+
+ power0 {
+ label = "bcm53xx:red:power";
+ gpios = <&hc595 1 GPIO_ACTIVE_HIGH>;
+ };
+
+ power1 {
+ label = "bcm53xx:white:power";
+ gpios = <&hc595 2 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ };
+
+ router0 {
+ label = "bcm53xx:blue:router";
+ gpios = <&hc595 3 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ };
+
+ router1 {
+ label = "bcm53xx:amber:router";
+ gpios = <&hc595 4 GPIO_ACTIVE_HIGH>;
+ };
+
+ wan {
+ label = "bcm53xx:blue:wan";
+ gpios = <&hc595 5 GPIO_ACTIVE_HIGH>;
+ linux,default-trigger = "default-on";
+ };
+
+ wireless0 {
+ label = "bcm53xx:blue:wireless";
+ gpios = <&hc595 6 GPIO_ACTIVE_HIGH>;
+ };
+
+ wireless1 {
+ label = "bcm53xx:amber:wireless";
+ gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
+ };
+ };
+
+ gpio-keys {
+ compatible = "gpio-keys";
+
+ restart {
+ label = "Reset";
+ linux,code = <KEY_RESTART>;
+ gpios = <&chipcommon 11 GPIO_ACTIVE_LOW>;
+ };
+
+ aoss {
+ label = "AOSS";
+ linux,code = <KEY_WPS_BUTTON>;
+ gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Commit mode set by switch? */
+ mode {
+ label = "Mode";
+ linux,code = <KEY_SETUP>;
+ gpios = <&chipcommon 13 GPIO_ACTIVE_LOW>;
+ };
+
+ /* Switch: AP mode */
+ sw_ap {
+ label = "AP";
+ linux,code = <BTN_0>;
+ gpios = <&chipcommon 14 GPIO_ACTIVE_LOW>;
+ };
+
+ eject {
+ label = "USB eject";
+ linux,code = <KEY_EJECTCD>;
+ gpios = <&chipcommon 15 GPIO_ACTIVE_LOW>;
+ };
+ };
+};
+
+&usb2 {
+ vcc-gpio = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+};
+
+&usb3 {
+ vcc-gpio = <&chipcommon 10 GPIO_ACTIVE_LOW>;
+};
+
+&spi_nor {
+ status = "okay";
+};
+
+&usb3_phy {
+ status = "okay";
+};
+
+&srab {
+ status = "okay";
+
+ ports {
+ port@0 {
+ reg = <0>;
+ label = "lan1";
+ };
+
+ port@1 {
+ reg = <1>;
+ label = "lan2";
+ };
+
+ port@2 {
+ reg = <2>;
+ label = "lan3";
+ };
+
+ port@3 {
+ reg = <3>;
+ label = "lan4";
+ };
+
+ port@4 {
+ reg = <4>;
+ label = "wan";
+ };
+
+ port@5 {
+ reg = <5>;
+ label = "cpu";
+ ethernet = <&gmac0>;
+ };
+ };
+};
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2
2022-04-12 15:44 [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2 SHIMAMOTO Takayoshi
@ 2022-04-12 17:49 ` Rafał Miłecki
2022-04-13 13:09 ` SHIMAMOTO Takayoshi
0 siblings, 1 reply; 4+ messages in thread
From: Rafał Miłecki @ 2022-04-12 17:49 UTC (permalink / raw)
To: SHIMAMOTO Takayoshi
Cc: Florian Fainelli, Hauke Mehrtens, bcm-kernel-feedback-list,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel
On 12.04.2022 17:44, SHIMAMOTO Takayoshi wrote:
> Buffalo WZR-1166DHP2 wireless router with
>
> - BCM4708A0
> - 256MiB DDR2 SDRAM
> - 128MiB NAND flash
> - 2T2R 11ac/a/b/g/n Wi-Fi
> - 4x 10/100M ethernet switch
Isn't that 10/100/1000?
> The hardware configuration is very similar to the WZR-1750DHP,
> except for memory size and number of antennas.
>
> Signed-off-by: SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>
> ---
> .../boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts | 189 ++++++++++++++++++
> 1 file changed, 189 insertions(+)
> create mode 100644 arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
>
> diff --git a/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
> new file mode 100644
> index 000000000000..22e54a0a202a
> --- /dev/null
> +++ b/arch/arm/boot/dts/bcm4708-buffalo-wzr-1166dhp2.dts
> @@ -0,0 +1,189 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later OR MIT
> +/*
> + * Broadcom BCM470X / BCM5301X ARM platform code.
> + * DTS for Buffalo WZR-1166DHP2
> + *
> + * Copyright (C) 2014 Rafał Miłecki <zajec5@gmail.com>
> + * Copyright (C) 2022 SHIMAMOTO Takayoshi <takayoshi.shimamoto.360@gmail.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "bcm4708.dtsi"
> +#include "bcm5301x-nand-cs0-bch8.dtsi"
> +
> +/ {
> + compatible = "buffalo,wzr-1166dhp2", "brcm,bcm4708";
> + model = "Buffalo WZR-1166DHP2 (BCM4708)";
We stopped adding SoC name to the "model" value, please drop it.
> + chosen {
> + bootargs = "console=ttyS0,115200";
> + };
> +
> + memory@0 {
> + device_type = "memory";
> + reg = <0x00000000 0x08000000>,
> + <0x88000000 0x08000000>;
> + };
> +
> + spi {
> + compatible = "spi-gpio";
> + num-chipselects = <1>;
> + gpio-sck = <&chipcommon 7 0>;
> + gpio-mosi = <&chipcommon 4 0>;
> + cs-gpios = <&chipcommon 6 0>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + hc595: gpio_spi@0 {
> + compatible = "fairchild,74hc595";
> + reg = <0>;
> + registers-number = <1>;
> + spi-max-frequency = <100000>;
> +
> + gpio-controller;
> + #gpio-cells = <2>;
> +
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";
> +
> + usb {
> + label = "bcm53xx:blue:usb";
> + gpios = <&hc595 0 GPIO_ACTIVE_HIGH>;
> + trigger-sources = <&ohci_port1>, <&ehci_port1>,
> + <&xhci_port1>, <&ohci_port2>,
> + <&ehci_port2>;
> + linux,default-trigger = "usbport";
> + };
> +
> + power0 {
> + label = "bcm53xx:red:power";
> + gpios = <&hc595 1 GPIO_ACTIVE_HIGH>;
> + };
> +
> + power1 {
> + label = "bcm53xx:white:power";
> + gpios = <&hc595 2 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + };
> +
> + router0 {
> + label = "bcm53xx:blue:router";
> + gpios = <&hc595 3 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + };
> +
> + router1 {
> + label = "bcm53xx:amber:router";
> + gpios = <&hc595 4 GPIO_ACTIVE_HIGH>;
> + };
> +
> + wan {
> + label = "bcm53xx:blue:wan";
> + gpios = <&hc595 5 GPIO_ACTIVE_HIGH>;
> + linux,default-trigger = "default-on";
> + };
> +
> + wireless0 {
> + label = "bcm53xx:blue:wireless";
> + gpios = <&hc595 6 GPIO_ACTIVE_HIGH>;
> + };
> +
> + wireless1 {
> + label = "bcm53xx:amber:wireless";
> + gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
> + };
> + };
I'm wondering if all new DTS files should use "function" and "color"
instead of "label". That's preferred solution and I guess it's good idea
to use it for new code.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2
2022-04-12 17:49 ` Rafał Miłecki
@ 2022-04-13 13:09 ` SHIMAMOTO Takayoshi
2022-04-21 14:45 ` SHIMAMOTO Takayoshi
0 siblings, 1 reply; 4+ messages in thread
From: SHIMAMOTO Takayoshi @ 2022-04-13 13:09 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Florian Fainelli, Hauke Mehrtens, bcm-kernel-feedback-list,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel
Thank you for the replies.
On 2022/04/13 2:49, Rafał Miłecki wrote:
>> - 4x 10/100M ethernet switch
>
> Isn't that 10/100/1000?
You are right.
It supports 10/100/1000Mbps.
>> + model = "Buffalo WZR-1166DHP2 (BCM4708)";
>
> We stopped adding SoC name to the "model" value, please drop it.
Understood.
I will fix it as follows
model = "Buffalo WZR-1166DHP2";
>> +
>> + wireless1 {
>> + label = "bcm53xx:amber:wireless";
>> + gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
>
> I'm wondering if all new DTS files should use "function" and "color"
> instead of "label". That's preferred solution and I guess it's good idea
> to use it for new code.
Understood.
I will rewrite it with "function" and "color."
I will post the patch again after testing.
Best regards
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2
2022-04-13 13:09 ` SHIMAMOTO Takayoshi
@ 2022-04-21 14:45 ` SHIMAMOTO Takayoshi
0 siblings, 0 replies; 4+ messages in thread
From: SHIMAMOTO Takayoshi @ 2022-04-21 14:45 UTC (permalink / raw)
To: Rafał Miłecki
Cc: Florian Fainelli, Hauke Mehrtens, bcm-kernel-feedback-list,
Rob Herring, Krzysztof Kozlowski, linux-arm-kernel, devicetree,
linux-kernel, takayoshi.shimamoto.360
Hi
I got a collaborator and decided to make a DT about the previous model
WZR-1166DHP2, the WZR-1166DHP.
These two models differ only in memory capacity.
I will rework some of them into a common patch as dtsi and post it.
Therefore, please discard this patch.
Best regards.
On 2022/04/13 22:09, SHIMAMOTO Takayoshi wrote:
>
> Thank you for the replies.
>
> On 2022/04/13 2:49, Rafał Miłecki wrote:
>>> - 4x 10/100M ethernet switch
>>
>> Isn't that 10/100/1000?
>
> You are right.
> It supports 10/100/1000Mbps.
>
>>> + model = "Buffalo WZR-1166DHP2 (BCM4708)";
>>
>> We stopped adding SoC name to the "model" value, please drop it.
>
> Understood.
>
> I will fix it as follows
> model = "Buffalo WZR-1166DHP2";
>
>>> +
>>> + wireless1 {
>>> + label = "bcm53xx:amber:wireless";
>>> + gpios = <&hc595 7 GPIO_ACTIVE_HIGH>;
>>> + };
>>> + };
>>
>> I'm wondering if all new DTS files should use "function" and "color"
>> instead of "label". That's preferred solution and I guess it's good idea
>> to use it for new code.
>
> Understood.
>
> I will rewrite it with "function" and "color."
>
> I will post the patch again after testing.
>
> Best regards
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-21 14:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-12 15:44 [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2 SHIMAMOTO Takayoshi
2022-04-12 17:49 ` Rafał Miłecki
2022-04-13 13:09 ` SHIMAMOTO Takayoshi
2022-04-21 14:45 ` SHIMAMOTO Takayoshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).