From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 568C6C433EF for ; Thu, 21 Apr 2022 14:45:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1389595AbiDUOsk (ORCPT ); Thu, 21 Apr 2022 10:48:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1356573AbiDUOsh (ORCPT ); Thu, 21 Apr 2022 10:48:37 -0400 Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E98CE0C5; Thu, 21 Apr 2022 07:45:47 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id q1so3907327plx.13; Thu, 21 Apr 2022 07:45:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language :from:to:cc:references:in-reply-to:content-transfer-encoding; bh=in+b1t9I/AYFyIFkIgqViKXfibDH0DzRL81hOpx46Hg=; b=aKNDJIvDaQEaNjOttYctXSuU+OojPCpvcEPTlJzo3aBjl3TR/ZL3n++yus4u1X2nPc nfLNLM8K35XhHj5tawqk7Nbb9RMOZ8/pJbz10pXSjx/SUyw1jQQ0CVmaHKBp3Ts23FpR 8OqfLngAUPW4itxqQL+jeMtaFBausBaheUKifREXWJoYZSrmtbKYZ2L1yKAistQNarqv g4Ahzgcaa5kh9eVw+pE/qDiBXsl8iJpkrLETVf3PD0gUjd9xGdfMUg2E4m5errtRg/jd +Q8govggq8FGcUrRqX4Mc5ERdDqIbS0/ww94X8aZBRIpNKHHbCThtEu85l+H/ndt9H5m eUpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:from:to:cc:references:in-reply-to :content-transfer-encoding; bh=in+b1t9I/AYFyIFkIgqViKXfibDH0DzRL81hOpx46Hg=; b=SRynx9EUme+VQd+a4j4IpcIWtw1c2zpYZlPXD5LlagI4VnzYaMyK6dloIq01E9gi01 4O/qvSnLTTWTHhKvUWYO1kL7pYV5lhhCV9rg4z/PaBYYr523yYuVpek3kxLdugsQ/w8y s57ovlOFxnaowgL/7pwygkcsRGNcunJGLH55YhYpjzDQY6Z7+mtqkCvcWuATVtR0CDKp UXTyUAekhrxBNORn25c7OsYgMPHkGALYdEYLGn+f1k7oRDspkhjWjSroyAxTJvkgtFgc SEntL2e5aP3Svnqv+uAGiC11KCsylfJwqczVoqBGPuohkXPVg9ppcR7Apl9RtWlYBuWG rTFg== X-Gm-Message-State: AOAM533dvhYEI8BHVyI9jIkwhQSsmgBkUMRPHUyW/bae1BOkYuvo84UF 0RjfW0iJdDITytO+xL2psGA= X-Google-Smtp-Source: ABdhPJz4pO+ROCT3iAGkudRxxwypK297Bt7LuQdQt7oIFrXxI/o+XMM8+GSll+FYjqSQdjMK/i2jiA== X-Received: by 2002:a17:90a:178e:b0:1d2:e998:85e1 with SMTP id q14-20020a17090a178e00b001d2e99885e1mr10790308pja.234.1650552346989; Thu, 21 Apr 2022 07:45:46 -0700 (PDT) Received: from ?IPV6:240b:11:ea00:8f10:a9e9:6bed:bfb0:9151? ([240b:11:ea00:8f10:a9e9:6bed:bfb0:9151]) by smtp.gmail.com with ESMTPSA id t19-20020a17090aae1300b001d2b4d3e900sm3004360pjq.41.2022.04.21.07.45.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 21 Apr 2022 07:45:46 -0700 (PDT) Message-ID: <09bebb90-7792-a728-6bc5-775b1c482d3d@gmail.com> Date: Thu, 21 Apr 2022 23:45:39 +0900 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH] ARM: dts: BCM5301X: Add DT for Buffalo WZR-1166DHP2 Content-Language: en-US From: SHIMAMOTO Takayoshi To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Florian Fainelli , Hauke Mehrtens , bcm-kernel-feedback-list@broadcom.com, Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, takayoshi.shimamoto.360@gmail.com References: <20220412154432.12124-1-takayoshi.shimamoto.360@gmail.com> <52225285-3b64-f709-81ff-0c26a9b13c02@gmail.com> In-Reply-To: <52225285-3b64-f709-81ff-0c26a9b13c02@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi I got a collaborator and decided to make a DT about the previous model WZR-1166DHP2, the WZR-1166DHP. These two models differ only in memory capacity. I will rework some of them into a common patch as dtsi and post it. Therefore, please discard this patch. Best regards. On 2022/04/13 22:09, SHIMAMOTO Takayoshi wrote: > > Thank you for the replies. > > On 2022/04/13 2:49, Rafał Miłecki wrote: >>>   - 4x 10/100M ethernet switch >> >> Isn't that 10/100/1000? > > You are right. > It supports 10/100/1000Mbps. > >>> +    model = "Buffalo WZR-1166DHP2 (BCM4708)"; >> >> We stopped adding SoC name to the "model" value, please drop it. > > Understood. > > I will fix it as follows > model = "Buffalo WZR-1166DHP2"; > >>> + >>> +        wireless1 { >>> +            label = "bcm53xx:amber:wireless"; >>> +            gpios = <&hc595 7 GPIO_ACTIVE_HIGH>; >>> +        }; >>> +    }; >> >> I'm wondering if all new DTS files should use "function" and "color" >> instead of "label". That's preferred solution and I guess it's good idea >> to use it for new code. > > Understood. > > I will rewrite it with "function" and "color." > > I will post the patch again after testing. > > Best regards