From: Vineeth Karumanchi <vineeth.karumanchi@amd.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: nicolas.ferre@microchip.com, claudiu.beznea@tuxon.dev,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux@armlinux.org.uk, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
git@amd.com
Subject: Re: [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add wol-arp-packet property
Date: Wed, 31 Jan 2024 13:09:19 +0530 [thread overview]
Message-ID: <09ce2e81-01cc-431f-8acb-076a54e5a7e6@amd.com> (raw)
In-Reply-To: <824aad4d-6b05-4641-b75d-ceaa08b0a4e8@lunn.ch>
Hi Andrew,
On 31/01/24 6:56 am, Andrew Lunn wrote:
> On Tue, Jan 30, 2024 at 04:18:44PM +0530, Vineeth Karumanchi wrote:
>> "wol-arp-packet" property enables WOL with ARP packet.
>> It is an extension to "magic-packet for WOL.
>
> It not clear why this is needed. Is this not a standard feature of the
> IP? Is there no hardware bit indicating the capability?
>
WOL via both ARP and Magic packet is supported by the IP version on ZU+
and Versal. However, user can choose which type of packet to recognize
as a WOL event - magic packet or ARP. The existing DT binding already
describes one entry for wol via magic packet. Hence, adding a new packet
type using the same methodology.
vineeth
> Andrew
next prev parent reply other threads:[~2024-01-31 7:39 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 10:48 [PATCH net-next 0/3] net: macb: WOL enhancements Vineeth Karumanchi
2024-01-30 10:48 ` [PATCH net-next 1/3] net: macb: queue tie-off or disable during WOL suspend Vineeth Karumanchi
2024-02-03 15:38 ` claudiu beznea
2024-02-06 15:44 ` Karumanchi, Vineeth
2024-02-15 5:43 ` Karumanchi, Vineeth
2024-02-15 10:19 ` claudiu beznea
2024-01-30 10:48 ` [PATCH net-next 2/3] dt-bindings: net: cdns,macb: Add wol-arp-packet property Vineeth Karumanchi
2024-01-30 17:30 ` Conor Dooley
2024-01-31 7:23 ` Vineeth Karumanchi
2024-01-31 1:26 ` Andrew Lunn
2024-01-31 7:39 ` Vineeth Karumanchi [this message]
2024-01-31 7:45 ` Krzysztof Kozlowski
2024-01-31 13:18 ` Andrew Lunn
2024-02-01 6:41 ` Vineeth Karumanchi
2024-02-01 13:12 ` Andrew Lunn
2024-02-01 16:32 ` Karumanchi, Vineeth
2024-01-30 10:48 ` [PATCH net-next 3/3] net: macb: Add ARP support to WOL Vineeth Karumanchi
2024-01-30 21:27 ` Vadim Fedorenko
2024-01-31 2:13 ` [PATCH net-next 0/3] net: macb: WOL enhancements Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ce2e81-01cc-431f-8acb-076a54e5a7e6@amd.com \
--to=vineeth.karumanchi@amd.com \
--cc=andrew@lunn.ch \
--cc=claudiu.beznea@tuxon.dev \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=git@amd.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).