From: "Nuno Sá" <noname.nuno@gmail.com>
To: Nuno Sa <nuno.sa@analog.com>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org
Cc: Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH v4 0/3] Add support for LTC4282
Date: Tue, 09 Jan 2024 13:19:43 +0100 [thread overview]
Message-ID: <09d0ecb0460aafb3f45d3d17b1b40605d7d28b2a.camel@gmail.com> (raw)
In-Reply-To: <20231218-b4-ltc4282-support-v4-0-4fc51f7d04f0@analog.com>
On Mon, 2023-12-18 at 17:29 +0100, Nuno Sa wrote:
> v1:
> *
> https://lore.kernel.org/linux-hwmon/20231110151905.1659873-1-nuno.sa@analog.com/
>
> v2:
> *
> https://lore.kernel.org/linux-hwmon/20231124-ltc4282-support-v2-0-952bf926f83c@analog.com
>
> v3:
> *
> https://lore.kernel.org/r/20231205-ltc4282-support-v3-0-e0877b281bc2@analog.com
>
> Changes in v4:
> - Patch 1:
> * New patch. Support fault attributes in voltage channels.
> - Patch 2:
> * Add default values for gpios and divider properties;
> * Add adi,gpio3-monitor-enable property.
> - Patch 3:
> - Docs:
> * Document that fault logs are also cleared when writing in reset_history
> attributes;
> * Document debugfs entries;
> * Add new in0_fault attributes and remove dropped ones.
> - Driver:
> * Add hwmon_in_fault attribute to report FET failures in VSOURCE;
> * Clear fault logs in reset_history;
> * Constify 'ltc4282_out_rates';
> * Add missing error check in ltc4282_cache_history();
> * Removed unused functions;
> * Renamed clk provider name so it's unique per device;
> * Support new adi,gpio3-monitor-enable property;
> * Dropped power1_good, fet_bad_fault, fet_short_fault, fault_logs_reset
> custom attributes. Note that only power1_good was really dropped.
> The other ones are supported in standard ABI.
> * Renamed debugfs directory for ltc4282-hwmonX;
> * Added in0 prefix to FET fault logs so it's clear they affect VSOURCE;
> * Fix in_range() condition (false means error);
> * Fix reset_history attributes. We should not write 0 in the lowest
> value. Write the theoretical max value in there. For vsource/vdd,
> also do it during device setup (or we would end up with 0).
> * Directly store the chip vdd instead of vin_mode in our device
> structure. Easier to handle reset_history;
> * Moved the vin_mode enum to reduce it's scope.
>
> As mentioned in v3 discussion, clearing the power bad fault log has no
> effect but I'm still doing it for consistency and because we also allow
> to read it in debugfs (so better allow to clear it as well)
>
> ---
> Nuno Sa (3):
> dt-bindings: hwmon: Add LTC4282 bindings
> hwmon: add fault attribute for voltage channels
> hwmon: ltc4282: add support for the LTC4282 chip
>
> Documentation/ABI/testing/sysfs-class-hwmon | 9 +
> .../devicetree/bindings/hwmon/adi,ltc4282.yaml | 159 ++
> Documentation/hwmon/index.rst | 1 +
> Documentation/hwmon/ltc4282.rst | 133 ++
> MAINTAINERS | 8 +
> drivers/hwmon/Kconfig | 11 +
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/hwmon.c | 1 +
> drivers/hwmon/ltc4282.c | 1784
> ++++++++++++++++++++
> include/linux/hwmon.h | 2 +
> 10 files changed, 2109 insertions(+)
>
> Thanks!
> - Nuno Sá
>
Hi Guenter,
Just pinging this one. Not sure if you missed this one or just low priority in
your queue :)
- Nuno Sá
next prev parent reply other threads:[~2024-01-09 12:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 16:29 [PATCH v4 0/3] Add support for LTC4282 Nuno Sa
2023-12-18 16:29 ` [PATCH v4 1/3] dt-bindings: hwmon: Add LTC4282 bindings Nuno Sa
2023-12-19 16:39 ` Conor Dooley
2023-12-20 8:48 ` Nuno Sá
2023-12-18 16:29 ` [PATCH v4 2/3] hwmon: add fault attribute for voltage channels Nuno Sa
2023-12-18 16:29 ` [PATCH v4 3/3] hwmon: ltc4282: add support for the LTC4282 chip Nuno Sa
2024-01-09 12:19 ` Nuno Sá [this message]
2024-01-09 15:17 ` [PATCH v4 0/3] Add support for LTC4282 Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09d0ecb0460aafb3f45d3d17b1b40605d7d28b2a.camel@gmail.com \
--to=noname.nuno@gmail.com \
--cc=conor+dt@kernel.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=nuno.sa@analog.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).