From: Sudeep Holla <sudeep.holla@arm.com>
To: Lina Iyer <lina.iyer@linaro.org>
Cc: Sudeep Holla <sudeep.holla@arm.com>,
rjw@rjwysocki.net, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, ulf.hansson@linaro.org,
khilman@kernel.org, andy.gross@linaro.org, sboyd@codeaurora.org,
linux-arm-msm@vger.kernel.org, brendan.jackman@arm.com,
lorenzo.pieralisi@arm.com, Juri.Lelli@arm.com,
devicetree@vger.kernel.org,
Marc Titinger <mtitinger+renesas@baylibre.com>
Subject: Re: [PATCH v2 5/8] dt/bindings: Update binding for PM domain idle states
Date: Mon, 10 Oct 2016 18:19:21 +0100 [thread overview]
Message-ID: <09dce7fd-6757-12ad-1900-573bf75b27a4@arm.com> (raw)
In-Reply-To: <20161010164342.GC44885@linaro.org>
On 10/10/16 17:43, Lina Iyer wrote:
> On Mon, Oct 10 2016 at 09:45 -0600, Sudeep Holla wrote:
>>
>>
>> On 07/10/16 23:36, Lina Iyer wrote:
>>> Update DT bindings to describe idle states of PM domains.
>>>
>>> This patch is based on the original patch by Marc Titinger.
>>>
>>> Cc: <devicetree@vger.kernel.org>
>>> Signed-off-by: Marc Titinger <mtitinger+renesas@baylibre.com>
>>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>>> Signed-off-by: Lina Iyer <lina.iyer@linaro.org>
>>> Acked-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../devicetree/bindings/power/power_domain.txt | 38
>>> ++++++++++++++++++++++
>>> 1 file changed, 38 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/power/power_domain.txt
>>> b/Documentation/devicetree/bindings/power/power_domain.txt
>>> index 025b5e7..7f8f27e 100644
>>> --- a/Documentation/devicetree/bindings/power/power_domain.txt
>>> +++ b/Documentation/devicetree/bindings/power/power_domain.txt
>>> @@ -29,6 +29,10 @@ Optional properties:
>>> specified by this binding. More details about power domain
>>> specifier are
>>> available in the next section.
>>>
>>> +- domain-idle-states : A phandle of an idle-state that shall be
>>> soaked into a
>>> + generic domain power state. The idle state
>>> definitions are
>>> + compatible with arm,idle-state specified in [1].
>>> +
>>
>> Please do add the following details to the binding. IMO, this binding is
>> not complete in terms of specification as there are few open questions:
>>
>> 1. What not define a standard compatible instead of "arm,idle-state" ?
>> I agree it can be used, but as part of this *generic* binding, IMO
>> it's better to have something generic and can be used by devices.
>> Otherwise, this binding becomes CPU specific, that too ARM CPU
>> specific.
>>
> We had gone down this path of having a separate DT bindings for domains
> that is not arm,idle-state. See RFC patches. But the binding did closely
> match this and it so was suggested that we use arm,idle-state which is
> already defined.
>
Are you referring to [1] here ? Sorry, I did some search quickly and
could find this, wanted to check if I am looking at the right one ?
--
Regards,
Sudeep
[1]
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-June/353261.html
prev parent reply other threads:[~2016-10-10 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1475879821-8035-1-git-send-email-lina.iyer@linaro.org>
2016-10-07 22:36 ` [PATCH v2 5/8] dt/bindings: Update binding for PM domain idle states Lina Iyer
2016-10-10 15:45 ` Sudeep Holla
2016-10-10 16:43 ` Lina Iyer
[not found] ` <20161010164342.GC44885-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-10-10 17:13 ` Sudeep Holla
2016-10-10 22:13 ` Lina Iyer
2016-10-11 11:29 ` Sudeep Holla
2016-10-10 17:19 ` Sudeep Holla [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09dce7fd-6757-12ad-1900-573bf75b27a4@arm.com \
--to=sudeep.holla@arm.com \
--cc=Juri.Lelli@arm.com \
--cc=andy.gross@linaro.org \
--cc=brendan.jackman@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@kernel.org \
--cc=lina.iyer@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mtitinger+renesas@baylibre.com \
--cc=rjw@rjwysocki.net \
--cc=sboyd@codeaurora.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox