From: Sven Peter <sven@kernel.org>
To: Nick Chan <towinchenmi@gmail.com>, Janne Grunau <j@jannau.net>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Neal Gompa <neal@gompa.dev>, Stephen Boyd <sboyd@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Sasha Finkelstein <fnkl.kernel@gmail.com>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] dt-bindings: spmi: Add Apple A11 and T2 compatible
Date: Sun, 31 Aug 2025 20:23:03 +0200 [thread overview]
Message-ID: <09e1a345-21d5-4ff7-831c-755e00898a45@kernel.org> (raw)
In-Reply-To: <20250829-t8015-spmi-v3-1-58b15ee2c825@gmail.com>
On 29.08.25 10:47, Nick Chan wrote:
> The SPMI bus found on Apple A11 and T2 SoCs are compatible with the
> existing driver for t8103's spmi so add their compatibles.
>
> Acked-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Sven Peter <sven@kernel.org>
Please drops those tags if you make a significant change like you did
here between v2 and v3.
> Signed-off-by: Nick Chan <towinchenmi@gmail.com>
> ---
[...]
> @@ -27,7 +30,6 @@ properties:
> - apple,t6000-spmi
> - apple,t8112-spmi
> - const: apple,spmi
> -
Why are you removing the blank line here?
Sven
next prev parent reply other threads:[~2025-08-31 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 8:46 [PATCH v3 0/3] SPMI dt-bindings and nodes for Apple A11 and T2 SoCs Nick Chan
2025-08-29 8:47 ` [PATCH v3 1/3] dt-bindings: spmi: Add Apple A11 and T2 compatible Nick Chan
2025-08-31 18:23 ` Sven Peter [this message]
2025-08-29 8:47 ` [PATCH v3 2/3] arm64: dts: apple: t8012: Add SPMI node Nick Chan
2025-08-29 8:47 ` [PATCH v3 3/3] arm64: dts: apple: t8015: " Nick Chan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09e1a345-21d5-4ff7-831c-755e00898a45@kernel.org \
--to=sven@kernel.org \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fnkl.kernel@gmail.com \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=towinchenmi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).