devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: Vijay Khemka <vijaykhemka@fb.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Thierry Reding <treding@nvidia.com>,
	David Lechner <david@lechnology.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Johan Hovold <johan@kernel.org>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	openbmc@lists.ozlabs.org
Subject: Re: [PATCH 1/2] ARM: dt-bindings: aspeed: Facebook TiogaPass BMC
Date: Wed, 19 Sep 2018 18:34:07 +0200	[thread overview]
Message-ID: <09e425e4-9199-dccd-a8ab-4fbd9f384677@suse.de> (raw)
In-Reply-To: <20180919162918.3994257-1-vijaykhemka@fb.com>

Hi,

Subject should be "dt-bindings: Add vendor prefix for Facebook" or so.
Please compare other commits for that file.

Am 19.09.18 um 18:29 schrieb Vijay Khemka:
> Initial introduction of Facebook TiogaPass family equipped with
> Aspeed 2500 BMC SoC. TiogaPass is a x86 server development kit
> with a ASPEED ast2500 BMC manufactured by Facebook.
> 
> This adds an entry of Facebook in Documentation for vendor prefix

Lacking Signed-off-by.

> ---
>  Documentation/devicetree/bindings/vendor-prefixes.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.txt b/Documentation/devicetree/bindings/vendor-prefixes.txt
> index 2c3fc512e746..0520303ee5b8 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.txt
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.txt
> @@ -127,6 +127,7 @@ everspin	Everspin Technologies, Inc.
>  exar	Exar Corporation
>  excito	Excito
>  ezchip	EZchip Semiconductor
> +facebook	Facebook
>  fairphone	Fairphone B.V.
>  faraday	Faraday Technology Corporation
>  fastrax	Fastrax Oy

Otherwise looking better.

Thanks,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

      reply	other threads:[~2018-09-19 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 16:29 [PATCH 1/2] ARM: dt-bindings: aspeed: Facebook TiogaPass BMC Vijay Khemka
2018-09-19 16:34 ` Andreas Färber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=09e425e4-9199-dccd-a8ab-4fbd9f384677@suse.de \
    --to=afaerber@suse.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=david@lechnology.com \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=openbmc@lists.ozlabs.org \
    --cc=robh+dt@kernel.org \
    --cc=treding@nvidia.com \
    --cc=vijaykhemka@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).