From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C4CC433FE for ; Fri, 4 Nov 2022 13:05:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231591AbiKDNFq (ORCPT ); Fri, 4 Nov 2022 09:05:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229823AbiKDNFj (ORCPT ); Fri, 4 Nov 2022 09:05:39 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F190126130 for ; Fri, 4 Nov 2022 06:05:37 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id c25so6247535ljr.8 for ; Fri, 04 Nov 2022 06:05:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SYrK27Y7dZ1jhUa6GS6pzCvsdezIl8UwJaQy+2V3EMQ=; b=Gqjzr0nWeEsl84UdwGD14ZyF+MWwWNgbhRuKA1o+VlLjsGL2p2mhN4Pmj2DY39fh4H TsGCV0TDsCcbg9oIsAT7NOgzTXDHOkWmcQ0ztE2ntWcNqKsllVu2FPvY6j28MwRgtZXg r6mPXrV0w1jhu8iTgroSeW22J3wRieD+lrA1aLKQLFjrVxoW4r6FEfXXn5gPsGP+e75p zr/+fFXf11+WJCwYgbVQK+qZH9QBSfe9JfEwdO51g20A5U7hwramohWc3NeI+DzFQZZW MuINkovvZYfas45U09iUWmasvBS6Ot3UvMft8610aGA+79ji49dLey+wo+FOPZZA9/Mu kgpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SYrK27Y7dZ1jhUa6GS6pzCvsdezIl8UwJaQy+2V3EMQ=; b=Eo9GFnqQ1x9Q9JaH8kg/RberT+P9zypPMF53XVR+j1dNkxf+2EgEpWUtshuDjPLCtZ gYHhkcYSep3AH9bEDHkJLyKX8S+sOXphV8IapNjWrFcjpfhNV9Nj3K3EeyQGhLgiMKEU QUWcOr2BS3ibwDdwP+fAWA6nTfSE0Q/IV/K1j429ibi5NBqdEy8LOG1JYagz3u+UMCtz m88ymmcOZM1qK/gmypSHO0bhTLiS72YkSKkRAX38H1IUMT4eDmOwrl/D/DrVg+whDO2F pCAXJ7yaP943yJx9YrLp49Orr3nE81+6/JD0WhN4VHyBqFzpaEpWCvDCFcJAfy447Iqy pLXg== X-Gm-Message-State: ACrzQf2ROAU9dhpp6SbUTQl47JT4XtNUgDgfcujMU2PNI6TO7meACL6r IOxbqsH88zesITJ/G8YRl0TgkA== X-Google-Smtp-Source: AMsMyM6g8cHyYxtEdvEFeoTBLMKnwcd++/thOcg1sqK+QLMPo1SmzwiLU8ccKO49yJIQC+bzFEHnjw== X-Received: by 2002:a2e:a37a:0:b0:277:2e8a:bc82 with SMTP id i26-20020a2ea37a000000b002772e8abc82mr14137188ljn.391.1667567136167; Fri, 04 Nov 2022 06:05:36 -0700 (PDT) Received: from [10.27.10.248] ([195.165.23.90]) by smtp.gmail.com with ESMTPSA id e16-20020a195010000000b004b097f2c73dsm451328lfb.253.2022.11.04.06.05.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 06:05:35 -0700 (PDT) Message-ID: <09ed16e1-4af2-8fce-dab4-f6c0f09e688c@linaro.org> Date: Fri, 4 Nov 2022 16:05:33 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH v9 00/12] dt-bindings: display/msm: rework MDSS and DPU bindings Content-Language: en-GB To: Rob Herring Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Krzysztof Kozlowski , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20221024164225.3236654-1-dmitry.baryshkov@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 04/11/2022 15:21, Rob Herring wrote: > On Mon, Oct 24, 2022 at 11:42 AM Dmitry Baryshkov > wrote: >> >> Create separate YAML schema for MDSS devicesd$ (both for MDP5 and DPU >> devices). Cleanup DPU schema files, so that they do not contain schema >> for both MDSS and DPU nodes. Apply misc small fixes to the DPU schema >> afterwards. Add schema for the MDSS and DPU on sm8250 platform. >> >> Soft dependency on [1] to define qcom,dsi-phy-14nm-2290 binding used in >> examples >> >> [1] https://lore.kernel.org/linux-arm-msm/20220924121900.222711-1-dmitry.baryshkov@linaro.org/ >> >> Changes since v8: >> - Dropped DSI/DSI-PHY examples from the first patch. Proper example >> generate a pile of warnings because of DSI schema deficiencies. I'll >> add these examples back, once DSI schema is fixed. >> >> Changes since v7: >> - Expanded examples to include MDSS child nodes (Krzysztof) >> >> Changes since v6: >> - Removed extra newlines (Krzysztof) >> - Added $ref to dpu-common.yaml#/ports/port@foo to enforce schema >> for the port nodes (Rob) >> - Removed unused allOf's (Rob) >> - Fixed repeated interconnects descriptions (Rob) >> - Fixed dpu-common.yaml and mdss-common.yaml descriptions (Rob) >> - Fixed intentation of examples (Krzysztof) >> - Renamed MDSS and DPU schema to follow compat names (Rob) >> >> Changes since v5: >> - Dropped the core clock from mdss.yaml. It will be handled in a >> separate patchset together with adding the clock itself. >> - Fixed a typo in two commit subjects (mdm -> msm). >> >> Changes since v4: >> - Created separate mdss-common.yaml >> - Rather than squashing everything into mdss.yaml, create individual >> schema files for MDSS devices. >> >> Changes since v3: >> - Changed mdss->(dpu, dsi, etc.) relationship into the tight binding >> depending on the mdss compatible string. >> - Added sm8250 dpu schema and added qcom,sm8250-mdss to mdss.yaml >> >> Changes since v2: >> - Added a patch to allow opp-table under the dpu* nodes. >> - Removed the c&p issue which allowed the @0 nodes under the MDSS >> device node. >> >> Changes since v1: >> - Renamed DPU device nodes from mdp@ to display-controller@ >> - Described removal of mistakenly mentioned "lut" clock >> - Switched mdss.yaml to use $ref instead of fixing compatible strings >> - Dropped mdp-opp-table description (renamed by Krzysztof in his >> patchset) >> - Reworked DPU's ports definitions. Dropped description of individual >> ports, left only /ports $ref and description in dpu-common.yaml. >> >> Dmitry Baryshkov (12): >> dt-bindings: display/msm: split qcom,mdss bindings >> dt-bindings: display/msm: add gcc-bus clock to dpu-smd845 >> dt-bindings: display/msm: add interconnects property to >> qcom,mdss-smd845 >> dt-bindings: display/msm: move common DPU properties to >> dpu-common.yaml >> dt-bindings: display/msm: move common MDSS properties to >> mdss-common.yaml >> dt-bindings: display/msm: split dpu-sc7180 into DPU and MDSS parts >> dt-bindings: display/msm: split dpu-sc7280 into DPU and MDSS parts >> dt-bindings: display/msm: split dpu-sdm845 into DPU and MDSS parts >> dt-bindings: display/msm: split dpu-msm8998 into DPU and MDSS parts >> dt-bindings: display/msm: split dpu-qcm2290 into DPU and MDSS parts >> dt-bindings: display/msm: add missing device nodes to mdss-* schemas >> dt-bindings: display/msm: add support for the display on SM8250 > > This is now warning in linux-next: > > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,sc7180-mdss.example.dtb: > dsi@ae94000: 'opp-table' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,sm8250-mdss.example.dtb: > dsi@ae94000: 'opp-table' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml These two will be fixed by https://patchwork.freedesktop.org/patch/509664/?series=108883&rev=2, I'll merge it in asap, so that it appears in next linux-next. > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,qcm2290-mdss.example.dtb: > dsi@5e94000: compatible: 'oneOf' conditional failed, one must be > fixed: > 'qcom,dsi-ctrl-6g-qcm2290' does not match Ack, I'll take an immediate look on fixing this. > '^qcom,(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+-.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,(sa|sc)8[0-9]+[a-z][a-z]?-.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,[ak]pss-wdt-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,gcc-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,mmcc-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,pcie-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,rpm-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' does not match > '^qcom,scm-(apq|ipq|mdm|msm|qcm|qcs|sa|sc|sdm|sdx|sm)[0-9]+.*$' > 'qcom,dsi-ctrl-6g-qcm2290' is not one of ['qcom,gpucc-sdm630', > 'qcom,gpucc-sdm660', 'qcom,lcc-apq8064', 'qcom,lcc-ipq8064', > 'qcom,lcc-mdm9615', 'qcom,lcc-msm8960', 'qcom,lpass-cpu-apq8016', > 'qcom,usb-ss-ipq4019-phy', 'qcom,usb-hs-ipq4019-phy', > 'qcom,vqmmc-ipq4019-regulator'] > 'qcom,dsi-ctrl-6g-qcm2290' is not one of ['qcom,ipq806x-gmac', > 'qcom,ipq806x-nand', 'qcom,ipq806x-sata-phy', > 'qcom,ipq806x-usb-phy-ss', 'qcom,ipq806x-usb-phy-hs'] > From schema: > /builds/robherring/linux-dt/Documentation/devicetree/bindings/arm/qcom-soc.yaml > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/qcom,sc7280-mdss.example.dtb: > dsi@ae94000: 'opp-table' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: > /builds/robherring/linux-dt/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml -- With best wishes Dmitry