From: Christoph Niedermaier <cniedermaier@dh-electronics.com>
To: Marek Vasut <marex@denx.de>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: Conor Dooley <conor+dt@kernel.org>,
Fabio Estevam <festevam@gmail.com>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Rob Herring <robh@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Shawn Guo <shawnguo@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>,
kernel <kernel@dh-electronics.com>
Subject: RE: [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys
Date: Wed, 16 Oct 2024 08:28:40 +0000 [thread overview]
Message-ID: <09ed8d5735494da487d1b0dc72395c1d@dh-electronics.com> (raw)
In-Reply-To: <20241015224505.94359-1-marex@denx.de>
From: Marek Vasut <marex@denx.de>
Sent: Wednesday, October 16, 2024 12:45 AM
> Bindings do not allow address/size-cells in GPIO keys and the GPIO keys
> is not a bus, see dtbs_check warning:
>
> "
> arch/arm/boot/dts/nxp/imx/imx6dl-dhcom-pdk2.dtb: gpio-keys: '#address-cells', '#size-
> cells' do not match any of the regexes:
> '^(button|event|key|switch|(button|event|key|switch)-[a-z0-9-]+|[a-z0-9-]+-
> (button|event|key|switch))$', 'pinctrl-[0-9]+'
> "
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Rob Herring <robh@kernel.org>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-arm-kernel@lists.infradead.org
> ---
> arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> index 6248b126b5578..773fdcfcd0015 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-dhcom-pdk2.dtsi
> @@ -56,7 +56,6 @@ lcd_display_out: endpoint {
> };
>
> gpio-keys {
> - #size-cells = <0>;
> compatible = "gpio-keys";
>
> button-0 {
Reviewed-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
next prev parent reply other threads:[~2024-10-16 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-15 22:44 [PATCH] ARM: dts: imx6qdl-dhcom-pdk2: Drop incorrect size-cells in GPIO keys Marek Vasut
2024-10-16 8:28 ` Christoph Niedermaier [this message]
2024-10-22 1:45 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ed8d5735494da487d1b0dc72395c1d@dh-electronics.com \
--to=cniedermaier@dh-electronics.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@dh-electronics.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).