From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC78C678D4 for ; Mon, 16 Jan 2023 16:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233669AbjAPQmN (ORCPT ); Mon, 16 Jan 2023 11:42:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34714 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233648AbjAPQlp (ORCPT ); Mon, 16 Jan 2023 11:41:45 -0500 Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C31062ED46 for ; Mon, 16 Jan 2023 08:29:57 -0800 (PST) Received: by mail-lf1-x12f.google.com with SMTP id br9so8156001lfb.4 for ; Mon, 16 Jan 2023 08:29:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=G8K1RmWXIkiPGKo5rdIMlyUws+ytI7cIHwrzZJ2azso=; b=Qwo73i7k4TFVW4W9ODHn2D31owplGN+ohI4BcXolF/ZQkD6do3Wcxz1nYOC9CNXonX jS1RVfnJcQQVABWLq0jNH4zheVyf4h+GMcbONNoUdnri7EXnXonvt/hUQXFZFO1J4VIE /jj/OeKV1qAbQdKi2V/45Q69RwkZ8rR1pOiTPZ1lgP/79MZ4kFTQhJqM76J+i1+8w8nD ayeX1QToZyVrwU1GjlFcCXzJZKQ2R6Xhc/a61usDxr0B9tyokNrdPmr3dzt94h2Cm+WG Sme/OPxLhDfUbhZysJgMsukjfrMJJnmj+xESqgD7xAN7XGm9ZDJkXBjaapDzuKZltmpU 79hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=G8K1RmWXIkiPGKo5rdIMlyUws+ytI7cIHwrzZJ2azso=; b=uk1ZhHtW9scZXUXgA2KM5v+Vl6azXyNkmXB+dibkmYhzndbRB0P7Et0BfrhutoZ+K7 O9NWUK8/pwMIkWYoGRUOfiGqZo0vDeUe6uTnOy6k9/wNakzywbngROX3xwjvoLx2GjIo a1axt4kLh6G1wlh8yDKataJPt7yvRowvMHZtyTeZyrCS+gs3ts1gcawfxRZZvTdPFDjB vD+gQPRqm3vbzZ+MtIJICFxBU4Lxt5c45BqjptNCkt0gbIhV4v89MVVcMhrs1tzjRxwk jC6WkJAhTFQnC11jLUHSxtNZd3JKC2rz7pYMcPnN4mcTcbFZbsHpn/8IPtSFVnS0Ci6M KCTQ== X-Gm-Message-State: AFqh2krvw+cBchq/ZkCnKdJ/QnRiU4vsZxzIUtz4UnXhyNELbKk+0jmH 7jhQG+J7zJhmdW3c3/UhOXO48g== X-Google-Smtp-Source: AMrXdXsPIZj1jWkctfyszi9JmAGWKyuU0BIXMPnSpGeeviVYMWHd72EtUdKxhks7JtVTHMQhAtHFmg== X-Received: by 2002:a19:e611:0:b0:4a4:68b9:608a with SMTP id d17-20020a19e611000000b004a468b9608amr24195186lfh.21.1673886596181; Mon, 16 Jan 2023 08:29:56 -0800 (PST) Received: from [192.168.1.101] (abym53.neoplus.adsl.tpnet.pl. [83.9.32.53]) by smtp.gmail.com with ESMTPSA id x12-20020ac25dcc000000b0049fbf5facf4sm5087974lfq.75.2023.01.16.08.29.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jan 2023 08:29:55 -0800 (PST) Message-ID: <09fe3e93-328b-13a3-540b-4ca47224b176@linaro.org> Date: Mon, 16 Jan 2023 17:29:54 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] dt-bindings: qcom: geni-se: Fix '#address-cells' & '#size-cells' related dt-binding error Content-Language: en-US To: bhupesh.sharma@linaro.org, Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, agross@kernel.org, andersson@kernel.org, linux-kernel@vger.kernel.org, bhupesh.linux@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org References: <20230113201038.267449-1-bhupesh.sharma@linaro.org> <23b4551c-db79-d859-c037-6ed3c8a11883@linaro.org> <6f08d466-9589-ebff-c38d-bf9015a0f6ad@linaro.org> <64e4b3b0-fc71-1876-9de8-e51d503d6183@linaro.org> <3e18a79b-fdd8-63f8-c27a-7515bbb6cb9b@linaro.org> From: Konrad Dybcio In-Reply-To: <3e18a79b-fdd8-63f8-c27a-7515bbb6cb9b@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.01.2023 17:18, bhupesh.sharma@linaro.org wrote: > > On 1/16/23 9:35 PM, Konrad Dybcio wrote: >> >> >> On 16.01.2023 17:02, Bhupesh Sharma wrote: >> > >> > On 1/16/23 9:24 PM, Konrad Dybcio wrote: >> >> >> >> >> >> On 16.01.2023 16:43, Bhupesh Sharma wrote: >> >>> On Mon, 16 Jan 2023 at 13:23, Krzysztof Kozlowski >> >>> wrote: >> >>>> >> >>>> On 15/01/2023 22:33, Bhupesh Sharma wrote: >> >>>>> On Sun, 15 Jan 2023 at 20:57, Krzysztof Kozlowski >> >>>>> wrote: >> >>>>>> >> >>>>>> On 13/01/2023 21:10, Bhupesh Sharma wrote: >> >>>>>>> Fix the following '#address-cells' & '#size-cells' related >> >>>>>>> dt-binding error: >> >>>>>>> >> >>>>>>>      $ make dtbs_check >> >>>>>>> >> >>>>>>>      From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> >>>>>>>           arch/arm64/boot/dts/qcom/sm4250-oneplus-billie2.dtb: geniqup@4ac0000: >> >>>>>>>                 #address-cells:0:0: 2 was expected >> >>>>>>>         From schema: Documentation/devicetree/bindings/soc/qcom/qcom,geni-se.yaml >> >>>>>> >> >>>>>> Don't we want rather to unify the soc address range? >> >>>>> >> >>>>> Well, the assumption in the original dt-bindings was that every reg >> >>>>> variable is 4 * u32 wide (as most new qcom SoCs set #address- and >> >>>>> #size-cells to <2>). However, that is not the case for all of the >> >>>>> SoCs. >> >>>> >> >>>> Hm, which device of that SoC cannot be used with address/size cells 2? >> >>> >> >>> As noted in the git log already the geniqup on sm6115 / sm4250 cannot >> >>> be used with address/size cells 2 (See: >> >>> https://github.com/torvalds/linux/blob/master/arch/arm64/boot/dts/qcom/sm6115.dtsi#L795) >> >> SM6115 (and pretty much every other arm64 msm platform newer than 8916) >> >> should be using addr/size-cells = 2 along with (dma-)ranges of 36 bit, as >> >> that's what their smmus use and otherwise some addresses may get cut off >> >> in translation, or so the story went with 845 N years ago.. We can either >> >> pursue this patch or I can submit the 2-cell-ification if you don't plan on >> >> adding more nodes shortly >> > >> > >> > Have you tested this combination on SM6115 like SoCs with various IPs? I have tried a few experiments in the past and not all IPs work well with 36-bit DMA ranges (atleast not on the boards I have). >> Can you list any specific examples? I've been using it for >> quite some time now and I see nothing wrong.. > > I remember seeing some issues with SDHC controller booting (uSD card use case) with sm6115, but I cannot find the appropriate dmesg right now. FWIW it works completely fine for me, in fact I'm booting from uSD most of the time. Konrad > >> > >> > So, I think it might lead to more breakage (unless we are sure of a well-tested fix). A simpler patch to fix the dt-bindings looks more useful IMO. >> I'm not saying no, you just have to convince Krzysztof :D > > :) > > Thanks, > Bhupesh