From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Jiucheng Xu <jiucheng.xu@amlogic.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Will Deacon <will@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Chris Healy <cphealy@gmail.com>
Subject: Re: [PATCH v5 3/4] dt-binding: perf: Add Amlogic DDR PMU
Date: Thu, 18 Aug 2022 11:25:37 +0300 [thread overview]
Message-ID: <0a10f55c-1e91-de8d-74c1-e2778841b7fc@linaro.org> (raw)
In-Reply-To: <20220817113423.2088581-3-jiucheng.xu@amlogic.com>
On 17/08/2022 14:34, Jiucheng Xu wrote:
> Add binding documentation for the Amlogic G12 series DDR
> performance monitor unit.
>
> Signed-off-by: Jiucheng Xu <jiucheng.xu@amlogic.com>
(...)
> +
> + interrupts:
> + items:
> + - description: The IRQ of the inside timer timeout.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + pmu {
> + #address-cells=<2>;
> + #size-cells=<2>;
> +
> + pmu@ff638000 {
> +
No need for blank line.
> + compatible = "amlogic,g12a-ddr-pmu";
> + reg = <0x0 0xff638000 0x0 0x100>,
> + <0x0 0xff638c00 0x0 0x100>;
> + interrupts = <GIC_SPI 52 IRQ_TYPE_EDGE_RISING>;
> + };
> + };
With above fixed:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-08-18 8:26 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-17 11:34 [PATCH v5 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Jiucheng Xu
2022-08-17 11:34 ` [PATCH v5 2/4] docs/perf: Add documentation for the Amlogic G12 DDR PMU Jiucheng Xu
2022-08-17 11:34 ` [PATCH v5 3/4] dt-binding: perf: Add Amlogic " Jiucheng Xu
2022-08-18 8:25 ` Krzysztof Kozlowski [this message]
2022-08-19 13:44 ` Jiucheng Xu
2022-08-19 13:56 ` Krzysztof Kozlowski
2022-08-17 11:34 ` [PATCH v5 4/4] arm64: dts: meson: Add DDR PMU node Jiucheng Xu
2022-08-18 8:30 ` [PATCH v5 1/4] perf/amlogic: Add support for Amlogic meson G12 SoC DDR PMU driver Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a10f55c-1e91-de8d-74c1-e2778841b7fc@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=cphealy@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=jiucheng.xu@amlogic.com \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).