Re: [PATCH 1/7] arm64: dts: ti: k3-j721s2-main: Add interrupts property

[Krzysztof Kozlowski <krzk@kernel.org>]

On 21/07/2025 16:12, Kumar, Udit wrote:
> 
> On 7/21/2025 7:39 PM, Krzysztof Kozlowski wrote:
>> On 21/07/2025 16:07, Kumar, Udit wrote:
>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> index 62f45377a2c9..6f32a2b0c40c 100644
>>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>>> @@ -1248,6 +1248,9 @@ ti_csi2rx0: ticsi2rx@4500000 {
>>>>    		cdns_csi2rx0: csi-bridge@4504000 {
>>>>    			compatible = "ti,j721e-csi2rx", "cdns,csi2rx";
>>>>    			reg = <0x00 0x04504000 0x00 0x1000>;
>>>> +			interrupts = <GIC_SPI 153 IRQ_TYPE_LEVEL_HIGH>,
>>>> +				     <GIC_SPI 152 IRQ_TYPE_LEVEL_HIGH>;
>>> Just cosmetic thing, if you are doing v2 then consider 152 first ,
>>> followed by 153.
>>
>> No, you cannot just randomly change numbers or the order.
>>
> To be precise both , interrupt-names and interrupts,
> 
> if this make sense to change.

No, it does not makes any sense. You cannot change the order and if you
tested this, you would see errors.

Best regards,
Krzysztof