From: Johannes Zink <j.zink@pengutronix.de>
To: Rob Herring <robh@kernel.org>
Cc: kishon@kernel.org, devicetree@vger.kernel.org,
krzysztof.kozlowski+dt@linaro.org, festevam@gmail.com,
s.hauer@pengutronix.de, vkoul@kernel.org, haibo.chen@nxp.com,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-phy@lists.infradead.org, shawnguo@kernel.org,
linux-arm-kernel@lists.infradead.org, jun.li@nxp.com,
patchwork-jzi@pengutronix.de
Subject: Re: [PATCH 1/2] dt-bindings: phy: imx8mq-usb: add phy tuning properties
Date: Thu, 4 May 2023 09:32:11 +0200 [thread overview]
Message-ID: <0a5d631a-037e-5158-82dd-e53d478befea@pengutronix.de> (raw)
In-Reply-To: <67d283f3-d0db-5fc0-79e9-e7531d591aab@pengutronix.de>
Hi Rob, hi Krzysztof,
[snip]
> gentle ping - any opinions on this? Shall I just send a V2 along the
lines of the phy-stm32-usbphy.c?
This would be something like (example for the trim-hs-current, taken
from pyh-stm32-usbphyc):
st,trim-hs-current:
description: |
Controls HS driver current trimming for choke compensation
- <0> = 18.87 mA target current / nominal + 0%
- <1> = 19.165 mA target current / nominal + 1.56%
- <2> = 19.46 mA target current / nominal + 3.12%
- <3> = 19.755 mA target current / nominal + 4.68%
- <4> = 20.05 mA target current / nominal + 6.24%
- <5> = 20.345 mA target current / nominal + 7.8%
- <6> = 20.64 mA target current / nominal + 9.36%
- <7> = 20.935 mA target current / nominal + 10.92%
- <8> = 21.23 mA target current / nominal + 12.48%
- <9> = 21.525 mA target current / nominal + 14.04%
- <10> = 21.82 mA target current / nominal + 15.6%
- <11> = 22.115 mA target current / nominal + 17.16%
- <12> = 22.458 mA target current / nominal + 19.01%
- <13> = 22.755 mA target current / nominal + 20.58%
- <14> = 23.052 mA target current / nominal + 22.16%
- <15> = 23.348 mA target current / nominal + 23.73%
$ref: /schemas/types.yaml#/definitions/uint32
minimum: 0
maximum: 15
default: 0
If you think something along these lines is acceptable, I would like to
prepare and send a V2.
Best regards
Johannes
[snip]
next prev parent reply other threads:[~2023-05-04 7:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 11:21 [PATCH 0/2] Add phy tuning support for imx8mq-usb Johannes Zink
2023-04-05 11:21 ` [PATCH 1/2] dt-bindings: phy: imx8mq-usb: add phy tuning properties Johannes Zink
2023-04-05 11:51 ` Krzysztof Kozlowski
2023-04-05 12:14 ` Johannes Zink
2023-04-07 9:03 ` Krzysztof Kozlowski
2023-04-11 14:22 ` Johannes Zink
2023-04-11 14:59 ` Jun Li
2023-04-11 15:22 ` Johannes Zink
2023-04-26 10:23 ` Jun Li
2023-04-12 13:39 ` Rob Herring
2023-04-12 14:32 ` Johannes Zink
2023-04-18 9:42 ` Johannes Zink
2023-05-04 7:32 ` Johannes Zink [this message]
2023-05-04 8:13 ` Krzysztof Kozlowski
2023-04-05 11:21 ` [PATCH 2/2] phy: fsl-imx8mp-usb: add support for phy tuning Johannes Zink
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a5d631a-037e-5158-82dd-e53d478befea@pengutronix.de \
--to=j.zink@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=haibo.chen@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=patchwork-jzi@pengutronix.de \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).