From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Xiwen <forbidden405@outlook.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH net-next v6 11/11] net: hisi_femac: add support for hisi_femac core on Hi3798MV200
Date: Thu, 29 Feb 2024 11:17:23 +0100 [thread overview]
Message-ID: <0a9a0a85-d345-41e8-a821-d537f1ce827e@linaro.org> (raw)
In-Reply-To: <KL1PR06MB69645ED79CED22F5BB1DE45C965F2@KL1PR06MB6964.apcprd06.prod.outlook.com>
On 29/02/2024 09:14, Yang Xiwen wrote:
> On 2/29/2024 4:10 PM, Krzysztof Kozlowski wrote:
>> On 28/02/2024 10:02, Yang Xiwen via B4 Relay wrote:
>>> From: Yang Xiwen <forbidden405@outlook.com>
>>>
>>> Register the sub MDIO bus if it is found. Also implement the internal
>>> PHY reset procedure as needed.
>>>
>>
>>
>>>
>>> @@ -947,6 +992,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
>>> static const struct of_device_id hisi_femac_match[] = {
>>> {.compatible = "hisilicon,hisi-femac",},
>>> {.compatible = "hisilicon,hi3516cv300-femac",},
>>> + {.compatible = "hisilicon,hi3798mv200-femac",},
>>
>> No, it does not make any sense. Why do you keep growing this table?
>
> So do I only have to keep the generic compatible "hisilicon,hisi-femac"
> or the two SoC compatibles?
You only need to keep here fallback compatible.
Best regards,
Krzysztof
prev parent reply other threads:[~2024-02-29 10:17 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 9:02 [PATCH net-next v6 00/11] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-02-28 9:02 ` [PATCH net-next v6 01/11] dt-bindings: net: hisilicon-femac-mdio: convert to YAML Yang Xiwen via B4 Relay
2024-02-28 9:02 ` [PATCH net-next v6 02/11] dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks Yang Xiwen via B4 Relay
2024-02-28 9:02 ` [PATCH net-next v6 03/11] net: mdio: hisi-femac: remove clock Yang Xiwen via B4 Relay
2024-02-28 9:02 ` [PATCH net-next v6 04/11] dt-bindings: net: convert hisi-femac.txt to YAML Yang Xiwen via B4 Relay
2024-02-29 8:05 ` Krzysztof Kozlowski
2024-02-28 9:02 ` [PATCH net-next v6 05/11] dt-bindings: net: hisi-femac: remove core specific versioning Yang Xiwen via B4 Relay
2024-02-29 8:05 ` Krzysztof Kozlowski
2024-02-28 9:02 ` [PATCH net-next v6 06/11] dt-bindings: net: hisi-femac: add missing clocks Yang Xiwen via B4 Relay
2024-02-29 8:07 ` Krzysztof Kozlowski
2024-02-28 9:02 ` [PATCH net-next v6 07/11] dt-bindings: net: hisi-femac: replace deprecated phy-mode with recommended phy-connection-type Yang Xiwen via B4 Relay
2024-02-29 8:08 ` Krzysztof Kozlowski
2024-02-29 8:12 ` Yang Xiwen
2024-02-29 8:21 ` Krzysztof Kozlowski
2024-02-29 17:18 ` Andrew Lunn
2024-02-28 9:02 ` [PATCH net-next v6 08/11] dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode Yang Xiwen via B4 Relay
2024-02-29 8:09 ` Krzysztof Kozlowski
2024-02-28 9:02 ` [PATCH net-next v6 09/11] dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core Yang Xiwen via B4 Relay
2024-02-28 9:02 ` [PATCH net-next v6 10/11] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-02-29 8:07 ` Krzysztof Kozlowski
2024-03-05 7:48 ` Yang Xiwen
2024-02-28 9:02 ` [PATCH net-next v6 11/11] net: hisi_femac: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-28 9:05 ` Yang Xiwen
2024-02-29 8:10 ` Krzysztof Kozlowski
2024-02-29 8:14 ` Yang Xiwen
2024-02-29 10:17 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0a9a0a85-d345-41e8-a821-d537f1ce827e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).