From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65B0CC0015E for ; Wed, 26 Jul 2023 17:21:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229871AbjGZRVY (ORCPT ); Wed, 26 Jul 2023 13:21:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232380AbjGZRVV (ORCPT ); Wed, 26 Jul 2023 13:21:21 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E3DA2722 for ; Wed, 26 Jul 2023 10:21:18 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-522382c4840so6394a12.2 for ; Wed, 26 Jul 2023 10:21:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1690392077; x=1690996877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=too89VOKg4aVRVsOKXI6D9LDbHqxYzZFNKPkb45L/xw=; b=K8dE9tk+ewfahp9/J7/sYh67jaGw270PVYU6mD45mc3tAPQ4nXe3tJwVEpotz0Kdey WkIQO70OQ6AoJkqSRt70bhfnnVzm8av/LwoRxx+2h/oz7KCJmiA27v3N17IWYzA91HNG vIIL6vghTK5w8k9cy4zsDYrClv9h8f6pNfLde+fMds1zvbb5aZ7ORnwpTaKuDuFaCwQv RXxZHm6ChCUpHhl7O7GMUas/xHrAu9boAJzgpqQpeaSBjPz+Ba2RA3bj/+IDPbVfGKQZ 13WP+Y2sYbrIFVXDudT+SrOiXq+/PxgUcUrQvS5xBhNRdc0dQrNx+JEjCVeCTMZyGj7Q gVnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690392077; x=1690996877; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=too89VOKg4aVRVsOKXI6D9LDbHqxYzZFNKPkb45L/xw=; b=EAzKURTaPzuyh01CGkkPeUQlgQ52azg3ZzO80cxhrNTFd454vqb1DViz7MwP5YYKqi TRkc1Y3BlbTklp/daF1lWyFINzWRvr1dFxU947AuIiI8jIIlW3EMD4rUP2hbgFCORVRM 2Oufu6/ygyqjDJ8/9sAJlkjWCBJcMitIsPtwGllLifLlWAFJQqp9q5XMTUNe4Y6084Tz VVeXzSrKFWA7dG6rkGdTUvf/GjuDeEoXRNWkuWqtdW3eqXbtjw4ai2gc2YsZ8VPfvMJd ao+CikZR3rVsbcpPGfqyS3U5BM5WdK1AVJfN+9eQJnIVttha02g57TuX1BgtkKDVr7Kh IAtg== X-Gm-Message-State: ABy/qLYtcZ/GwEuJaWdJTbFmq1V6/Dx4pkYlGLJpk04MeIiqkuaLz7B0 AZXbfETnHKNpHcxuVoWFW5yRvw== X-Google-Smtp-Source: APBJJlEyoGURsUYBAQaNMwsyfDXwqKgX55lxzPCYh6e9DV5uQcwnRiL+KCwu7sXNVeMpK8z6KNcc1A== X-Received: by 2002:aa7:d71a:0:b0:522:36e8:bc88 with SMTP id t26-20020aa7d71a000000b0052236e8bc88mr1939347edq.12.1690392076903; Wed, 26 Jul 2023 10:21:16 -0700 (PDT) Received: from [192.168.1.20] ([178.197.223.104]) by smtp.gmail.com with ESMTPSA id k11-20020aa7d8cb000000b005222c6fb512sm4306131eds.1.2023.07.26.10.21.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 26 Jul 2023 10:21:16 -0700 (PDT) Message-ID: <0aa471ce-da83-172d-d870-1ec7a562baf7@linaro.org> Date: Wed, 26 Jul 2023 19:21:14 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH v7 1/5] dt-bindings: media: platform: visconti: Add Toshiba Visconti Video Input Interface Content-Language: en-US To: yuji2.ishikawa@toshiba.co.jp, hverkuil@xs4all.nl, sakari.ailus@iki.fi, laurent.pinchart@ideasonboard.com, mchehab@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, nobuhiro1.iwamatsu@toshiba.co.jp, broonie@kernel.org Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20230714015059.18775-1-yuji2.ishikawa@toshiba.co.jp> <20230714015059.18775-2-yuji2.ishikawa@toshiba.co.jp> <7aa255e8-1cf1-03c6-02c8-de7c737a5683@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/07/2023 08:08, yuji2.ishikawa@toshiba.co.jp wrote: >> unevaluatedProperties: false > > In the previous discussion with Laurent, I believe additionalProperties was preferred in terms of handling properties not explicitly mentioned. > > https://lore.kernel.org/all/Y82NtJCtr+CZgS9k@pendragon.ideasonboard.com/ OK. > > Do you have concern about defaulting properties in video-interface.yaml to forbidden? > If defaulting to optional (like most of other bindings) is better, I'll use unevaluatedProperties. > ... > there's no need to specify clock-lane with device tree. > > I'll drop "clock-lanes". > >>> + >>> + bus-type: true >>> + clock-noncontinuous: true >>> + link-frequencies: true >>> + remote-endpoint: true >> >> Drop all of these "xxx: true", should not be needed after converting to >> unevaluatedProperties: false >> > > I'll drop "xxx: true" if unevaluatedProperties is chosen instead of additionalProperties. Since we keep unevaluated, this should stay. Best regards, Krzysztof