From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
agross@kernel.org
Cc: andersson@kernel.org, konrad.dybcio@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jassisinghbrar@gmail.com, srinivas.kandagatla@linaro.org,
jic23@kernel.org, lars@metafoo.de, keescook@chromium.org,
tony.luck@intel.com, gpiccoli@igalia.com, evgreen@chromium.org,
gregkh@linuxfoundation.org, a39.skl@gmail.com,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
linux-hardening@vger.kernel.org, marijn.suijten@somainline.org,
kernel@collabora.com, luca@z3ntu.xyz
Subject: Re: [PATCH v2 05/11] dt-bindings: mailbox: qcom: Allow syscon on qcom,msm8976-apcs-kpss-global
Date: Wed, 16 Nov 2022 10:44:54 +0100 [thread overview]
Message-ID: <0ac1f247-be87-0f92-9ef0-c653bcdb6c1f@linaro.org> (raw)
In-Reply-To: <f60ccd79-9c82-0844-2c5f-21ec29c14dcf@collabora.com>
On 16/11/2022 10:00, AngeloGioacchino Del Regno wrote:
> Il 16/11/22 09:57, Krzysztof Kozlowski ha scritto:
>> On 16/11/2022 09:52, AngeloGioacchino Del Regno wrote:
>>> Il 15/11/22 17:44, Krzysztof Kozlowski ha scritto:
>>>> On 11/11/2022 13:01, AngeloGioacchino Del Regno wrote:
>>>>> MSM8976 supports SMSM, which needs this node to also be a syscon:
>>>>> move the compatible to allow that.
>>>>>
>>>>> Fixes: bcc8d70f912d ("dt-bindings: mailbox: Add compatible for the MSM8976")
>>>>
>>>> I am not sure if this is still a bug. Maybe just a missing feature?
>>>>
>>>
>>> This changes how you use this mailbox across the entire devicetree (as other
>>> nodes will not use mboxes = xxxx, but qcom,ipc = xxxx as syscon), so I think
>>> that this is not a missing feature?
>>
>> Whether it is a bug depends on existing usage. If none of msm8976 DTSes
>> use it the other way, then it is just incomplete or missing support. Not
>> a bug. If existing DTSes use it as syscon, thus you need to add syscon
>> to compatible, then it would be a bugfix.
>>
>
> It's not a bugfix then. The Fixes tag shall be dropped.
>
> Same question like the other commit, should I send a v3 or can it be dropped while
> applying?
Maybe better send a v3.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-16 9:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-11 12:01 [PATCH v2 00/11] MSM8956/76 and Sony Xperia X / X Compact support AngeloGioacchino Del Regno
2022-11-11 12:01 ` [PATCH v2 01/11] dt-bindings: iio: qcom-spmi-vadc: Add definitions for USB DP/DM VADCs AngeloGioacchino Del Regno
2022-11-11 12:01 ` [PATCH v2 02/11] dt-bindings: nvmem: Fix qcom,qfprom compatibles enum ordering AngeloGioacchino Del Regno
2022-11-15 16:42 ` Krzysztof Kozlowski
2022-11-16 8:50 ` AngeloGioacchino Del Regno
2023-01-03 11:58 ` Srinivas Kandagatla
2023-01-03 11:59 ` AngeloGioacchino Del Regno
2022-11-11 12:01 ` [PATCH v2 03/11] dt-bindings: nvmem: Add compatible for MSM8976 AngeloGioacchino Del Regno
2022-11-15 16:42 ` Krzysztof Kozlowski
2023-01-03 11:57 ` Srinivas Kandagatla
2022-11-11 12:01 ` [PATCH v2 04/11] dt-bindings: sram: qcom,imem: Document MSM8976 AngeloGioacchino Del Regno
2022-11-15 16:42 ` Krzysztof Kozlowski
2025-01-06 20:59 ` Rob Herring (Arm)
2022-11-11 12:01 ` [PATCH v2 05/11] dt-bindings: mailbox: qcom: Allow syscon on qcom,msm8976-apcs-kpss-global AngeloGioacchino Del Regno
2022-11-15 16:44 ` Krzysztof Kozlowski
2022-11-16 8:52 ` AngeloGioacchino Del Regno
2022-11-16 8:57 ` Krzysztof Kozlowski
2022-11-16 9:00 ` AngeloGioacchino Del Regno
2022-11-16 9:44 ` Krzysztof Kozlowski [this message]
2022-11-11 12:01 ` [PATCH v2 06/11] dt-bindings: arm: qcom,ids: Add SoC IDs for MSM8956 and MSM8976 AngeloGioacchino Del Regno
2022-11-14 9:39 ` Konrad Dybcio
2022-11-15 16:43 ` Krzysztof Kozlowski
2022-11-11 12:01 ` [PATCH v2 07/11] soc: qcom: socinfo: Add MSM8956/76 SoC IDs to the soc_id table AngeloGioacchino Del Regno
2022-11-14 9:39 ` Konrad Dybcio
2022-11-15 16:43 ` Krzysztof Kozlowski
2022-11-11 12:01 ` [PATCH v2 08/11] dt-bindings: arm: qcom: Document msm8956 and msm8976 SoC and devices AngeloGioacchino Del Regno
2022-11-11 12:01 ` [PATCH v2 09/11] arm64: dts: qcom: Add configuration for PM8950 peripheral AngeloGioacchino Del Regno
2022-11-11 12:01 ` [PATCH v2 10/11] arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs AngeloGioacchino Del Regno
2022-11-15 16:46 ` Krzysztof Kozlowski
2022-11-11 12:01 ` [PATCH v2 11/11] arm64: dts: qcom: Add support for SONY Xperia X/X Compact AngeloGioacchino Del Regno
2022-11-15 16:46 ` Krzysztof Kozlowski
2022-12-06 18:18 ` (subset) [PATCH v2 00/11] MSM8956/76 and Sony Xperia X / X Compact support Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ac1f247-be87-0f92-9ef0-c653bcdb6c1f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=a39.skl@gmail.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=angelogioacchino.delregno@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=evgreen@chromium.org \
--cc=gpiccoli@igalia.com \
--cc=gregkh@linuxfoundation.org \
--cc=jassisinghbrar@gmail.com \
--cc=jic23@kernel.org \
--cc=keescook@chromium.org \
--cc=kernel@collabora.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).