From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
lgirdwood@gmail.com, broonie@kernel.org,
dmitry.baryshkov@linaro.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB 'vdda-pll-supply'
Date: Tue, 28 Nov 2023 15:01:12 +0100 [thread overview]
Message-ID: <0acdc122-b7fa-4bb4-b838-6420cd43d0e0@linaro.org> (raw)
In-Reply-To: <ZWW9oF24YUGfev+2@hu-varada-blr.qualcomm.com>
On 28/11/2023 11:14, Varadarajan Narayanan wrote:
> On Tue, Nov 28, 2023 at 09:51:50AM +0100, Krzysztof Kozlowski wrote:
>> On 28/11/2023 09:46, Varadarajan Narayanan wrote:
>>> From: Varadarajan Narayanan <quic_varada@quicinc.com>
>>>
>>> The earlier patch ec4f047679d5, incorrectly used 'l2'
>>> as the vdda-pll-supply. However, 'l5' is the correct
>>> ldo that supplies power to the USB PHY.
>>>
>>> Fixes: ec4f047679d5 ("arm64: dts: qcom: ipq9574: Enable USB")
>>
>> Doesn't this depend on the driver change?
>
> Yes, will mention in the cover letter.
This commit should have it in its changelog ---
>
>> It affects both existing
>> kernel and backports which you claim here should happen.
>
> Ok. Will include stable@vger.kernel.org in the next revision.
I wasn't speaking about Cc. You indicated this should be backported.
Then please backport it, without previous commit, and check the result.
Is stable tree working correctly or not?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-11-28 14:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-28 8:46 [PATCH v1 0/2] ipq9574: Fix USB 'vdda-pll-supply' Varadarajan Narayanan
2023-11-28 8:46 ` [PATCH v1 1/2] regulator: qcom_smd: Add LDO5 MP5496 regulator Varadarajan Narayanan
2023-11-28 8:52 ` Krzysztof Kozlowski
2023-11-28 8:46 ` [PATCH v1 2/2] arm64: dts: qcom: ipq9574: Fix USB 'vdda-pll-supply' Varadarajan Narayanan
2023-11-28 8:51 ` Krzysztof Kozlowski
2023-11-28 10:14 ` Varadarajan Narayanan
2023-11-28 14:01 ` Krzysztof Kozlowski [this message]
2023-12-06 11:38 ` Varadarajan Narayanan
2023-12-06 12:31 ` Krzysztof Kozlowski
2023-12-06 12:33 ` Krzysztof Kozlowski
2023-12-07 4:12 ` Varadarajan Narayanan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0acdc122-b7fa-4bb4-b838-6420cd43d0e0@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_varada@quicinc.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).