Re: [PATCH v6 2/3] media: platform: Add Renesas Input Video Control block driver

[Hans Verkuil <hverkuil+cisco@kernel.org>]

Hi Dan,

On 11/11/2025 17:34, Daniel Scally wrote:
> Add a driver for the Input Video Control block in an RZ/V2H(P) SoC
> which feeds data into the Arm Mali-C55 ISP.
> 
> [ivc: Remove check on buffers list in start_streaming]
> [ivc: put_autosuspend() implies mark_last_busy()]
> [media: rzv2h-ivc: Do not delay frame completion]
> Signed-off-by: Jacopo Mondi <jacopo.mondi+renesas@ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
> Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
> ---
> Changes in latest version:
> 
> 	- Requested irq at very end of runtime resume callback and
> 	  not the beginning.
> 	- Switch to devm_mutex_init()
> 	- Disable runtime pm in probe() error path
> 
> Changes in v7:
> 
> 	- Returned buffers to userspace as soon as the first
> 	  interrupt is received instead of waiting until the
> 	  second
> 	- Fixes to the pm runtime invocations
> 	- Some minor formatting changes
> 
> Changes in v6:
> 
> 	- Minor formatting changes
> 	- Dropped CONFIG_ prefix from Kconfig symbols
> 	- Collected tags
> 	- Replaced "RZ/V2H" with "RZ/V2H(P)"
> 	- Reformatted probe function
> 	- Removed leftover reference to media job scheduler
> 	- Drop the .pipeline_started() and .pipeline_stopped()
> 	  media entity operations to remove a dependency for the
> 	  set.
> 
> Changes in v5:
> 
> 	- Fixed .enum_frame_sizes() to properly check that the
> 	  given mbus_code matches the source pads format.
> 	- Tidy up extra space in Kconfig
> 	- Revise Kconfig option message
> 	- Don't mark functions inline
> 	- Fixup misleading comment
> 	- select CONFIG_PM
> 	- Use the new pm_sleep_ptr() functionality
> 	- Minor formatting
> 
> Changes in v4:
> 
> 	- Update the compatible to renesas,r9a09g057-ivc
> 	- Dropped the media jobs / scheduler functionality, and re
> 	  worked the driver to have its own workqueue pushing frames
> 	- Fix .enum_mbus_code() to return 20-bit output for source
> 	  pad.
> 	- Fix some alignment issues
> 	- Make the forwarding of sink to source pad format a more
> 	  explicit operation.
> 	- Rename rzv2h_initialise_video_device_and_queue()
> 	- Reversed order of v4l2_subdev_init_finalize() and
> 	  v4l2_async_register_subdev() to make sure everything is
> 	  finished initialising before registering the subdev.
> 	- Change function to MEDIA_ENT_F_PROC_VIDEO_PIXEL_FORMATTER
> 	- Use a parametised macro for min vblank
> 	- Minor formatting
> 	- Use the DEFAULT macros for quantization / ycbcr_enc values
> 	- Switch to using the mplane API
> 	- Dropped select RESET_CONTROLLER
> 	- Used the new helpers for starting a media pipeline
> 	- Switch from threaded irq to normal with driver workqueue
> 	  and revised startup routine
> 
> Changes in v3:
> 
> 	- Account for the renamed CRU pixel formats
> 
> Changes in v2:
> 
> 	- Added selects and depends statements to Kconfig entry
> 	- Fixed copyright year
> 	- Stopped including in .c files headers already included in .h
> 	- Fixed uninitialized variable in iterator
> 	- Only check vvalid member in interrupt function and wait
> 	  unconditionally elsewhere
> 	- __maybe_unused for the PM ops
> 	- Initialise the subdevice after setting up PM
> 	- Fixed the remove function for the driver to actually do
> 	  something.
> 	- Some minor formatting changes
> 	- Fixed the quantization member for the format
> 	- Changes accounting for the v2 of the media jobs framework
> 	- Change min_queued_buffers to 0
> ---
>  drivers/media/platform/renesas/Kconfig             |   1 +
>  drivers/media/platform/renesas/Makefile            |   1 +
>  drivers/media/platform/renesas/rzv2h-ivc/Kconfig   |  18 +
>  drivers/media/platform/renesas/rzv2h-ivc/Makefile  |   5 +
>  .../platform/renesas/rzv2h-ivc/rzv2h-ivc-dev.c     | 250 ++++++++++
>  .../platform/renesas/rzv2h-ivc/rzv2h-ivc-subdev.c  | 375 +++++++++++++++
>  .../platform/renesas/rzv2h-ivc/rzv2h-ivc-video.c   | 533 +++++++++++++++++++++
>  .../media/platform/renesas/rzv2h-ivc/rzv2h-ivc.h   | 130 +++++
>  8 files changed, 1313 insertions(+)
> 
> diff --git a/drivers/media/platform/renesas/Kconfig b/drivers/media/platform/renesas/Kconfig
> index 27a54fa7908384f2e8200f0f7283a82b0ae8435c..bd8247c0b8aa734d2b412438e694f3908d910b25 100644
> --- a/drivers/media/platform/renesas/Kconfig
> +++ b/drivers/media/platform/renesas/Kconfig
> @@ -42,6 +42,7 @@ config VIDEO_SH_VOU
>  source "drivers/media/platform/renesas/rcar-isp/Kconfig"
>  source "drivers/media/platform/renesas/rcar-vin/Kconfig"
>  source "drivers/media/platform/renesas/rzg2l-cru/Kconfig"
> +source "drivers/media/platform/renesas/rzv2h-ivc/Kconfig"
>  
>  # Mem2mem drivers
>  
> diff --git a/drivers/media/platform/renesas/Makefile b/drivers/media/platform/renesas/Makefile
> index 1127259c09d6a51b70803e76c495918e06777f67..b6b4abf01db246aaf8269b8027efee9b0b32083a 100644
> --- a/drivers/media/platform/renesas/Makefile
> +++ b/drivers/media/platform/renesas/Makefile
> @@ -6,6 +6,7 @@
>  obj-y += rcar-isp/
>  obj-y += rcar-vin/
>  obj-y += rzg2l-cru/
> +obj-y += rzv2h-ivc/
>  obj-y += vsp1/
>  
>  obj-$(CONFIG_VIDEO_RCAR_CSI2) += rcar-csi2.o
> diff --git a/drivers/media/platform/renesas/rzv2h-ivc/Kconfig b/drivers/media/platform/renesas/rzv2h-ivc/Kconfig
> new file mode 100644
> index 0000000000000000000000000000000000000000..b30702489d380902bfdcff57f0d70498c85e1d24
> --- /dev/null
> +++ b/drivers/media/platform/renesas/rzv2h-ivc/Kconfig
> @@ -0,0 +1,18 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config VIDEO_RZV2H_IVC
> +	tristate "Renesas RZ/V2H(P) Input Video Control block driver"
> +	depends on V4L_PLATFORM_DRIVERS
> +	depends on VIDEO_DEV
> +	depends on ARCH_RENESAS || COMPILE_TEST
> +	depends on OF
> +	select PM

Is it OK if I change this to "depends on PM"? It's what we use in the media subsystem.

This also makes it easier for our CI since one of the tests is to disable PM and checks
that everything still compiles.

Regards,

	Hans

> +	select VIDEOBUF2_DMA_CONTIG
> +	select MEDIA_CONTROLLER
> +	select VIDEO_V4L2_SUBDEV_API
> +	help
> +          Support for the Renesas RZ/V2H(P) Input Video Control Block
> +          (IVC).
> +
> +          To compile this driver as a module, choose M here: the
> +          module will be called rzv2h-ivc.

Regards,

	Hans