From: Roger Quadros <rogerq@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: <vigneshr@ti.com>, <linux-kernel@vger.kernel.org>,
<robh+dt@kernel.org>, <kishon@ti.com>, <nsekhar@ti.com>,
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v3 1/3] dt-binding: phy: convert ti,omap-usb2 to YAML
Date: Thu, 16 Jul 2020 10:49:24 +0300 [thread overview]
Message-ID: <0ae2e424-f5d4-83d0-90ea-56acde3d4c9b@ti.com> (raw)
In-Reply-To: <7899660d-936e-6d88-877a-f75d76f34c40@ti.com>
On 03/07/2020 11:58, Roger Quadros wrote:
> Hi Rob,
>
> On 02/07/2020 23:47, Rob Herring wrote:
>> On Tue, 30 Jun 2020 12:27:27 +0300, Roger Quadros wrote:
>>> Move ti,omap-usb2 to its own YAML schema.
>>>
>>> Signed-off-by: Roger Quadros <rogerq@ti.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../devicetree/bindings/phy/ti,omap-usb2.yaml | 69 +++++++++++++++++++
>>> .../devicetree/bindings/phy/ti-phy.txt | 37 ----------
>>> 2 files changed, 69 insertions(+), 37 deletions(-)
>>> create mode 100644 Documentation/devicetree/bindings/phy/ti,omap-usb2.yaml
>>>
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/phy/ti,omap-usb2.example.dt.yaml: example-0: phy@4100000:reg:0: [0, 68157440, 0, 84] is too long
>>
>
> In my local build in the dt example I see
>
> phy@4100000:
> compatible: ["ti,am654-usb2", "ti,omap-usb2"]
> reg: [[0x0, 0x4100000, 0x0, 0x54]]
>
> And I don't see any errors. I've updated my dt-schema as well.
I'm able to see the issue now. Will fix it and send v4.
>
>>
>> See https://patchwork.ozlabs.org/patch/1319665
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure dt-schema is up to date:
>>
>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>>
>> Please check and re-submit.
>>
>
cheers,
-roger
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-07-16 7:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 9:27 [PATCH v3 0/3] phy: omap-usb2: add quirk to disable charger detection Roger Quadros
2020-06-30 9:27 ` [PATCH v3 1/3] dt-binding: phy: convert ti,omap-usb2 to YAML Roger Quadros
2020-07-02 20:47 ` Rob Herring
2020-07-03 8:58 ` Roger Quadros
2020-07-16 7:49 ` Roger Quadros [this message]
2020-06-30 9:27 ` [PATCH v3 2/3] dt-binding: phy: ti,omap-usb2: Add quirk to disable charger detection Roger Quadros
2020-06-30 9:27 ` [PATCH v3 3/3] phy: omap-usb2-phy: disable PHY charger detect Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0ae2e424-f5d4-83d0-90ea-56acde3d4c9b@ti.com \
--to=rogerq@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nsekhar@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox