From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3131C2D0B1 for ; Fri, 7 Feb 2020 06:41:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 807992082E for ; Fri, 7 Feb 2020 06:41:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="OBd7LKqC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726136AbgBGGlL (ORCPT ); Fri, 7 Feb 2020 01:41:11 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:61204 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726130AbgBGGlK (ORCPT ); Fri, 7 Feb 2020 01:41:10 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1581057670; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=YcmWYUVZoZZ5xp+hXjD/DbuPvpwvOawaFCYTP2ks1V4=; b=OBd7LKqCUkoPudD7toUUbEXP+sieTkESdIPQ6xBViRXE0Q1G2Dp8XBNvceogRpRDQyZN7kx2 HuI3bFGD7x3sGcl6VKrzoXURUMpg6bWJ9smRDSZNNNvlGz77lHckLsQIxaYzHdqGr1KxAhjR k6s9ErI9mTiO+z+qyoxIEr6tJFM= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e3d0681.7f79dcb39dc0-smtp-out-n02; Fri, 07 Feb 2020 06:41:05 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 74596C43383; Fri, 7 Feb 2020 06:41:04 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sibis) by smtp.codeaurora.org (Postfix) with ESMTPSA id E2126C433CB; Fri, 7 Feb 2020 06:41:03 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Feb 2020 12:11:03 +0530 From: Sibi Sankar To: Rakesh Pillai Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-msm-owner@vger.kernel.org Subject: Re: [PATCH v6] arm64: dts: qcom: sc7180: Add WCN3990 WLAN module device node In-Reply-To: <1580822300-4491-1-git-send-email-pillair@codeaurora.org> References: <1580822300-4491-1-git-send-email-pillair@codeaurora.org> Message-ID: <0ae6edd12623c35600d598a219322f44@codeaurora.org> X-Sender: sibis@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hey Rakesh, On 2020-02-04 18:48, Rakesh Pillai wrote: > Add device node for the ath10k SNOC platform driver probe > and add resources required for WCN3990 on sc7180 soc. > > Signed-off-by: Rakesh Pillai > --- > arch/arm64/boot/dts/qcom/sc7180-idp.dts | 5 +++++ > arch/arm64/boot/dts/qcom/sc7180.dtsi | 27 > +++++++++++++++++++++++++++ > 2 files changed, 32 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50a..167f68ac 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -287,6 +287,11 @@ > vdda-pll-supply = <&vreg_l4a_0p8>; > }; > > +&wifi { > + status = "okay"; I can see that wlan needs to add the SIDs 0xc2, 0xc3 as well. Without that I expect wlan will not come up. > + qcom,msa-fixed-perm; are you sure this is required when used in conjunction with coreboot? > +}; > + > /* PINCTRL - additions to nodes defined in sc7180.dtsi */ > > &qspi_clk { > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi > b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 8011c5f..e3e8610 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -75,6 +75,11 @@ > reg = <0x0 0x80900000 0x0 0x200000>; > no-map; > }; > + > + wlan_fw_mem: memory@93900000 { > + reg = <0 0x93900000 0 0x200000>; > + no-map; > + }; > }; > > cpus { > @@ -1490,6 +1495,28 @@ > > #freq-domain-cells = <1>; > }; > + > + wifi: wifi@18800000 { > + compatible = "qcom,wcn3990-wifi"; > + reg = <0 0x18800000 0 0x800000>; > + reg-names = "membase"; > + iommus = <&apps_smmu 0xc0 0x1>; > + interrupts = > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + memory-region = <&wlan_fw_mem>; > + status = "disabled"; > + }; > }; > > thermal-zones { -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.