From: Krzysztof Kozlowski <krzk@kernel.org>
To: Vishwaroop A <va@nvidia.com>,
broonie@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, thierry.reding@gmail.com,
jonathanh@nvidia.com, skomatineni@nvidia.com,
ldewangan@nvidia.com, kyarlagadda@nvidia.com,
smangipudi@nvidia.com, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND 1/3] spi: tegra210-quad: Add iommus property to DT bindings
Date: Tue, 6 May 2025 17:54:43 +0200 [thread overview]
Message-ID: <0aedf5fb-557b-4c8c-a336-182498e2c3ea@kernel.org> (raw)
In-Reply-To: <20250506152350.3370291-1-va@nvidia.com>
On 06/05/2025 17:23, Vishwaroop A wrote:
> The Tegra210 Quad SPI controller uses internal DMA engines to
> efficiently transfer data between system memory and the SPI bus.
> On platforms with an IOMMU, such as Tegra234, DMA transactions
> must be properly mapped and protected to ensure system security
> and functional correctness.
Does this mean this is not valid for other platforms? Then in
allOf:if:then: disallow it (iommus: false) for hardware this is invalid.
>
> This patch adds the iommus property to the device tree binding.
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
> This property is required to associate the SPI controller with
> the system IOMMU, specifying the correct stream ID for address
> translation and access protection.
>
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
Missing: dt-bindings
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-06 15:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 15:23 [PATCH RESEND 1/3] spi: tegra210-quad: Add iommus property to DT bindings Vishwaroop A
2025-05-06 15:23 ` [PATCH RESEND 2/3] arm64: tegra: Configure QSPI clocks and add DMA Vishwaroop A
2025-05-08 20:27 ` Thierry Reding
2025-05-06 15:23 ` [PATCH RESEND 3/3] spi: tegra210-quad: Add support for internal DMA Vishwaroop A
2025-05-06 15:54 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0aedf5fb-557b-4c8c-a336-182498e2c3ea@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=kyarlagadda@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=skomatineni@nvidia.com \
--cc=smangipudi@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=va@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).