From: "Rafał Miłecki" <rafal@milecki.pl>
To: William Zhang <william.zhang@broadcom.com>
Cc: Rob Herring <robh@kernel.org>,
Linux ARM List <linux-arm-kernel@lists.infradead.org>,
joel.peshkin@broadcom.com, f.fainelli@gmail.com,
Broadcom Kernel List <bcm-kernel-feedback-list@broadcom.com>,
dan.beygelman@broadcom.com, anand.gore@broadcom.com,
kursad.oney@broadcom.com, krzysztof.kozlowski@linaro.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/9] arm64: dts: bcmbca: update BCM4908 board dts files
Date: Wed, 27 Jul 2022 12:39:33 +0200 [thread overview]
Message-ID: <0af44be8f5802e66011b4642de4632d4@milecki.pl> (raw)
In-Reply-To: <1004391f-fb6c-5f84-de28-8f76dc3471e5@broadcom.com>
On 2022-07-26 03:09, William Zhang wrote:
> On 07/25/2022 04:32 PM, Rob Herring wrote:
>> On Sun, Jul 24, 2022 at 10:53:56PM -0700, William Zhang wrote:
>>> Append "brcm,bcmbca" to compatible strings based on the new bcmbca
>>> binding rule for BCM4908 family based boards. This will break drivers
>>> that use the old compatible string for binding. Fortunately there is
>>> no
>>> such usage in linux and u-boot.
>>
>> How does adding an additional compatible break things?
>> In theory when some crazy code tries to match the entire string. But
>> not
> in linux, u-boot code and hopefully not in other bootloader and Os
> does that. But this does change an existing compatible string so
> Krzysztof suggested to add comment about the breakage in the commit
> message. I can remove this and send v3 if you guys think it is
> necessary.
Krzysztof commented on ABI breakage [1] when you tried removing
"brcm,bcm4908" from the "compatible" list in your patch
[RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file [2]
In this version of your patch you don't remove "brcm,bcm4908" anymore so
this change doesn't break anything. Adding a new "compatible" string
doesn't break things. You can remove that info from the commit message.
[1]
https://lore.kernel.org/linux-arm-kernel/d93e55fa-3359-2609-aad5-c80eca78f380@linaro.org/
[2]
https://lore.kernel.org/linux-arm-kernel/20220712021144.7068-4-william.zhang@broadcom.com/
next prev parent reply other threads:[~2022-07-27 10:57 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-25 5:53 [PATCH v2 0/9] arm64: bcmbca: Move BCM4908 SoC support under ARCH_BCMBCA William Zhang
2022-07-25 5:53 ` [PATCH v2 1/9] dt-bindings: arm64: bcmbca: Merge BCM4908 into BCMBCA William Zhang
2022-07-25 23:30 ` Rob Herring
2022-07-25 5:53 ` [PATCH v2 2/9] dt-bindings: arm64: bcmbca: Update BCM4908 description William Zhang
2022-07-25 23:33 ` Rob Herring
2022-07-25 5:53 ` [PATCH v2 3/9] arm64: dts: bcmbca: update BCM4908 board dts files William Zhang
2022-07-25 23:32 ` Rob Herring
2022-07-26 1:09 ` William Zhang
2022-07-27 10:39 ` Rafał Miłecki [this message]
2022-07-27 12:12 ` Krzysztof Kozlowski
2022-07-25 5:53 ` [PATCH v2 4/9] arm64: dts: Move BCM4908 dts to bcmbca folder William Zhang
2022-07-25 5:53 ` [PATCH v2 5/9] arm64: dts: Add BCM4908 generic board dts William Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0af44be8f5802e66011b4642de4632d4@milecki.pl \
--to=rafal@milecki.pl \
--cc=anand.gore@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=dan.beygelman@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=joel.peshkin@broadcom.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kursad.oney@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=william.zhang@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).