From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BBD42472A6 for ; Fri, 14 Nov 2025 03:24:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763090652; cv=none; b=LK5/nFTzN9rB/2KPTs275alIQIyXrIMJ4mWVli9wYkaX5btPZPxGiDYoXAOlUS2hMtXY1ULVS+E04eBWEuQVN9SkAyzurO6VzyR4F2BaveCS6vD+f6BbpLArDDVgVcsO05l4XyNjVKk7/mqN89n4i6FEMBCCKgQpWmuxdQwiRHs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763090652; c=relaxed/simple; bh=IprDe4qrgEnbzgwl5fo+9gFxfBlcWMJLzda+fR8+/jI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZsD3v0PUyGjf8xEwJFbm4g0XsOXKF/yrF7gNSEz1GybW/7dQfVtu7/5tNTlQLmpRkiH89/barZJPaSeYIUJGu6Y/7t/2uRAgxeOIiUHpkNAUKj/WgRf+EiRTrYHY1vpU2pCuXN1dVBB20Pge56Q2aIqDswIx3oPF2Dlom/eU+No= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ipZxZjBl; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=JFB23ZDv; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ipZxZjBl"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="JFB23ZDv" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5ADMb9va1498581 for ; Fri, 14 Nov 2025 03:24:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= KNxNrJsDy0YUjFlR7ksRiU45D5obzg7cc4C20QxDE/Y=; b=ipZxZjBlpn94HSAs 7nAYreD7sc9lb1a5s64/C1gL+YDaZU1kYqnZ0JefMAeevn4XEfyGOEevoXn8PTzm l+Zi7KwMtSlJIa9ULgHzo4S50n1R7wd/VOudQn6+tSEA3J3NffTbyyUUopW5rmgF D26O2PkfGWzf/fDVxRRiAhq07Bj0t2+7pNRh/iptzndjLk5H0f2uRuDa8FOuRg9q 0RejwoVvmXZKqZUxObHqDAAzxqjTVU5qJzOjI/zjDG/8I2FDv7rSEuXaheFl/Tjs cbth19/AW3mEA/L1L5MHrvgXFdQQ9w3k26+p/a7fAjVRHULX24MCVuEc79Zp03sM evxg+A== Received: from mail-pj1-f69.google.com (mail-pj1-f69.google.com [209.85.216.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4adr9drn1h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 14 Nov 2025 03:24:08 +0000 (GMT) Received: by mail-pj1-f69.google.com with SMTP id 98e67ed59e1d1-34377900dbcso2243292a91.2 for ; Thu, 13 Nov 2025 19:24:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1763090648; x=1763695448; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=KNxNrJsDy0YUjFlR7ksRiU45D5obzg7cc4C20QxDE/Y=; b=JFB23ZDvx+tKLD+gpWkg2/36OfP5l+C8nz5mpZiDlohyhK/ICWq166T6rLuG0MUm9P 49B8D4lVq57FC5dgAdFr5TP80mmD69Jw+N4j6VdnciqleIXeu4zi+jAiNZDrXk9YmbJE GxZxm+SiT07ogYUtI9KIUgyq6RJ/VQaHpMbuBSaYxrh+KPiOB/1s+ll1d0do77sRqOGU Kht30YDg6O85KxbC116NYI8vhWOiGkEIClS8Qta984ADhWYFrWIHvHRb49+NRjJ8pWao a3TsWHC2eNixAzCc8QVYHN3XN0bRWTCmuGUFdodGtgrybmcpRMfCke6orrLVkXu5L/VG xIHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763090648; x=1763695448; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KNxNrJsDy0YUjFlR7ksRiU45D5obzg7cc4C20QxDE/Y=; b=kJC9vonHWTuDC+RlV7MGJQHQH+HPZ8s2wx3TqjnOjbIVap+yVDDNRK9+eok/Ej4N6r 5LqkbqJh46EyJ5U5/chvl6zyusm9AVFL+t8Y5rlvnPx6p18cZnX0W+Y05xMiC7tahroD 7yHisBZb2RXmFLyhDnJZ6ppks3Ejvt9blyYfOZpC3VS2QR/eHE5lmj1D+yaGFyheGu9f m9w6v5pVBf5Zm5Tkpc70wd1UQMjwzbboPVychppsSzsxa7thQ52cPuTICsNG1sw5NtB1 f1XZnggqfwbhYC02uBNjy9BeoqcXwCLkiCRuTWP2/Q92R0glQu7VDVaYv7XrL1JcRuAa rH9A== X-Forwarded-Encrypted: i=1; AJvYcCUxYrYXFZNDGotILZOrdVmZRtsfAWWT9sTEpMBXwNPhyP1lHWhUf1Y21shgPO1uoWShevGUykXoHdQO@vger.kernel.org X-Gm-Message-State: AOJu0YzsRqE3aaC4kZhk+6y3IjriyThmm7KGqB3oSkm0y7mPsrNpM2aX K1ugGuJ7mqrRPzI180OCvijYHCPhTk9y8igi/l1p7R/bIdHp0202A37TkMte7IJdrGJw0pGtxyL J8X89T2rvlJlfxRmPPn5DpHt6Ww8EvEvxaVbwJmwCdxcGhi1808sZd9vBCpGntONG X-Gm-Gg: ASbGncsLNgEItZ8oHl9SW4y5RQMacntm9EFwl5XP5IaCRlm/Eu6NOPcRUXwrIOL4Qo6 pQ+viRslvHMHbGnGMn/c1TF9/UydW+B/dbpKIbBgt+R42upfnpkWeKuqVvXfdjX4LuqhKs4iFle pa1P3Zzl5fB8Jz38k5TR1NkC9i6LbaZWu7KTtsdXwWuxVwaYtj+SAqjKaD66QQee/TeqhluTn11 Wp2xObPILo5cUiVfP6MMC36kx8WKEqfFoY62NQtM0JQao16jhgsW2m9fyVsamcjmou/9sC5dd2R BNDhQ+1nMRvwzesPuSGkQxbfc+FDxal4wh2XhoUeSrL3qIRy7kh2mVMIK8n09vOw3btvvCgBw8Z 26uP2fmn/1Dw7xKJBc86zuQvdtKC2E2s= X-Received: by 2002:a17:90b:3c4a:b0:32e:4924:6902 with SMTP id 98e67ed59e1d1-343f9e92a0dmr1838132a91.3.1763090647816; Thu, 13 Nov 2025 19:24:07 -0800 (PST) X-Google-Smtp-Source: AGHT+IE2wHiv0drfPBC8W6GDpnf3DWvEzoDK4Gwj95uis+UUMkgLElPlSZP1kdkqV4QZv7KhWHUe/A== X-Received: by 2002:a17:90b:3c4a:b0:32e:4924:6902 with SMTP id 98e67ed59e1d1-343f9e92a0dmr1838093a91.3.1763090647306; Thu, 13 Nov 2025 19:24:07 -0800 (PST) Received: from [10.218.35.45] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7ba611682cfsm666067b3a.26.2025.11.13.19.24.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 13 Nov 2025 19:24:06 -0800 (PST) Message-ID: <0b019df0-f874-4218-a7fc-222b0e35727a@oss.qualcomm.com> Date: Fri, 14 Nov 2025 08:53:59 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: (subset) [PATCH v8 0/5] PCI: dwc: Add ECAM support with iATU configuration To: Bjorn Andersson Cc: cros-qcom-dts-watchers@chromium.org, Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Lorenzo Pieralisi , Manivannan Sadhasivam , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Bjorn Helgaas , Jingoo Han , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, quic_vbadigan@quicinc.com, quic_mrana@quicinc.com, quic_vpernami@quicinc.com, mmareddy@quicinc.com, Konrad Dybcio References: <20250828-ecam_v4-v8-0-92a30e0fa02d@oss.qualcomm.com> <176160465177.73268.9869510926279916233.b4-ty@kernel.org> Content-Language: en-US From: Krishna Chaitanya Chundru In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=IaiKmGqa c=1 sm=1 tr=0 ts=6916a0d8 cx=c_pps a=vVfyC5vLCtgYJKYeQD43oA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=6UeiqGixMTsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=I0CpK0KROK7xELUHsJQA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=rl5im9kqc5Lf4LNbBjHf:22 X-Proofpoint-ORIG-GUID: K614tbPi_kHT2E0ufc_DRrOucLy-WZYT X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMTE0MDAyNSBTYWx0ZWRfXxdyVZo9JLig4 4j1rt6FLJAy5pB3VMimumZY3ubohEG1X/01gCpu72N/Qqi/h0rKmSWdtnEOXJeX9DeNSv6jT95u qZU98e7qoNQcYZvVQgsahCuSSksXkEKfkLTGgm3/tLQM+fEzVZcu+3lcA5HgJxzNw3v70mNXfcB PzavaUiykurjP/jU/mQbCFsX2MMANKrpLrz/uzQiw6q1L2rADthhaWKjTypk1lfQZTDyqBlM2UL mxlK+XQtwvwAFZBPt4Nxh21Sh4SxI7zNgtx9MvD15YwDnXNpDANiWI/l7qDifVgbVTefX9g0Xl3 QuaA/IlNLjol6yKWrK71pjKespLig7241iXPyidyxS7SIf1Sn3GXvH+zJKzLxKoH17AhbNiLnTI ovinc6zckbLZSvqNfItc58rxP+xxYQ== X-Proofpoint-GUID: K614tbPi_kHT2E0ufc_DRrOucLy-WZYT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-11-13_07,2025-11-13_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 bulkscore=0 phishscore=0 clxscore=1015 spamscore=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2511140025 On 11/13/2025 11:03 PM, Bjorn Andersson wrote: > On Thu, Nov 13, 2025 at 09:27:36AM +0530, Krishna Chaitanya Chundru wrote: >> On 11/10/2025 11:51 PM, Bjorn Andersson wrote: >>> On Tue, Oct 28, 2025 at 11:12:23PM +0530, Krishna Chaitanya Chundru wrote: >>>> On 10/28/2025 4:07 AM, Bjorn Andersson wrote: >>>>> On Thu, 28 Aug 2025 13:04:21 +0530, Krishna Chaitanya Chundru wrote: >>>>>> The current implementation requires iATU for every configuration >>>>>> space access which increases latency & cpu utilization. >>>>>> >>>>>> Designware databook 5.20a, section 3.10.10.3 says about CFG Shift Feature, >>>>>> which shifts/maps the BDF (bits [31:16] of the third header DWORD, which >>>>>> would be matched against the Base and Limit addresses) of the incoming >>>>>> CfgRd0/CfgWr0 down to bits[27:12]of the translated address. >>>>>> >>>>>> [...] >>>>> Applied, thanks! >>>>> >>>>> [1/5] arm64: dts: qcom: sc7280: Increase config size to 256MB for ECAM feature >>>>> commit: 03e928442d469f7d8dafc549638730647202d9ce >>>> Hi Bjorn, >>>> >>>> Can you revert this change, this is regression due to this series due to >>>> that we have change the logic, >>> How is that possible? This is patch 1 in the series, by definition it >>> doesn't have any outstanding dependencies. >> The regression is due to the drivers changes on non qcom platforms. >> > Please be specific when you're answering, this way of saying "go fish" > isn't helpful. > > By investing a little bit more time and writing a single sentence to > share what you know, you could have enlightened me and other readers of > this email list. Sorry, for not being clear in the previous reply. The driver is implemented in a assumption that config space start address will be the dbi address. The driver is using config space start address as dbi address and ignoring the dbi address provided in the device tree.  This assumption is breaking other vendor driver i.e SiFive driver. To fix this regression we have removed this assumption keeping dbi and config space as separate entity. Due to these driver changes, we have to move DBI to different location (controller driver has ability to move the dbi space) for this reason we need to revert this. - Krishna Chaitanya. > Regards, > Bjorn > >> - Krishna Chaitanya. >>> I've reverted the change. >>> >>> Regards, >>> Bjorn >>> >>>> we need to update the dtsi accordingly, I will send a separate for all >>>> controllers to enable this ECAM feature. >>>> >>>> - Krishna Chaitanya. >>>> >>>> >>>>> Best regards,