Re: [PATCH v1 04/14] net: dt-bindings: Convert Marvell 8897/8997 bindings to YAML

[Ariel D'Alessandro <ariel.dalessandro@collabora.com>]

Hi Rob,

On 8/21/25 11:28 AM, Rob Herring wrote:
> On Wed, Aug 20, 2025 at 12:15 PM Ariel D'Alessandro
> <ariel.dalessandro@collabora.com> wrote:
>>
>> Convert the existing text-based DT bindings for Marvell 8897/8997
>> (sd8897/sd8997) bluetooth devices controller to a YAML schema.
>>
>> While here, bindings for "usb1286,204e" (USB interface) are dropped from
>> the YAML definition as these are currently documented in file:
>>
>> - Documentation/devicetree/bindings/net/btusb.txt
>>
>> Signed-off-by: Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>> ---
>>   .../bindings/net/marvell,sd8897-bt.yaml       | 91 +++++++++++++++++++
> 
> This needs to move to net/bluetooth/

Ack.

> 
>>   .../bindings/net/marvell-bt-8xxx.txt          | 83 -----------------
>>   2 files changed, 91 insertions(+), 83 deletions(-)
>>   create mode 100644 Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml
>>   delete mode 100644 Documentation/devicetree/bindings/net/marvell-bt-8xxx.txt
>>
>> diff --git a/Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml b/Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml
>> new file mode 100644
>> index 0000000000000..6539868c08b8a
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/net/marvell,sd8897-bt.yaml
>> @@ -0,0 +1,91 @@
>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/net/marvell,sd8897-bt.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Marvell 8897/8997 (sd8897/sd8997) bluetooth devices (SDIO)
>> +
>> +maintainers:
>> +  - Ariel D'Alessandro <ariel.dalessandro@collabora.com>
>> +
> 
> Needs a $ref to bluetooth-controller.yaml

Ack.

> 
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - marvell,sd8897-bt
>> +      - marvell,sd8997-bt
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  marvell,cal-data:
>> +    $ref: /schemas/types.yaml#/definitions/uint8-array
>> +    description:
>> +      Calibration data downloaded to the device during initialization.
>> +    minItems: 28
> 
> Just: maxItems: 28

Ack.

> 
>> +
>> +  marvell,wakeup-pin:
>> +    $ref: /schemas/types.yaml#/definitions/uint16
>> +    description:
>> +      Wakeup pin number of the bluetooth chip. Used by firmware to wakeup host
>> +      system.
>> +
>> +  marvell,wakeup-gap-ms:
> 
> This unfortunately needs a uint16 type. That will cause a warning
> which has to be fixed on the dtschema side.

Yeah, that's what I thought but wasn't sure on the proper solution. Will 
fix in v2.

> 
>> +    description:
>> +      Wakeup latency of the host platform. Required by the chip sleep feature.
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/irq.h>
>> +    #include <dt-bindings/pinctrl/rockchip.h>
> 
> Please drop this and just use a number below.

Ack.

> 
>> +
>> +    sdio0 {
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        btmrvl: btmrvl@2 {
>> +            compatible = "marvell,sd8897-bt";
>> +            reg = <2>;
>> +            interrupt-parent = <&gpio4>;
>> +            interrupts = <RK_PD7 IRQ_TYPE_LEVEL_LOW>;
>> +            marvell,wakeup-pin = /bits/ 16 <13>;
>> +            pinctrl-names = "default";
>> +            pinctrl-0 = <&bt_host_wake_l>;
>> +        };
>> +    };
> 
> I would drop this example.

Agreed.

> 
>> +
>> +    mmc3 {
> 
> mmc {

Ack.

> 
>> +        vmmc-supply = <&wlan_en_reg>;
>> +        bus-width = <4>;
>> +        cap-power-off-card;
>> +        keep-power-in-suspend;
>> +
>> +        #address-cells = <1>;
>> +        #size-cells = <0>;
>> +
>> +        bluetooth: bluetooth@2 {
> 
> Drop the label.

Ack.

Thanks a lot for your feedback and help!
Regards,

-- 
Ariel D'Alessandro
Software Engineer

Collabora Ltd.
Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK 
Registered in England & Wales, no. 5513718