From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BDD47083C; Mon, 3 Mar 2025 08:18:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740989894; cv=none; b=J0xcE+JZFPded99ciL1PK0wZVRRAzE9BH37zoKGXXsSRkExy0PdSK/MtnyIYumK8N3SRD953Rptg4fsfKCdVwkP0QUHM3CDGwl6j7ysiFrb0Uvo6O8jtNZg+Hg2OerabXtv6rMCeT91LdDfHlhpqbcX/GrzPWNredxgwtgJMEOs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740989894; c=relaxed/simple; bh=lsSwmwzKwKEFqzEBwDCIkRvNTrenry6xGvPaOarbA9c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=db3XKjbjTAIBi1OV1DQVLs2HivC82Go+uzFyNtN1J0ul8MerGkgbPVTlmZW6H2wsYuqEQkSjNaYr+ulgpjsrxGp2MNy/bFVno2r9W9sLH3m/9VjXZyCvDWVNtC8mba0deQP+cK1ygkEjDs+GMyQqjGPF+pGxxopYdXQimh5qwHY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=tbGDHeNQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="tbGDHeNQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 073B7C4CED6; Mon, 3 Mar 2025 08:18:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1740989894; bh=lsSwmwzKwKEFqzEBwDCIkRvNTrenry6xGvPaOarbA9c=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=tbGDHeNQpKWJi4/ycf7E7vEQ0vhBq6LZFbg5giQYjELPvTfEakFLO22w1p1Fhhk2h aQHahr+nq06GmwzcBrvNCxh/vIdlFwXH/hj6BRNgSmlIswxm26E4R6buGEcX8LXzlG yveABu+wdmZAyJIisrWw8sdCnd2xO34WCxd98j7Wo2yqJ58lWwpwk9JlyAqNMp9lx4 MU+Kw+2B2DOeNltdNBl6VFhY7TvA0IGkMT2BG+sEpACbSb3Zytk1bm4CRLJQqOg0/T 5BKVJu1wvYJ7OcuR0X7EAf4BUK6eT4uj7T0EKht7gH5NCdnsMbW5zXUV4MsOFxWoFD FY+mGfC7OdKLQ== Message-ID: <0b2a76e6-ad64-4c98-b6ab-e1f41cb54684@kernel.org> Date: Mon, 3 Mar 2025 09:18:08 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] dt-bindings: power: supply: Document Maxim MAX8971 charger To: Svyatoslav Ryhel Cc: Sebastian Reichel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20250226093700.44726-1-clamor95@gmail.com> <20250226093700.44726-2-clamor95@gmail.com> <20250227-cherubic-mantis-from-betelgeuse-86f5ff@krzk-bin> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 03/03/2025 09:11, Svyatoslav Ryhel wrote: > пн, 3 бер. 2025 р. о 09:54 Krzysztof Kozlowski пише: >> >> On 27/02/2025 11:55, Svyatoslav Ryhel wrote: >>>>> + >> >> Please kindly trim the replies from unnecessary context. It makes it >> much easier to find new content. >> >>>>> + maxim,usb-in-current-limit-microamp: >>>>> + description: >>>>> + USB Input current limit >>>>> + minimum: 100000 >>>>> + default: 500000 >>>>> + maximum: 1500000 >>>>> + >>>>> + maxim,ac-in-current-limit-microamp: >>>>> + description: >>>>> + AC Input current limit >>>>> + minimum: 100000 >>>>> + default: 500000 >>>>> + maximum: 1500000 >>>> >>>> Half of these properties as well are not suitable and duplicate existing >>>> sysfs interface. >>>> >>> >>> All these properties allow configure the charger to suit the device on >>> which it is used. None of them are required but are a nice addition. >>> Why you are denying me an ability to fully utilize hardware I have and >>> tune it to the device? All those values represent hardware registers >>> which can be customized for the device, not for the end user to mess >>> with. >> >> Because you put user-space choice or OS policy into the DT and DT is not >> for that. >> > > Those are NOT user-space choice or OS policy those are vendor > configuration for a specific device and are NOT and NEVER were exposed Then look at existing devices. We had these discussions in the past and these are usually exposed to user-space. > to user configurations EVER. User messing with those may lead to > device breaking. > >>> >>>> And for remaining, still no battery. >>>> >>> >>> reference to power-supply IS included, hence the battery option is >>> there as well. >> >> I don't see it being used at all and you explicitly duplicated >> properties which means that reference is redundant and should be dropped >> with such binding. So how did you solve my request to add reference >> which then you make redundant? Add reference and use it. >> > > Which properties I have duplicated? All the current limits. > >> Best regards, >> Krzysztof Best regards, Krzysztof