From: Philipp Zabel <p.zabel@pengutronix.de>
To: Horatiu Vultur <horatiu.vultur@microchip.com>
Cc: robh+dt@kernel.org, andrew@lunn.ch, lars.povlsen@microchip.com,
Steen.Hegelund@microchip.com, UNGLinuxDriver@microchip.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 2/2] reset: mchp: sparx5: Extend support for lan966x
Date: Mon, 18 Oct 2021 12:43:24 +0200 [thread overview]
Message-ID: <0b319e9a397d3c8299761a65393a69b0a45be22b.camel@pengutronix.de> (raw)
In-Reply-To: <20211014154000.jxnzeq6lnlkmnxzf@soft-dev3-1.localhost>
On Thu, 2021-10-14 at 17:40 +0200, Horatiu Vultur wrote:
>
> > > + */
> > > + err = mchp_sparx5_map_syscon(pdev, "cuphy-syscon", &ctx->cuphy_ctrl);
> > > + if (err && err != -ENODEV)
> > > + return err;
> >
> > So -ENODEV should return an error if .cuphy_reg is set?
>
> I am not sure I follow this.
> If cuphy-syscon is not set then mchp_sparx5_map_syscon will return
> -ENODEV. This can be ignored for sparx5 as this is not required.
> If cuphy-syscon is set then if mchp_sparx5_map_syscon returns an error
> then report this error.
My point was that in case of cuphy-syscon missing from the DT, the
lan966x compatible reset controller should probably throw the error
instead of ignoring it. With v4 this is not relevant any more.
regards
Philipp
prev parent reply other threads:[~2021-10-18 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 7:38 [PATCH v3 0/2] Extend Sparx5 switch reset driver for lan966x Horatiu Vultur
2021-10-13 7:38 ` [PATCH v3 1/2] dt-bindings: reset: Add lan966x support Horatiu Vultur
2021-10-14 11:55 ` Philipp Zabel
2021-10-14 15:20 ` Horatiu Vultur
2021-10-15 14:14 ` Horatiu Vultur
2021-10-18 10:40 ` Philipp Zabel
2021-10-13 7:38 ` [PATCH v3 2/2] reset: mchp: sparx5: Extend support for lan966x Horatiu Vultur
2021-10-14 12:00 ` Philipp Zabel
2021-10-14 15:40 ` Horatiu Vultur
2021-10-18 10:43 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b319e9a397d3c8299761a65393a69b0a45be22b.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=Steen.Hegelund@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).