From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD51EC761A6 for ; Fri, 31 Mar 2023 17:05:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229832AbjCaRFi (ORCPT ); Fri, 31 Mar 2023 13:05:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231735AbjCaRFS (ORCPT ); Fri, 31 Mar 2023 13:05:18 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9E0BCEB54 for ; Fri, 31 Mar 2023 10:05:17 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B9F47106F; Fri, 31 Mar 2023 10:06:01 -0700 (PDT) Received: from [10.1.196.177] (eglon.cambridge.arm.com [10.1.196.177]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D78403F6C4; Fri, 31 Mar 2023 10:05:14 -0700 (PDT) Message-ID: <0b3722b1-0a0c-c934-dd25-e940386dc8d9@arm.com> Date: Fri, 31 Mar 2023 18:05:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 5/6] firmware: smccc: Allow errata management to be overridden by device tree Content-Language: en-GB To: kernel test robot , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: oe-kbuild-all@lists.linux.dev, Catalin Marinas , Will Deacon , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Marc Zyngier , Oliver Upton , Rob Herring , Krzysztof Kozlowski References: <20230330165128.3237939-6-james.morse@arm.com> <202303310444.3JHIsByA-lkp@intel.com> From: James Morse In-Reply-To: <202303310444.3JHIsByA-lkp@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/03/2023 21:44, kernel test robot wrote: > I love your patch! Perhaps something to improve: > All warnings (new ones prefixed by >>): > >>> drivers/firmware/smccc/em.c:142:5: warning: no previous prototype for 'arm_smccc_em_dt_alloc_tbl_entry' [-Wmissing-prototypes] > 142 | int arm_smccc_em_dt_alloc_tbl_entry(struct device_node *np, const char *name, > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ It's just missing a static. Fixed locally. Thanks, James