From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Arun Kumar K' <arunkk.samsung@gmail.com>,
'Doug Anderson' <dianders@chromium.org>
Cc: 'linux-samsung-soc' <linux-samsung-soc@vger.kernel.org>,
devicetree@vger.kernel.org, 'Olof Johansson' <olofj@google.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>,
'Tushar Behera' <tushar.behera@linaro.org>
Subject: RE: [PATCH v2] ARM: dts: Add peach-pit board support
Date: Sat, 26 Apr 2014 19:56:48 +0900 [thread overview]
Message-ID: <0b4001cf613e$38abbf00$aa033d00$@samsung.com> (raw)
In-Reply-To: <CALt3h7-TmqtZRqdG=KxqeYdeWEKEbiyNaXAdQMoOb-aCLrD1_w@mail.gmail.com>
Arun Kumar K wrote:
>
> Thanks Doug & Tushar for the Reviewed-by.
>
> On Fri, Apr 25, 2014 at 12:27 AM, Doug Anderson <dianders@chromium.org>
> wrote:
> > Arun,
> >
> > On Wed, Apr 23, 2014 at 9:17 PM, Arun Kumar K <arun.kk@samsung.com>
> wrote:
> >> Adds the google peach-pit board dts file which uses
> >> exynos5420 SoC.
> >>
> >> Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
> >> Signed-off-by: Doug Anderson <dianders@chromium.org>
> >> ---
> >> Changes from v1
> >> ---------------
> >> - Addressed review comments from Doug, Sachin & Tushar
> >> - Removed adc and lid-switch nodes
> >> ---
> >> arch/arm/boot/dts/Makefile | 1 +
> >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 182
> ++++++++++++++++++++++++++++
> >> 2 files changed, 183 insertions(+)
> >> + spi@12d30000 {
> >> + status = "okay";
> >> + samsung,spi-src-clk = <0>;
> >> + num-cs = <1>;
> >> +
> >> + spidev@0 {
> >> + compatible = "spidev";
> >> + reg = <0>;
> >> + spi-max-frequency = <50000000>;
> >> + pinctrl-names = "default";
> >> + pinctrl-0 = <&spi_flash_cs>;
> >> +
> >> + controller-data {
> >> + cs-gpio = <&gpa2 5 0>;
> >
> > Technically this could be
> >
> > cs-gpio = <&gpa2 5 GPIO_ACTIVE_HIGH>;
> >
> > ...but I don't think that's a huge deal...
> >
>
> Kukjin, please let me know if I need to re-send this or can you take
> care while applying?
>
Arun, can you please re-spin with tag of reviewed-by?
Thanks,
Kukjin
>
> > Reviewed-by: Doug Anderson <dianders@chromium.org>
next prev parent reply other threads:[~2014-04-26 10:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-24 4:17 [PATCH v2] ARM: dts: Add peach-pit board support Arun Kumar K
2014-04-24 5:30 ` Tushar Behera
2014-04-24 18:57 ` Doug Anderson
2014-04-25 4:01 ` Arun Kumar K
2014-04-26 10:56 ` Kukjin Kim [this message]
2014-04-26 11:32 ` Tomasz Figa
2014-04-28 4:22 ` Arun Kumar K
2014-04-28 17:43 ` Doug Anderson
2014-04-30 6:34 ` Arun Kumar K
2014-04-30 16:48 ` Doug Anderson
2014-05-01 8:21 ` Arun Kumar K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='0b4001cf613e$38abbf00$aa033d00$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=arunkk.samsung@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olofj@google.com \
--cc=sachin.kamat@linaro.org \
--cc=tushar.behera@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).