From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E46DC433EF for ; Mon, 23 May 2022 10:05:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233837AbiEWKE7 (ORCPT ); Mon, 23 May 2022 06:04:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233818AbiEWKEx (ORCPT ); Mon, 23 May 2022 06:04:53 -0400 Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AC3A0BCBB; Mon, 23 May 2022 03:04:50 -0700 (PDT) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id B888A1F41C08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1653300289; bh=GO3pTjYvyxyhAs/0dgN9/lVi2515gb9ZaDpQ4GAZKm8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dRAR+qsGkJ2/IN9jSl1ZS+W7iWu9cZmOEOHTU1+mujZBjw4VAtBWspkSiFgUe7Gj9 l0PaGsHJEgPhshlEXnphw7w6OfIXWgms2bD9CIzeTBEe96z6gSoOs9KkfYoIPKxO6K ECKU8vN3+QGUP43qMHYVDa3rFKN8ynYWRbLtXRDeY+T2CMIAgwGpTF7Lbikg7r9c5E x6uYxn94fQdvvdocz/ZdUy8XscXlZ7KdbCQreAPyRGwZmFFe4PYS2kCD7YZJv7Oode 7I26Bgd4rePJRexhypZoTJI7IVwFSG2Ffy8OOaB5Ar/q7e/+gm7WfkqUn+vHpTZEfB DtOPVkWtf1wYw== Message-ID: <0b46efc0-bc06-5416-f24b-c53ff79736c8@collabora.com> Date: Mon, 23 May 2022 12:04:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v2 1/4] arm64: dts: mt8183: Fix Mali GPU clock Content-Language: en-US To: Chen-Yu Tsai , Michael Turquette , Stephen Boyd , Matthias Brugger Cc: Rob Herring , Krzysztof Kozlowski , Chun-Jie Chen , Miles Chen , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220523085923.1430470-1-wenst@chromium.org> <20220523085923.1430470-2-wenst@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20220523085923.1430470-2-wenst@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Il 23/05/22 10:59, Chen-Yu Tsai ha scritto: > The actual clock feeding into the Mali GPU on the MT8183 is from the > clock gate in the MFGCFG block, not CLK_TOP_MFGPLL_CK from the TOPCKGEN > block, which itself is simply a pass-through placeholder for the MFGPLL > in the APMIXEDSYS block. > > Fix the hardware description with the correct clock reference. > > Fixes: a8168cebf1bc ("arm64: dts: mt8183: Add node for the Mali GPU") > Signed-off-by: Chen-Yu Tsai Reviewed-by: AngeloGioacchino Del Regno > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 01e650251928..6ced76a60aab 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -1368,7 +1368,7 @@ gpu: gpu@13040000 { > ; > interrupt-names = "job", "mmu", "gpu"; > > - clocks = <&topckgen CLK_TOP_MFGPLL_CK>; > + clocks = <&mfgcfg CLK_MFG_BG3D>; > > power-domains = > <&spm MT8183_POWER_DOMAIN_MFG_CORE0>,