From: David Lechner <dlechner@baylibre.com>
To: Jonathan Cameron <jic23@kernel.org>,
Antoniu Miclaus <antoniu.miclaus@analog.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, nuno.sa@analog.com,
conor+dt@kernel.org, ukleinek@kernel.org,
dragos.bogdan@analog.com, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-pwm@vger.kernel.org
Subject: Re: [PATCH v4 6/6] iio: adc: ad4851: add ad485x driver
Date: Tue, 22 Oct 2024 17:28:47 -0500 [thread overview]
Message-ID: <0b478ed2-dd1e-4014-8501-2e1b50b473e3@baylibre.com> (raw)
In-Reply-To: <20241019144912.697d9d29@jic23-huawei>
On 10/19/24 8:49 AM, Jonathan Cameron wrote:
> On Fri, 18 Oct 2024 13:42:10 +0300
> Antoniu Miclaus <antoniu.miclaus@analog.com> wrote:
>
>> Add support for the AD485X a fully buffered, 8-channel simultaneous
>> sampling, 16/20-bit, 1 MSPS data acquisition system (DAS) with
>> differential, wide common-mode range inputs.
>>
>> Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com>
>
> A few minor things from me that I could fix whilst applying,
> but David gave a much more detailed review of v3, so I'll wait
> for his feedback on this. I haven't dug into datasheets much and
> may well have missed other things.
>
Many of my review comments were not addressed at all. :-(
Plus one addressed incorrectly (rounding PWM period down instead
of the suggested rounding up).
I still have major concerns about userspace-facing things like the
questionable use of the offset attribute and fixing how oversampling
interacts with the scan_type.
next prev parent reply other threads:[~2024-10-22 22:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-18 10:42 [PATCH v4 1/6] iio: backend: add API for interface get Antoniu Miclaus
2024-10-18 10:42 ` [PATCH v4 2/6] iio: backend: add support for data size set Antoniu Miclaus
2024-10-18 10:42 ` [PATCH v4 3/6] iio: adc: adi-axi-adc: add interface type Antoniu Miclaus
2024-10-22 21:22 ` David Lechner
2024-10-18 10:42 ` [PATCH v4 4/6] iio: adc: adi-axi-adc: set data format Antoniu Miclaus
2024-10-18 10:42 ` [PATCH v4 5/6] dt-bindings: iio: adc: add ad4851 Antoniu Miclaus
2024-10-19 13:42 ` Jonathan Cameron
2024-10-18 10:42 ` [PATCH v4 6/6] iio: adc: ad4851: add ad485x driver Antoniu Miclaus
2024-10-19 13:49 ` Jonathan Cameron
2024-10-22 22:28 ` David Lechner [this message]
2024-10-22 21:20 ` [PATCH v4 1/6] iio: backend: add API for interface get David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b478ed2-dd1e-4014-8501-2e1b50b473e3@baylibre.com \
--to=dlechner@baylibre.com \
--cc=antoniu.miclaus@analog.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox