devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema
@ 2022-12-25 11:58 Krzysztof Kozlowski
  2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-25 11:58 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Bindings expect OPP tables to start with "opp-table".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
 arch/arm/boot/dts/qcom-sdx65.dtsi | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
index 5408ff715fbf..c64088c12c89 100644
--- a/arch/arm/boot/dts/qcom-sdx55.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
@@ -62,7 +62,7 @@ cpu0: cpu@0 {
 		};
 	};
 
-	cpu_opp_table: cpu-opp-table {
+	cpu_opp_table: opp-table-cpu {
 		compatible = "operating-points-v2";
 		opp-shared;
 
diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
index d3c661d7650d..aa6439d8763a 100644
--- a/arch/arm/boot/dts/qcom-sdx65.dtsi
+++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
@@ -61,7 +61,7 @@ cpu0: cpu@0 {
 		};
 	};
 
-	cpu_opp_table: cpu-opp-table {
+	cpu_opp_table: opp-table-cpu {
 		compatible = "operating-points-v2";
 		opp-shared;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 2/4] arm64: dts: qcom: align OPP table node name with DT schema
  2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
@ 2022-12-25 11:58 ` Krzysztof Kozlowski
  2022-12-27 11:19   ` Konrad Dybcio
  2022-12-27 17:17   ` Johan Hovold
  2022-12-25 11:58 ` [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro Krzysztof Kozlowski
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-25 11:58 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Bindings expect OPP tables to start with "opp-table".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
 arch/arm64/boot/dts/qcom/sa8540p.dtsi      | 4 ++--
 arch/arm64/boot/dts/qcom/sc8280xp.dtsi     | 6 +++---
 arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
index 5728583af41e..929bdcd45d02 100644
--- a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
+++ b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
@@ -19,7 +19,7 @@ / {
   * features get enabled upstream.
   */
 
-gpu_opp_table_3_0: gpu-opp-table-30 {
+gpu_opp_table_3_0: opp-table-gpu30 {
 	compatible = "operating-points-v2";
 
 	opp-624000000 {
diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
index a88452c20d05..4a990fda8fc3 100644
--- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi
+++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
@@ -10,7 +10,7 @@
 /delete-node/ &cpu4_opp_table;
 
 / {
-	cpu0_opp_table: cpu0-opp-table {
+	cpu0_opp_table: opp-table-cpu0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -92,7 +92,7 @@ opp-2246400000 {
 		};
 	};
 
-	cpu4_opp_table: cpu4-opp-table {
+	cpu4_opp_table: opp-table-cpu4 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
index 109c9d2b684d..89004cb657e0 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
@@ -33,7 +33,7 @@ sleep_clk: sleep-clk {
 		};
 	};
 
-	cpu0_opp_table: cpu0-opp-table {
+	cpu0_opp_table: opp-table-cpu0 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -123,7 +123,7 @@ opp-2438400000 {
 		};
 	};
 
-	cpu4_opp_table: cpu4-opp-table {
+	cpu4_opp_table: opp-table-cpu4 {
 		compatible = "operating-points-v2";
 		opp-shared;
 
@@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 {
 		};
 	};
 
-	qup_opp_table_100mhz: qup-100mhz-opp-table {
+	qup_opp_table_100mhz: opp-table-qup100mhz {
 		compatible = "operating-points-v2";
 
 		opp-75000000 {
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index 65032b94b46d..ba48adc01170 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -4619,7 +4619,7 @@ port@1 {
 					};
 				};
 
-				dp_opp_table: dp-opp-table {
+				dp_opp_table: opp-table {
 					compatible = "operating-points-v2";
 
 					opp-162000000 {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro
  2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
  2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
@ 2022-12-25 11:58 ` Krzysztof Kozlowski
  2022-12-27 11:18   ` Konrad Dybcio
  2022-12-25 11:58 ` [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro Krzysztof Kozlowski
  2022-12-27 11:18 ` [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Konrad Dybcio
  3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-25 11:58 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Neither qcom,sm8250-lpass-wsa-macro bindings nor the driver use
"clock-frequency" property.

  sm8250-hdk.dtb: codec@3240000: Unevaluated properties are not allowed ('clock-frequency' was unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index 434e2c4cce79..a58f51083715 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2215,7 +2215,6 @@ wsamacro: codec@3240000 {
 			clock-names = "mclk", "npl", "macro", "dcodec", "va", "fsgen";
 
 			#clock-cells = <0>;
-			clock-frequency = <9600000>;
 			clock-output-names = "mclk";
 			#sound-dai-cells = <1>;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro
  2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
  2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
  2022-12-25 11:58 ` [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro Krzysztof Kozlowski
@ 2022-12-25 11:58 ` Krzysztof Kozlowski
  2022-12-27 11:19   ` Konrad Dybcio
  2022-12-27 11:18 ` [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Konrad Dybcio
  3 siblings, 1 reply; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-25 11:58 UTC (permalink / raw)
  To: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel
  Cc: Krzysztof Kozlowski

Neither qcom,sm8250-lpass-tx-macro bindings nor the driver use
"clock-frequency" and address/size cells properties.

  sm8250-mtp.dtb: txmacro@3220000: Unevaluated properties are not allowed ('clock-frequency', '#address-cells', '#size-cells' were unexpected)

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index a58f51083715..ddd750591e8c 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2329,10 +2329,7 @@ txmacro: txmacro@3220000 {
 			clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
 
 			#clock-cells = <0>;
-			clock-frequency = <9600000>;
 			clock-output-names = "mclk";
-			#address-cells = <2>;
-			#size-cells = <2>;
 			#sound-dai-cells = <1>;
 		};
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema
  2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
                   ` (2 preceding siblings ...)
  2022-12-25 11:58 ` [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro Krzysztof Kozlowski
@ 2022-12-27 11:18 ` Konrad Dybcio
  3 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:18 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 25.12.2022 12:58, Krzysztof Kozlowski wrote:
> Bindings expect OPP tables to start with "opp-table".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm/boot/dts/qcom-sdx55.dtsi | 2 +-
>  arch/arm/boot/dts/qcom-sdx65.dtsi | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/qcom-sdx55.dtsi b/arch/arm/boot/dts/qcom-sdx55.dtsi
> index 5408ff715fbf..c64088c12c89 100644
> --- a/arch/arm/boot/dts/qcom-sdx55.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx55.dtsi
> @@ -62,7 +62,7 @@ cpu0: cpu@0 {
>  		};
>  	};
>  
> -	cpu_opp_table: cpu-opp-table {
> +	cpu_opp_table: opp-table-cpu {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> diff --git a/arch/arm/boot/dts/qcom-sdx65.dtsi b/arch/arm/boot/dts/qcom-sdx65.dtsi
> index d3c661d7650d..aa6439d8763a 100644
> --- a/arch/arm/boot/dts/qcom-sdx65.dtsi
> +++ b/arch/arm/boot/dts/qcom-sdx65.dtsi
> @@ -61,7 +61,7 @@ cpu0: cpu@0 {
>  		};
>  	};
>  
> -	cpu_opp_table: cpu-opp-table {
> +	cpu_opp_table: opp-table-cpu {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro
  2022-12-25 11:58 ` [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro Krzysztof Kozlowski
@ 2022-12-27 11:18   ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:18 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 25.12.2022 12:58, Krzysztof Kozlowski wrote:
> Neither qcom,sm8250-lpass-wsa-macro bindings nor the driver use
> "clock-frequency" property.
> 
>   sm8250-hdk.dtb: codec@3240000: Unevaluated properties are not allowed ('clock-frequency' was unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index 434e2c4cce79..a58f51083715 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2215,7 +2215,6 @@ wsamacro: codec@3240000 {
>  			clock-names = "mclk", "npl", "macro", "dcodec", "va", "fsgen";
>  
>  			#clock-cells = <0>;
> -			clock-frequency = <9600000>;
>  			clock-output-names = "mclk";
>  			#sound-dai-cells = <1>;
>  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: align OPP table node name with DT schema
  2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
@ 2022-12-27 11:19   ` Konrad Dybcio
  2022-12-27 17:17   ` Johan Hovold
  1 sibling, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 25.12.2022 12:58, Krzysztof Kozlowski wrote:
> Bindings expect OPP tables to start with "opp-table".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
>  arch/arm64/boot/dts/qcom/sa8540p.dtsi      | 4 ++--
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi     | 6 +++---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
> index 5728583af41e..929bdcd45d02 100644
> --- a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
> @@ -19,7 +19,7 @@ / {
>    * features get enabled upstream.
>    */
>  
> -gpu_opp_table_3_0: gpu-opp-table-30 {
> +gpu_opp_table_3_0: opp-table-gpu30 {
>  	compatible = "operating-points-v2";
>  
>  	opp-624000000 {
> diff --git a/arch/arm64/boot/dts/qcom/sa8540p.dtsi b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> index a88452c20d05..4a990fda8fc3 100644
> --- a/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sa8540p.dtsi
> @@ -10,7 +10,7 @@
>  /delete-node/ &cpu4_opp_table;
>  
>  / {
> -	cpu0_opp_table: cpu0-opp-table {
> +	cpu0_opp_table: opp-table-cpu0 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> @@ -92,7 +92,7 @@ opp-2246400000 {
>  		};
>  	};
>  
> -	cpu4_opp_table: cpu4-opp-table {
> +	cpu4_opp_table: opp-table-cpu4 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 109c9d2b684d..89004cb657e0 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -33,7 +33,7 @@ sleep_clk: sleep-clk {
>  		};
>  	};
>  
> -	cpu0_opp_table: cpu0-opp-table {
> +	cpu0_opp_table: opp-table-cpu0 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> @@ -123,7 +123,7 @@ opp-2438400000 {
>  		};
>  	};
>  
> -	cpu4_opp_table: cpu4-opp-table {
> +	cpu4_opp_table: opp-table-cpu4 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 {
>  		};
>  	};
>  
> -	qup_opp_table_100mhz: qup-100mhz-opp-table {
> +	qup_opp_table_100mhz: opp-table-qup100mhz {
>  		compatible = "operating-points-v2";
>  
>  		opp-75000000 {
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> index 65032b94b46d..ba48adc01170 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -4619,7 +4619,7 @@ port@1 {
>  					};
>  				};
>  
> -				dp_opp_table: dp-opp-table {
> +				dp_opp_table: opp-table {
>  					compatible = "operating-points-v2";
>  
>  					opp-162000000 {

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro
  2022-12-25 11:58 ` [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro Krzysztof Kozlowski
@ 2022-12-27 11:19   ` Konrad Dybcio
  0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2022-12-27 11:19 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Andy Gross, Bjorn Andersson, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel



On 25.12.2022 12:58, Krzysztof Kozlowski wrote:
> Neither qcom,sm8250-lpass-tx-macro bindings nor the driver use
> "clock-frequency" and address/size cells properties.
> 
>   sm8250-mtp.dtb: txmacro@3220000: Unevaluated properties are not allowed ('clock-frequency', '#address-cells', '#size-cells' were unexpected)
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sm8250.dtsi | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index a58f51083715..ddd750591e8c 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2329,10 +2329,7 @@ txmacro: txmacro@3220000 {
>  			clock-names = "mclk", "npl", "macro", "dcodec", "fsgen";
>  
>  			#clock-cells = <0>;
> -			clock-frequency = <9600000>;
>  			clock-output-names = "mclk";
> -			#address-cells = <2>;
> -			#size-cells = <2>;
>  			#sound-dai-cells = <1>;
>  		};
>  

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: align OPP table node name with DT schema
  2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
  2022-12-27 11:19   ` Konrad Dybcio
@ 2022-12-27 17:17   ` Johan Hovold
  2022-12-28  9:38     ` Krzysztof Kozlowski
  1 sibling, 1 reply; 10+ messages in thread
From: Johan Hovold @ 2022-12-27 17:17 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel

On Sun, Dec 25, 2022 at 12:58:42PM +0100, Krzysztof Kozlowski wrote:
> Bindings expect OPP tables to start with "opp-table".
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
>  arch/arm64/boot/dts/qcom/sa8540p.dtsi      | 4 ++--
>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi     | 6 +++---
>  arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
>  4 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
> index 5728583af41e..929bdcd45d02 100644
 
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> index 109c9d2b684d..89004cb657e0 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
> @@ -33,7 +33,7 @@ sleep_clk: sleep-clk {
>  		};
>  	};
>  
> -	cpu0_opp_table: cpu0-opp-table {
> +	cpu0_opp_table: opp-table-cpu0 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> @@ -123,7 +123,7 @@ opp-2438400000 {
>  		};
>  	};
>  
> -	cpu4_opp_table: cpu4-opp-table {
> +	cpu4_opp_table: opp-table-cpu4 {
>  		compatible = "operating-points-v2";
>  		opp-shared;
>  
> @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 {
>  		};
>  	};
>  
> -	qup_opp_table_100mhz: qup-100mhz-opp-table {
> +	qup_opp_table_100mhz: opp-table-qup100mhz {
>  		compatible = "operating-points-v2";
>  
>  		opp-75000000 {

Please also move these nodes after the 'memory' node so that they remain
sorted by name.

Johan

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 2/4] arm64: dts: qcom: align OPP table node name with DT schema
  2022-12-27 17:17   ` Johan Hovold
@ 2022-12-28  9:38     ` Krzysztof Kozlowski
  0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-28  9:38 UTC (permalink / raw)
  To: Johan Hovold
  Cc: Andy Gross, Bjorn Andersson, Konrad Dybcio, Rob Herring,
	Krzysztof Kozlowski, linux-arm-msm, devicetree, linux-kernel

On 27/12/2022 18:17, Johan Hovold wrote:
> On Sun, Dec 25, 2022 at 12:58:42PM +0100, Krzysztof Kozlowski wrote:
>> Bindings expect OPP tables to start with "opp-table".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi | 2 +-
>>  arch/arm64/boot/dts/qcom/sa8540p.dtsi      | 4 ++--
>>  arch/arm64/boot/dts/qcom/sc8280xp.dtsi     | 6 +++---
>>  arch/arm64/boot/dts/qcom/sdm845.dtsi       | 2 +-
>>  4 files changed, 7 insertions(+), 7 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi b/arch/arm64/boot/dts/qcom/msm8996-v3.0.dtsi
>> index 5728583af41e..929bdcd45d02 100644
>  
>> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> index 109c9d2b684d..89004cb657e0 100644
>> --- a/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sc8280xp.dtsi
>> @@ -33,7 +33,7 @@ sleep_clk: sleep-clk {
>>  		};
>>  	};
>>  
>> -	cpu0_opp_table: cpu0-opp-table {
>> +	cpu0_opp_table: opp-table-cpu0 {
>>  		compatible = "operating-points-v2";
>>  		opp-shared;
>>  
>> @@ -123,7 +123,7 @@ opp-2438400000 {
>>  		};
>>  	};
>>  
>> -	cpu4_opp_table: cpu4-opp-table {
>> +	cpu4_opp_table: opp-table-cpu4 {
>>  		compatible = "operating-points-v2";
>>  		opp-shared;
>>  
>> @@ -591,7 +591,7 @@ CLUSTER_PD: cpu-cluster0 {
>>  		};
>>  	};
>>  
>> -	qup_opp_table_100mhz: qup-100mhz-opp-table {
>> +	qup_opp_table_100mhz: opp-table-qup100mhz {
>>  		compatible = "operating-points-v2";
>>  
>>  		opp-75000000 {
> 
> Please also move these nodes after the 'memory' node so that they remain
> sorted by name.

OK

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2022-12-28  9:38 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-12-25 11:58 [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Krzysztof Kozlowski
2022-12-25 11:58 ` [PATCH 2/4] arm64: " Krzysztof Kozlowski
2022-12-27 11:19   ` Konrad Dybcio
2022-12-27 17:17   ` Johan Hovold
2022-12-28  9:38     ` Krzysztof Kozlowski
2022-12-25 11:58 ` [PATCH 3/4] arm64: dts: qcom: sm8250: drop unused clock-frequency from wsa-macro Krzysztof Kozlowski
2022-12-27 11:18   ` Konrad Dybcio
2022-12-25 11:58 ` [PATCH 4/4] arm64: dts: qcom: sm8250: drop unused properties from tx-macro Krzysztof Kozlowski
2022-12-27 11:19   ` Konrad Dybcio
2022-12-27 11:18 ` [PATCH 1/4] ARM: dts: qcom: align OPP table node name with DT schema Konrad Dybcio

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).