From: Sven Peter <sven@kernel.org>
To: Conor Dooley <conor@kernel.org>
Cc: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: reset: Add Apple SoC CIO reset
Date: Tue, 11 Aug 2026 18:44:32 +0200 [thread overview]
Message-ID: <0b4f3e19-0944-47f4-a113-1e0c2a5af08b@kernel.org> (raw)
In-Reply-To: <20260810-unveiled-specked-a856434db8df@spud>
On 8/10/26 18:02, Conor Dooley wrote:
> On Sun, Aug 09, 2026 at 02:16:02PM +0200, Sven Peter wrote:
>> The CIO (USB4/Thunderbolt) blocks on Apple Silicon SoCs have a reset
>> inside the power manager that has to be deasserted before their
>> co-processor can be booted. On t8103 each port comes with a dedicated
>> register page, represented as a standalone node. On t600x a single
>> register shared by all ports of a die is located in the middle of the
>> PMGR MMIO region instead, represented as a sub-node of the PMGR syscon.
>>
>> Signed-off-by: Sven Peter <sven@kernel.org>
> Fix the sashiko complaint and then
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> pw-bot: not-applicable
>
>> + - |
>> + power-management@28e080000 {
>> + compatible = "apple,t6000-pmgr", "apple,pmgr", "syscon", "simple-mfd";
>> + reg = <0x8e080000 0x1c000>;
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> +
>> + reset-controller@1a034 {
>> + compatible = "apple,t6000-cio-reset";
>> + reg = <0x1a034 0x4>;
>> + #reset-cells = <1>;
>> + };
>> + };
> Probably the fix is actually moving this to the parent device bnding.
Thanks for the review, I've moved the example to the parent binding
where I just had to add the reset-controller node itself and could drop
all the stuff around it.
Thanks,
Sven
next prev parent reply other threads:[~2026-08-11 16:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-09 12:16 [PATCH 0/3] Apple SoC CIO (USB4/Thunderbolt) reset controller Sven Peter
2026-08-09 12:16 ` [PATCH 1/3] dt-bindings: reset: Add Apple SoC CIO reset Sven Peter
2026-08-09 12:26 ` sashiko-bot
2026-08-10 16:02 ` Conor Dooley
2026-08-11 16:44 ` Sven Peter [this message]
2026-08-09 12:16 ` [PATCH 2/3] reset: Add Apple SoC CIO reset driver Sven Peter
2026-08-09 12:28 ` sashiko-bot
2026-08-09 14:30 ` Joshua Peisach
2026-08-09 15:20 ` Sven Peter
2026-08-09 17:13 ` Joshua Peisach
2026-08-09 12:16 ` [PATCH 3/3] arm64: dts: apple: Add CIO reset controllers Sven Peter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b4f3e19-0944-47f4-a113-1e0c2a5af08b@kernel.org \
--to=sven@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=conor+dt@kernel.org \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=j@jannau.net \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neal@gompa.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox