From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5EBD4C2D0EA for ; Wed, 8 Apr 2020 04:42:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2FC1A20747 for ; Wed, 8 Apr 2020 04:42:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="UDOh/7HX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726366AbgDHEmw (ORCPT ); Wed, 8 Apr 2020 00:42:52 -0400 Received: from mail26.static.mailgun.info ([104.130.122.26]:57735 "EHLO mail26.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbgDHEmw (ORCPT ); Wed, 8 Apr 2020 00:42:52 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1586320971; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=iWIIGMPoYNGURX0VaZ3ac1DtOkfzwlUTUE4xxC9XYag=; b=UDOh/7HXm7aJ7VdtmNpltTdba0Ej7naEFrCNFmrs3XRXva8YjZ/N9ZA8byC+yBjHPMm1Q90x 9+wX9+ksITdgVETfgBq2/WoV4+NitD0NSHH97tt75c0F+Gm/oxnUEgT+kr6HgADJngr40FlT sg0SWQ/JCaydZF4L2hdNSLPPQKs= X-Mailgun-Sending-Ip: 104.130.122.26 X-Mailgun-Sid: WyI1YmJiNiIsICJkZXZpY2V0cmVlQHZnZXIua2VybmVsLm9yZyIsICJiZTllNGEiXQ== Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e8d563e.7f1592bed3e8-smtp-out-n04; Wed, 08 Apr 2020 04:42:38 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 20F40C44788; Wed, 8 Apr 2020 04:42:37 +0000 (UTC) Received: from [10.206.24.160] (blr-c-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sanm) by smtp.codeaurora.org (Postfix) with ESMTPSA id CF290C433F2; Wed, 8 Apr 2020 04:42:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CF290C433F2 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=sanm@codeaurora.org Subject: Re: [PATCH v5 1/2] dt-bindings: usb: qcom,dwc3: Convert USB DWC3 bindings To: Stephen Boyd , Andy Gross , Bjorn Andersson , Doug Anderson , Felipe Balbi , Greg Kroah-Hartman , Mark Rutland , Matthias Kaehlcke , Rob Herring Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam References: <1585206368-685-1-git-send-email-sanm@codeaurora.org> <1585206368-685-2-git-send-email-sanm@codeaurora.org> <158631747937.216820.504748426462367724@swboyd.mtv.corp.google.com> From: "Sandeep Maheswaram (Temp)" Message-ID: <0b8d0d73-0421-bd4d-9dcc-62713c1c7f23@codeaurora.org> Date: Wed, 8 Apr 2020 10:12:27 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <158631747937.216820.504748426462367724@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 4/8/2020 9:14 AM, Stephen Boyd wrote: > Quoting Sandeep Maheswaram (2020-03-26 00:06:07) >> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> new file mode 100644 >> index 0000000..0f69475 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml >> @@ -0,0 +1,158 @@ >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> + > [...] >> + maxItems: 1 >> + >> + interrupts: >> + items: >> + - description: The interrupt that is asserted >> + when a wakeup event is received on USB2 bus. >> + - description: The interrupt that is asserted >> + when a wakeup event is received on USB3 bus. >> + - description: Wakeup event on DM line. >> + - description: Wakeup event on DP line. > I can see that it was optional before but that still doesn't make sense > to me. The glue hardware from qcom always has interrupts so I'd expect > it to be required in the binding. Will add in next version. -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation