From: "Rafał Miłecki" <rafal@milecki.pl>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Michael Walle <michael@walle.cc>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Robert Marko <robert.marko@sartura.hr>,
Luka Perkov <luka.perkov@sartura.hr>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [PATCH 0/8] nvmem: Let layout drivers be modules
Date: Mon, 06 Mar 2023 15:23:50 +0100 [thread overview]
Message-ID: <0b94d38a25f5d8ea70f228213ba14fa4@milecki.pl> (raw)
In-Reply-To: <20230306151829.57c689b4@xps-13>
On 2023-03-06 15:18, Miquel Raynal wrote:
> Hi Rafał,
>
> rafal@milecki.pl wrote on Mon, 06 Mar 2023 14:57:03 +0100:
>
>> On 2023-03-06 14:35, Miquel Raynal wrote:
>> > Hi Michael,
>> >
>> > michael@walle.cc wrote on Mon, 06 Mar 2023 14:01:34 +0100:
>> >
>> >> > Miquel Raynal (8):
>> >> > of: Fix modalias string generation
>> >> > of: Change of_device_get_modalias() main argument
>> >> > of: Create an of_device_request_module() receiving an OF node
>> >> > nvmem: core: Fix error path ordering
>> >> > nvmem: core: Handle the absence of expected layouts
>> >> > nvmem: core: Request layout modules loading
>> >> > nvmem: layouts: sl28vpd: Convert layout driver into a module
>> >> > nvmem: layouts: onie-tlv: Convert layout driver into a module
>> >> >> With the fixes series [1] applied:
>> >
>> > Thanks for the series! Looks good to me. I believe both series can live
>> > in separate tress, any reason why we would like to avoid this? I am > keen
>> > to apply [1] into the mtd tree rather soon.
>>
>> Given past events with nvmem patches I'm against that.
>>
>> Let's wait for Srinivas to collect pending patches, let them spend a
>> moment in linux-next maybe, ask Srinivas to send them to Greg early if
>> he can. That way maybe you can merge Greg's branch (assuming he
>> doesn't
>> rebase).
>
> Just to be on the same page, we're talking about the mtd core fixups to
> handle correctly probe deferrals in the nvmem side.
>
> Applying mtd patches then nvmem patches is totally fine in this order.
> Applying nvmem patches and then mtd patches creates a range of commits
> where some otp devices might have troubles probing if:
> - a layout driver is used
> - the driver is compiled as a module
> - the driver is also not installed in an initramfs
>
> I was actually asking out loud whether we should care about this
> commit range given the unlikelihood that someone would have troubles
> with this while bisecting a linux-next kernel.
>
> So getting an immutable tag from Greg would not help. The opposite
> might make sense though, and involves that I apply [1] to mtd/next
> rather soon anyway, I guess?
The problem IIUC is nvmem.git / for-next containing broken code after
adding nvmem stuff. That is unless Srinivas takes your patches in some
way. Hopefully not by waiting for 6.4-rc1.
next prev parent reply other threads:[~2023-03-06 23:18 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 15:22 [PATCH 0/8] nvmem: Let layout drivers be modules Miquel Raynal
2023-03-01 15:22 ` [PATCH 1/8] of: Fix modalias string generation Miquel Raynal
2023-03-02 19:21 ` Rob Herring
2023-03-01 15:22 ` [PATCH 2/8] of: Change of_device_get_modalias() main argument Miquel Raynal
2023-03-02 19:37 ` Rob Herring
2023-03-01 15:22 ` [PATCH 3/8] of: Create an of_device_request_module() receiving an OF node Miquel Raynal
2023-03-02 19:13 ` Rob Herring
2023-03-01 15:22 ` [PATCH 4/8] nvmem: core: Fix error path ordering Miquel Raynal
2023-03-01 15:22 ` [PATCH 5/8] nvmem: core: Handle the absence of expected layouts Miquel Raynal
2023-03-01 15:22 ` [PATCH 6/8] nvmem: core: Request layout modules loading Miquel Raynal
2023-03-01 15:22 ` [PATCH 7/8] nvmem: layouts: sl28vpd: Convert layout driver into a module Miquel Raynal
2023-03-01 15:22 ` [PATCH 8/8] nvmem: layouts: onie-tlv: " Miquel Raynal
2023-03-01 15:34 ` [PATCH 0/8] nvmem: Let layout drivers be modules Greg Kroah-Hartman
2023-03-06 13:01 ` Michael Walle
2023-03-06 13:35 ` Miquel Raynal
2023-03-06 13:39 ` Michael Walle
2023-03-06 13:57 ` Rafał Miłecki
2023-03-06 14:03 ` Michael Walle
2023-03-06 14:06 ` Rafał Miłecki
2023-03-06 14:11 ` Michael Walle
2023-03-06 14:18 ` Miquel Raynal
2023-03-06 14:23 ` Rafał Miłecki [this message]
2023-03-06 14:29 ` Miquel Raynal
2023-03-06 14:34 ` Rafał Miłecki
2023-03-06 14:44 ` Miquel Raynal
2023-03-06 13:54 ` Rafał Miłecki
2023-03-06 13:55 ` Greg Kroah-Hartman
2023-03-06 15:00 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b94d38a25f5d8ea70f228213ba14fa4@milecki.pl \
--to=rafal@milecki.pl \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luka.perkov@sartura.hr \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=robert.marko@sartura.hr \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).