From: <Tudor.Ambarus@microchip.com>
To: <p.yadav@ti.com>, <pan@semihalf.com>
Cc: <miquel.raynal@bootlin.com>, <richard@nod.at>, <vigneshr@ti.com>,
<robh+dt@kernel.org>, <arnd@arndb.de>, <olof@lixom.net>,
<soc@kernel.org>, <dinguyen@kernel.org>, <p.zabel@pengutronix.de>,
<linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <tn@semihalf.com>,
<ka@semihalf.com>, <jam@semihalf.com>
Subject: Re: [PATCH 1/3] dt-bindings: mtd: spi-nor: add n25q00 schema
Date: Tue, 5 Oct 2021 11:59:06 +0000 [thread overview]
Message-ID: <0b9b656d-df4d-6062-2b0d-70aea02f378f@microchip.com> (raw)
In-Reply-To: <20210923185902.6wgkuz4jcelcawrq@ti.com>
On 9/23/21 9:59 PM, Pratyush Yadav wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> +Tudor
>
> On 20/09/21 02:41PM, Paweł Anikiel wrote:
>> Add schema for the n25q00 NOR flash memory.
>>
>> Signed-off-by: Paweł Anikiel <pan@semihalf.com>
>> ---
>> Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> index ed590d7c6e37..efb3c5e05c5a 100644
>> --- a/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> +++ b/Documentation/devicetree/bindings/mtd/jedec,spi-nor.yaml
>> @@ -18,7 +18,7 @@ properties:
>> - items:
>> - pattern: "^((((micron|spansion|st),)?\
>> (m25p(40|80|16|32|64|128)|\
>> - n25q(32b|064|128a11|128a13|256a|512a|164k)))|\
>> + n25q(00|32b|064|128a11|128a13|256a|512a|164k)))|\
>
> IIUC this is supposed to only be for legacy/old flashes that started out
> using flash-specific compatibles. Any new flashes should simply use
> jedec,spi-nor unless there is a legitimate reason to do so.
that's correct, the generic compatible should suffice for these flashes.
>
> Until you justify that reason,
>
> Nacked-by: Pratyush Yadav <p.yadav@ti.com>
I agree.
Cheers,
ta
next prev parent reply other threads:[~2021-10-05 11:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-20 12:41 [PATCH 0/3] Add support for the Mercury+ AA1 module Paweł Anikiel
2021-09-20 12:41 ` [PATCH 1/3] dt-bindings: mtd: spi-nor: add n25q00 schema Paweł Anikiel
2021-09-23 16:56 ` Rob Herring
2021-09-23 18:59 ` Pratyush Yadav
2021-10-05 11:59 ` Tudor.Ambarus [this message]
2021-09-20 12:41 ` [PATCH 2/3] dts: socfpga: Add Mercury+ AA1 devicetree Paweł Anikiel
2021-09-20 12:41 ` [PATCH 3/3] reset: socfpga: add empty driver allowing consumers to probe Paweł Anikiel
2021-10-05 9:34 ` Philipp Zabel
2021-10-05 11:12 ` Paweł Anikiel
2021-10-05 10:22 ` Philipp Zabel
[not found] ` <20210920124140.u56dOOGofORjfYeTSsKGqD2HNw-7gu5UqvN2ocHwr-g@z>
2021-09-23 16:56 ` [PATCH 2/3] dts: socfpga: Add Mercury+ AA1 devicetree Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9b656d-df4d-6062-2b0d-70aea02f378f@microchip.com \
--to=tudor.ambarus@microchip.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=jam@semihalf.com \
--cc=ka@semihalf.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=olof@lixom.net \
--cc=p.yadav@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=pan@semihalf.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=tn@semihalf.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).