From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: Frank Wunderlich <linux@fw-web.de>,
linux-mediatek@lists.infradead.org,
Chaotian Jing <chaotian.jing@mediatek.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Wenbin Mei <wenbin.mei@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: Aw: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986
Date: Mon, 24 Oct 2022 12:48:32 -0400 [thread overview]
Message-ID: <0b9d7768-3f30-c084-9a14-f439cd49d643@linaro.org> (raw)
In-Reply-To: <trinity-95441a68-0025-49de-8c73-9730fb9cec42-1666623320110@3c-app-gmx-bap55>
On 24/10/2022 10:55, Frank Wunderlich wrote:
> Hi
>
>> Gesendet: Sonntag, 23. Oktober 2022 um 14:56 Uhr
>> Von: "Krzysztof Kozlowski" <krzysztof.kozlowski@linaro.org>
>> An: "Frank Wunderlich" <linux@fw-web.de>, linux-mediatek@lists.infradead.org
>> Cc: "Frank Wunderlich" <frank-w@public-files.de>, "Chaotian Jing" <chaotian.jing@mediatek.com>, "Ulf Hansson" <ulf.hansson@linaro.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Matthias Brugger" <matthias.bgg@gmail.com>, "Wenbin Mei" <wenbin.mei@mediatek.com>, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
>> Betreff: Re: [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986
>>
>> On 23/10/2022 05:12, Frank Wunderlich wrote:
>>> From: Frank Wunderlich <frank-w@public-files.de>
>>>
>>> Add SoC specific section for defining clock configuration.
>>>
>>> Signed-off-by: Frank Wunderlich <frank-w@public-files.de>
>>
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Hi,
>
> got another config from mtk which requires changing binding a bit
>
> clocks = <&topckgen CLK_TOP_EMMC_416M_SEL>,
> <&infracfg CLK_INFRA_MSDC_HCK_CK>,
> <&infracfg CLK_INFRA_MSDC_CK>,
> <&infracfg CLK_INFRA_MSDC_133M_CK>,
> <&infracfg CLK_INFRA_MSDC_66M_CK>;
> clock-names = "source", "hclk", "source_cg", "bus_clk",
> "sys_cg";
> in binding:
>
> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.yaml
> @@ -241,15 +241,17 @@ allOf:
> items:
> - description: source clock
> - description: HCLK which used for host
> - - description: AXI bus clock gate
> - - description: AHB bus clock gate
> + - description: independent source clock gate
> + - description: bus clock used for internal register access (required for MSDC0/3).
> + - description: msdc subsys clock gate
> clock-names:
> minItems: 3
> items:
> - const: source
> - const: hclk
> - - const: axi_cg
> - - const: ahb_cg
> + - const: "source_cg"
> + - const: "bus_clk"
> + - const: "sys_cg"
>
> will send an updated v4...old version was working but i should use the new one.
>
> @Krzysztof can i take your RB here or should i leave it as Patch was changed?
Please drop my tag, so I will re-review it.
Thanks!
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-24 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-23 9:12 [PATCH v3 0/7] Add mmc-support for mt7986 Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 1/7] dt-bindings: mmc: Add compatible for Mediatek MT7986 Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 2/7] dt-bindings: mmc: mtk-sd: Set clocks based on compatible Frank Wunderlich
2022-10-23 12:56 ` Krzysztof Kozlowski
2022-10-24 16:43 ` Nícolas F. R. A. Prado
2022-10-24 18:42 ` Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 3/7] dt-bindings: mmc: mtk-sd: add mt7986 Frank Wunderlich
2022-10-23 12:56 ` Krzysztof Kozlowski
2022-10-24 14:55 ` Aw: " Frank Wunderlich
2022-10-24 16:48 ` Krzysztof Kozlowski [this message]
2022-10-23 9:12 ` [PATCH v3 4/7] arm64: dts: mediatek: mt2712e: swap last 2 clocks to match binding Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 5/7] arm64: dts: mt8183: drop drv-type from mmc-node Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 6/7] arm64: dts: mt7622: drop r_smpl property from mmc node Frank Wunderlich
2022-10-23 9:12 ` [PATCH v3 7/7] mmc: mediatek: add support for MT7986 SoC Frank Wunderlich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0b9d7768-3f30-c084-9a14-f439cd49d643@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=frank-w@public-files.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux@fw-web.de \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
--cc=wenbin.mei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).