* [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
@ 2024-01-12 13:42 KyuHyuk Lee
2024-01-12 16:58 ` Conor Dooley
2024-01-12 17:44 ` Krzysztof Kozlowski
0 siblings, 2 replies; 8+ messages in thread
From: KyuHyuk Lee @ 2024-01-12 13:42 UTC (permalink / raw)
To: Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Chris Morgan,
Jagan Teki, Tianling Shen, Andy Yan, Ondrej Jirman, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel, KyuHyuk Lee
Add device tree binding for Hardkernel ODROID-M1S board based on
RK3566 SoC.
Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
---
Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
index 5cf5cbef2cf5..cc37d2118131 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.yaml
+++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
@@ -566,6 +566,11 @@ properties:
- const: rockchip,rk3568-odroid-m1
- const: rockchip,rk3568
+ - description: Hardkernel Odroid M1S
+ items:
+ - const: rockchip,rk3566-odroid-m1s
+ - const: rockchip,rk3566
+
- description: Hugsun X99 TV Box
items:
- const: hugsun,x99
--
2.34.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 13:42 [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board KyuHyuk Lee
@ 2024-01-12 16:58 ` Conor Dooley
2024-01-12 17:02 ` Krzysztof Kozlowski
2024-01-12 17:44 ` Krzysztof Kozlowski
1 sibling, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2024-01-12 16:58 UTC (permalink / raw)
To: KyuHyuk Lee
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan, Ondrej Jirman,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
> Add device tree binding for Hardkernel ODROID-M1S board based on
> RK3566 SoC.
>
> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> ---
> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index 5cf5cbef2cf5..cc37d2118131 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -566,6 +566,11 @@ properties:
> - const: rockchip,rk3568-odroid-m1
> - const: rockchip,rk3568
>
> + - description: Hardkernel Odroid M1S
if the vendor for this board is hardkernel...
> + items:
> + - const: rockchip,rk3566-odroid-m1s
...why is the vendor prefix here rockchip?
Thanks,
Conor.
> + - const: rockchip,rk3566
> +
> - description: Hugsun X99 TV Box
> items:
> - const: hugsun,x99
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 16:58 ` Conor Dooley
@ 2024-01-12 17:02 ` Krzysztof Kozlowski
2024-01-12 17:26 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-12 17:02 UTC (permalink / raw)
To: Conor Dooley, KyuHyuk Lee
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan, Ondrej Jirman,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On 12/01/2024 17:58, Conor Dooley wrote:
> On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
>> Add device tree binding for Hardkernel ODROID-M1S board based on
>> RK3566 SoC.
>>
>> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
>> ---
>> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> index 5cf5cbef2cf5..cc37d2118131 100644
>> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
>> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
>> @@ -566,6 +566,11 @@ properties:
>> - const: rockchip,rk3568-odroid-m1
>> - const: rockchip,rk3568
>>
>> + - description: Hardkernel Odroid M1S
>
> if the vendor for this board is hardkernel...
>
>> + items:
>> + - const: rockchip,rk3566-odroid-m1s
>
> ...why is the vendor prefix here rockchip?
Uh, good catch. I missed it when acking their earlier mistake year ago
:( Would be nice if they fixed that one too.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 17:02 ` Krzysztof Kozlowski
@ 2024-01-12 17:26 ` Conor Dooley
2024-01-12 17:43 ` Krzysztof Kozlowski
0 siblings, 1 reply; 8+ messages in thread
From: Conor Dooley @ 2024-01-12 17:26 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: KyuHyuk Lee, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan,
Ondrej Jirman, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]
On Fri, Jan 12, 2024 at 06:02:09PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 17:58, Conor Dooley wrote:
> > On Fri, Jan 12, 2024 at 10:42:30PM +0900, KyuHyuk Lee wrote:
> >> Add device tree binding for Hardkernel ODROID-M1S board based on
> >> RK3566 SoC.
> >>
> >> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
> >> ---
> >> Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> index 5cf5cbef2cf5..cc37d2118131 100644
> >> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> >> @@ -566,6 +566,11 @@ properties:
> >> - const: rockchip,rk3568-odroid-m1
> >> - const: rockchip,rk3568
> >>
> >> + - description: Hardkernel Odroid M1S
> >
> > if the vendor for this board is hardkernel...
> >
> >> + items:
> >> + - const: rockchip,rk3566-odroid-m1s
> >
> > ...why is the vendor prefix here rockchip?
>
> Uh, good catch. I missed it when acking their earlier mistake year ago
> :( Would be nice if they fixed that one too.
Maybe they will if they got your email, they did not get mine
apparently:
<lee@kyuhyuk.kr>: host mx02.mail.icloud.com[17.57.155.34] said: 554 5.7.1
[HM08] Message rejected due to local policy. Please visit
https://support.apple.com/en-us/HT204137 (in reply to end of DATA command)
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 17:26 ` Conor Dooley
@ 2024-01-12 17:43 ` Krzysztof Kozlowski
2024-01-15 16:45 ` Conor Dooley
0 siblings, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-12 17:43 UTC (permalink / raw)
To: Conor Dooley
Cc: KyuHyuk Lee, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan,
Ondrej Jirman, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
On 12/01/2024 18:26, Conor Dooley wrote:
>>> if the vendor for this board is hardkernel...
>>>
>>>> + items:
>>>> + - const: rockchip,rk3566-odroid-m1s
>>>
>>> ...why is the vendor prefix here rockchip?
>>
>> Uh, good catch. I missed it when acking their earlier mistake year ago
>> :( Would be nice if they fixed that one too.
>
> Maybe they will if they got your email, they did not get mine
> apparently:
> <lee@kyuhyuk.kr>: host mx02.mail.icloud.com[17.57.155.34] said: 554 5.7.1
> [HM08] Message rejected due to local policy. Please visit
> https://support.apple.com/en-us/HT204137 (in reply to end of DATA command)
Uh, what did you do to Apple to be denied by their policy? Admit, you
have an Android phone?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 17:43 ` Krzysztof Kozlowski
@ 2024-01-15 16:45 ` Conor Dooley
0 siblings, 0 replies; 8+ messages in thread
From: Conor Dooley @ 2024-01-15 16:45 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: KyuHyuk Lee, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Heiko Stuebner, Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan,
Ondrej Jirman, devicetree, linux-arm-kernel, linux-rockchip,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]
On Fri, Jan 12, 2024 at 06:43:33PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 18:26, Conor Dooley wrote:
> >>> if the vendor for this board is hardkernel...
> >>>
> >>>> + items:
> >>>> + - const: rockchip,rk3566-odroid-m1s
> >>>
> >>> ...why is the vendor prefix here rockchip?
> >>
> >> Uh, good catch. I missed it when acking their earlier mistake year ago
> >> :( Would be nice if they fixed that one too.
> >
> > Maybe they will if they got your email, they did not get mine
> > apparently:
> > <lee@kyuhyuk.kr>: host mx02.mail.icloud.com[17.57.155.34] said: 554 5.7.1
> > [HM08] Message rejected due to local policy. Please visit
> > https://support.apple.com/en-us/HT204137 (in reply to end of DATA command)
>
> Uh, what did you do to Apple to be denied by their policy? Admit, you
> have an Android phone?
I do. I guess that puts me on -1 social credit score. I have a macbook,
but I run linux on it, so I guess that is a +1 -0.5 sorta deal, leaving
me negative overall.
Either way, not sure what causes it. Maybe the fact that I sign all my
mail is a contributing factor, but I may not be the only @kernel.org
address that KyuHyuk Lee is not receiving mail from.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 13:42 [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board KyuHyuk Lee
2024-01-12 16:58 ` Conor Dooley
@ 2024-01-12 17:44 ` Krzysztof Kozlowski
2024-01-13 16:59 ` KyuHyuk Lee
1 sibling, 1 reply; 8+ messages in thread
From: Krzysztof Kozlowski @ 2024-01-12 17:44 UTC (permalink / raw)
To: KyuHyuk Lee, Rob Herring
Cc: Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner, Chris Morgan,
Jagan Teki, Tianling Shen, Andy Yan, Ondrej Jirman, devicetree,
linux-arm-kernel, linux-rockchip, linux-kernel
On 12/01/2024 14:42, KyuHyuk Lee wrote:
> Add device tree binding for Hardkernel ODROID-M1S board based on
> RK3566 SoC.
>
> Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
Your system bounces emails from Conor, so just formality:
Fix the vendor prefix.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board
2024-01-12 17:44 ` Krzysztof Kozlowski
@ 2024-01-13 16:59 ` KyuHyuk Lee
0 siblings, 0 replies; 8+ messages in thread
From: KyuHyuk Lee @ 2024-01-13 16:59 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
Chris Morgan, Jagan Teki, Tianling Shen, Andy Yan, Ondrej Jirman,
devicetree, linux-arm-kernel, linux-rockchip, linux-kernel
On Fri, Jan 12, 2024 at 06:44:26PM +0100, Krzysztof Kozlowski wrote:
> On 12/01/2024 14:42, KyuHyuk Lee wrote:
> > Add device tree binding for Hardkernel ODROID-M1S board based on
> > RK3566 SoC.
> >
> > Signed-off-by: KyuHyuk Lee <lee@kyuhyuk.kr>
>
> Your system bounces emails from Conor, so just formality:
>
> Fix the vendor prefix.
>
> Best regards,
> Krzysztof
>
Thank you for reviewing.
Ok. Will fix it.
Thank you,
KyuHyuk Lee.
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-15 16:45 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-12 13:42 [PATCH 1/2] dt-bindings: rockchip: Add Hardkernel ODROID-M1S board KyuHyuk Lee
2024-01-12 16:58 ` Conor Dooley
2024-01-12 17:02 ` Krzysztof Kozlowski
2024-01-12 17:26 ` Conor Dooley
2024-01-12 17:43 ` Krzysztof Kozlowski
2024-01-15 16:45 ` Conor Dooley
2024-01-12 17:44 ` Krzysztof Kozlowski
2024-01-13 16:59 ` KyuHyuk Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).