From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14658C2D0A3 for ; Tue, 3 Nov 2020 12:31:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B656E22226 for ; Tue, 3 Nov 2020 12:31:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ibxvv73c" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbgKCMbq (ORCPT ); Tue, 3 Nov 2020 07:31:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728116AbgKCMbp (ORCPT ); Tue, 3 Nov 2020 07:31:45 -0500 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A3ADC0613D1 for ; Tue, 3 Nov 2020 04:31:44 -0800 (PST) Received: by mail-wm1-x342.google.com with SMTP id v5so12548571wmh.1 for ; Tue, 03 Nov 2020 04:31:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=y5g02yisg2YY1sLEpz7UaUSABGGShGErCKYZaVBWDik=; b=ibxvv73cNC5BoJrVRc/HNlTXGT5LdQH6Xdd4KchdNSvNos3JpctjDBkt/IueeM+QaF c8Rzba0GgkPkcHNEBWeK5vW0wgJIxe430Pna4cVNyWK5CMTqjhlPeSWRYDTlqiNboOdc JaxC8ZkLZGhjDQZq8tdbM4ZLTX4hkTjQLXvzTcx447SSpxJ0Gq3A4YDD/bGiMWndOSo1 MPuAEclfe7MHpHu0k+8518NsTKWOXc1+AeFGcZeGT3jv5bqvl72Qk2jwZtHmphdX7rXH r+SMWQJEJqvblpCkcwZK7qLkMJiNnc6iQN1Bx201q43Ka28PbwhuZmJz8OlOkDXY1K2N +B7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=y5g02yisg2YY1sLEpz7UaUSABGGShGErCKYZaVBWDik=; b=b8ddV0SaFpEsd+EqeGgFSEwm0SSxEMXwC4OkcNzFsLT/bSbNQDlaoqv2R58BUgH7BC hRPLRCGz5f22mDYxedaExwHjvuW5NYx/UqG8WlEk3agGE49v+Si0tJKmoZnhQPUgMrM1 gT0FfdU8rfs1xHEd9MCYsdFIkoZuCwWzMQh8T88zESXoLycRbVDna1SHEZp26o8XHOt5 EDKcebKjtCteEhGlGVC8AuZMF3uzUwRnoDgZdzng4Xkq9ATIyDyzmO5D4P7qNMtedmHX anqXlCjxLG+FN0w/CW51xvl4OwWBLdfrmpqn+y4uoRtATWDoLDw6nfTBa1VfMHR0rtxj cgUg== X-Gm-Message-State: AOAM533DDeVdhA2OvgDaiRyPIfOaQhGAxTa2oGreiQFnRrjQQoIXWf5f vHrenWPeshRRyHtcLpPOvqqWew== X-Google-Smtp-Source: ABdhPJyoDx75NM2nei8klPiV6Zbdy71+3ncC5yA+p6RbdzsnUy2pt1TXTtGiX+SMswnf4kmnfXwTHg== X-Received: by 2002:a1c:b70b:: with SMTP id h11mr3580057wmf.185.1604406702958; Tue, 03 Nov 2020 04:31:42 -0800 (PST) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id v6sm25922279wrb.53.2020.11.03.04.31.41 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Nov 2020 04:31:42 -0800 (PST) Subject: Re: [PATCH v2 2/6] ASoC: codecs: lpass-wsa-macro: Add support to WSA Macro To: Pierre-Louis Bossart , broonie@kernel.org Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org References: <20201029110829.16425-1-srinivas.kandagatla@linaro.org> <20201029110829.16425-3-srinivas.kandagatla@linaro.org> <13987e14-0bd9-9659-b574-d3b7446bb789@linux.intel.com> From: Srinivas Kandagatla Message-ID: <0bce847c-6437-9d12-6d54-d9ee99c7e896@linaro.org> Date: Tue, 3 Nov 2020 12:31:41 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <13987e14-0bd9-9659-b574-d3b7446bb789@linux.intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/10/2020 15:47, Pierre-Louis Bossart wrote: >> +static void wsa_macro_mclk_enable(struct wsa_macro *wsa, bool >> mclk_enable) >> +{ >> +    struct regmap *regmap = wsa->regmap; >> + >> +    if (mclk_enable) { >> +        if (wsa->wsa_mclk_users == 0) { >> +            regcache_mark_dirty(regmap); >> +            regcache_sync_region(regmap, 0x0, WSA_MAX_OFFSET); > > I am not a regcache/regmap expert but the sequence seems odd. I could be > wrong, but one would typically sync *after* doing changes, no? In this code path the MCLK is going from OFF to ON state, so the registers would be put in reset state, so we need to sync them with current cache state! --srini