From mboxrd@z Thu Jan  1 00:00:00 1970
From: icenowy@aosc.io
Subject: Re: [PATCH 2/4] ARM: sun8i: h3/h5: add DE2 CCU device node for H3
Date: Fri, 27 Oct 2017 16:01:07 +0800
Message-ID: <0bf125256b4b7d42a2573ae122a52b33@aosc.io>
References: <20170911155529.62891-1-icenowy@aosc.io>
 <20170911155529.62891-3-icenowy@aosc.io>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8;
 format=flowed
Content-Transfer-Encoding: 8bit
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <20170911155529.62891-3-icenowy@aosc.io>
Sender: linux-kernel-owner@vger.kernel.org
To: Rob Herring <robh+dt@kernel.org>, Maxime Ripard <maxime.ripard@free-electrons.com>, Chen-Yu Tsai <wens@csie.org>
Cc: devicetree@vger.kernel.org, linux-sunxi@googlegroups.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org
List-Id: devicetree@vger.kernel.org

在 2017-09-11 23:55，Icenowy Zheng 写道：
> The DE2 in H3/H5 has a clock control unit in it, and the behavior is
> slightly different between H3 and H5.
> 
> Add the common parts in H3/H5 DTSI, and add the compatible string in H3
> DTSI.
> 
> The compatible string of H5 DE2 CCU will be added in a separated patch.
> 
> Signed-off-by: Icenowy Zheng <icenowy@aosc.io>
> ---
>  arch/arm/boot/dts/sun8i-h3.dtsi    |  4 ++++
>  arch/arm/boot/dts/sunxi-h3-h5.dtsi | 14 ++++++++++++++
>  2 files changed, 18 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi 
> b/arch/arm/boot/dts/sun8i-h3.dtsi
> index b36f9f423c39..a8a1db79f362 100644
> --- a/arch/arm/boot/dts/sun8i-h3.dtsi
> +++ b/arch/arm/boot/dts/sun8i-h3.dtsi
> @@ -85,6 +85,10 @@
>  	compatible = "allwinner,sun8i-h3-ccu";
>  };
> 
> +&display_clocks {
> +	compatible = "allwinner,sun8i-a83t-de2-clk";

Sorry, this compatible is wrong.

Please wait for my new version of this patchset to add a
allwinner,sun8i-h3-de2-clk and use it.

(A83T doesn't have DE mod clk, but H3 has)

> +};
> +
>  &mmc0 {
>  	compatible = "allwinner,sun7i-a20-mmc";
>  	clocks = <&ccu CLK_BUS_MMC0>,
> diff --git a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> index 11240a8313c2..76a4cbc99bdb 100644
> --- a/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> +++ b/arch/arm/boot/dts/sunxi-h3-h5.dtsi
> @@ -40,9 +40,11 @@
>   *     OTHER DEALINGS IN THE SOFTWARE.
>   */
> 
> +#include <dt-bindings/clock/sun8i-de2.h>
>  #include <dt-bindings/clock/sun8i-h3-ccu.h>
>  #include <dt-bindings/clock/sun8i-r-ccu.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/reset/sun8i-de2.h>
>  #include <dt-bindings/reset/sun8i-h3-ccu.h>
>  #include <dt-bindings/reset/sun8i-r-ccu.h>
> 
> @@ -85,6 +87,18 @@
>  		#size-cells = <1>;
>  		ranges;
> 
> +		display_clocks: clock@1000000 {
> +			/* compatible is in per SoC .dtsi file */
> +			reg = <0x01000000 0x100000>;
> +			clocks = <&ccu CLK_DE>,
> +				 <&ccu CLK_BUS_DE>;
> +			clock-names = "mod",
> +				      "bus";
> +			resets = <&ccu RST_BUS_DE>;
> +			#clock-cells = <1>;
> +			#reset-cells = <1>;
> +		};
> +
>  		syscon: syscon@1c00000 {
>  			compatible = "allwinner,sun8i-h3-system-controller",
>  				"syscon";