From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Vasut Subject: Re: [PATCH 1/3] ARM: dts: Bindings for Altera Quadspi Controller Version 2 Date: Tue, 27 Jun 2017 11:37:35 +0200 Message-ID: <0bfc282d-2aec-8f36-1528-312f7ded8d9c@gmail.com> References: <1498493619-4633-1-git-send-email-matthew.gerlach@linux.intel.com> <1498493619-4633-2-git-send-email-matthew.gerlach@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1498493619-4633-2-git-send-email-matthew.gerlach-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: matthew.gerlach-VuQAYsv1563Yd54FQh9/CA@public.gmane.org, vndao-EIB2kfCEclfQT0dZR+AlfA@public.gmane.org, dwmw2-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org, richard-/L3Ra7n9ekc@public.gmane.org, cyrille.pitchen-yU5RGvR974pGWvitb5QawA@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 06/26/2017 06:13 PM, matthew.gerlach-VuQAYsv1563Yd54FQh9/CA@public.gmane.org wrote: > From: Matthew Gerlach > > Device Tree bindings for Version 2 of the Altera Quadspi Controller > that can be optionally paired with a windowed bridge. > > Signed-off-by: Matthew Gerlach > --- > .../devicetree/bindings/mtd/altera-quadspi-v2.txt | 37 ++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mtd/altera-quadspi-v2.txt > > diff --git a/Documentation/devicetree/bindings/mtd/altera-quadspi-v2.txt b/Documentation/devicetree/bindings/mtd/altera-quadspi-v2.txt > new file mode 100644 > index 0000000..8ba63d7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mtd/altera-quadspi-v2.txt > @@ -0,0 +1,37 @@ > +* Altera Quad SPI Controller Version 2 > + > +Required properties: > +- compatible : Should be "altr,quadspi-v2". > +- reg : Contains at least two entries, and possibly three entries, each of > + which is a tuple consisting of a physical address and length. > +- reg-names : Should contain the names "avl_csr" and "avl_mem" corresponding > + to the control and status registers and qspi memory, respectively. > + > + > +The Altera Quad SPI Controller Version 2 can be paired with a windowed bridge > +in order to reduce the footprint of the memory interface. When a windowed > +bridge is used, reads and writes of data must be 32 bits wide. > + > +Optional properties: > +- reg-names : Should contain the name "avl_window", if the windowed bridge > + is used. This name corresponds to the register space that > + controls the window. > +- window-size : The size of the window which must be an even power of 2. > +- read-bit-reverse : A boolean indicating the data read from the flash should > + be bit reversed on a byte by byte basis before being > + delivered to the MTD layer. > +- write-bit-reverse : A boolean indicating the data written to the flash should > + be bit reversed on a byte by byte basis. Is there ever a usecase where you need to set just one of these props ? Also, they're altera specific, so altr, prefix should be added. > +Example: > + > +qspi: spi@a0001000 { > + compatible = "altr,quadspi-v2"; > + reg = <0xa0001000 0x40>, <0xb0000000 0x4000000>; > + reg-names = "avl_csr", "avl_mem"; > + > + flash@0 { > + reg = <0>; > + label = "FPGA Image"; > + }; > +}; > -- Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html