From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Torgue Subject: Re: [PATCH v1 6/7] ARM: dts: stm32429i-eval: Enable ltdc & simple panel on Eval board Date: Mon, 16 Jan 2017 17:02:05 +0100 Message-ID: <0c00fe15-d926-3359-0e2e-f1c5a8d68cad@st.com> References: <1484573344-11609-1-git-send-email-yannick.fertre@st.com> <1484573344-11609-7-git-send-email-yannick.fertre@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1484573344-11609-7-git-send-email-yannick.fertre@st.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Yannick Fertre , Thierry Reding , David Airlie , Maxime Coquelin , Russell King , Mark Rutland , Rob Herring , Arnd Bergmann Cc: devicetree@vger.kernel.org, kernel@stlinux.com, Philippe Cornu , dri-devel@lists.freedesktop.org, Mickael Reulier , Gabriel FERNANDEZ , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi On 01/16/2017 02:29 PM, Yannick Fertre wrote: > Enable ltdc & enable am-480272h3tmqw-t01h panel. > > Signed-off-by: Yannick Fertre > --- Can you please change commit header with: "ARM: dts: stm32: Enable ltdc & simple panel on stm32f429-Eval board" > arch/arm/boot/dts/stm32429i-eval.dts | 58 ++++++++++++++++++++++++++++++++++++ > 1 file changed, 58 insertions(+) > > diff --git a/arch/arm/boot/dts/stm32429i-eval.dts b/arch/arm/boot/dts/stm32429i-eval.dts > index 2de6487..f987ca5 100644 > --- a/arch/arm/boot/dts/stm32429i-eval.dts > +++ b/arch/arm/boot/dts/stm32429i-eval.dts > @@ -88,6 +88,52 @@ > clocks = <&rcc 0 30>; > clock-names = "main_clk"; > }; > + > + panel_rgb: panel-rgb { > + compatible = "ampire,am-480272h3tmqw-t01h"; > + status = "okay"; > + port { > + panel_in_rgb: endpoint { > + remote-endpoint = <<dc_out_rgb>; > + }; > + }; > + }; > +}; > + > +&pinctrl { > + pinctrl_ltdc: ltdc@0 { > + pins { Pinmuxing definition is SOC specific. Please move it in stm32f429.dtsi file. Note that a development is ongoing to define pinmuxing in a dedicated pinctrl-stm32f4.dtsi file. > + pinmux = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + slew-rate = <2>; > + }; > + }; > }; > > &clk_hse { > @@ -123,3 +169,15 @@ > pinctrl-names = "default"; > status = "okay"; > }; > + > +<dc_host{ > + status = "okay"; > + pinctrl-0 = <&pinctrl_ltdc>; > + pinctrl-names = "default"; > + > + port { > + ltdc_out_rgb: endpoint { > + remote-endpoint = <&panel_in_rgb>; > + }; > + }; > +}; >