* Re: [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188
[not found] ` <20221124075516.1669-2-Elvis.Wang@mediatek.com>
@ 2022-11-24 10:26 ` AngeloGioacchino Del Regno
2022-11-27 21:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: AngeloGioacchino Del Regno @ 2022-11-24 10:26 UTC (permalink / raw)
To: Elvis.Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger
Cc: jason-jh . lin, Yongqiang Niu, linux-kernel, devicetree,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Il 24/11/22 08:55, Elvis.Wang ha scritto:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
>
> add gce header file to define the gce thread priority, gce subsys id,
> event and constant for mt8188.
>
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188
[not found] ` <20221124075516.1669-2-Elvis.Wang@mediatek.com>
2022-11-24 10:26 ` [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188 AngeloGioacchino Del Regno
@ 2022-11-27 21:22 ` Krzysztof Kozlowski
1 sibling, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2022-11-27 21:22 UTC (permalink / raw)
To: Elvis.Wang, Jassi Brar, Rob Herring, Krzysztof Kozlowski,
Matthias Brugger
Cc: jason-jh . lin, Yongqiang Niu, linux-kernel, devicetree,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
On 24/11/2022 08:55, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
Subject: dt-bindings: mailbox: .......
>
> add gce header file to define the gce thread priority, gce subsys id,
Start with capital letter. gce->GCE, right? So use capitals for acronym
and also explain what that acronym mean.
> event and constant for mt8188.>
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
> .../dt-bindings/mailbox/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
> 1 file changed, 966 insertions(+)
> create mode 100644 include/dt-bindings/mailbox/mediatek,mt8188-gce.h
>
(...)
> +#define CMDQ_SYNC_TOKEN_DISP_VA_START 1012
> +#define CMDQ_SYNC_TOKEN_DISP_VA_END 1013
One blank line here.
> +#endif
With all above changes:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread