Devicetree
 help / color / mirror / Atom feed
From: "Neeli, Srinivas" <srneeli@amd.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Srinivas Neeli <srinivas.neeli@amd.com>,
	Nagadheeraj Rottela <nagadheeraj.rottela@amd.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>,
	Michal Simek <michal.simek@amd.com>,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Clark Williams <clrkwllms@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Eric Dumazet <edumazet@kernel.org>,
	netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rt-devel@lists.linux.dev, git@amd.com,
	neelisrinivas18@gmail.com
Subject: Re: [PATCH net-next v4 1/8] dt-bindings: net: add Xilinx TSN Endpoint Ethernet MAC
Date: Fri, 20 Nov 2026 11:42:22 +0530	[thread overview]
Message-ID: <0c2f1f3d-43a2-440d-8d09-652e159e82ae@amd.com> (raw)
In-Reply-To: <ff25f481-3ea3-441c-826e-75c22b47fac3@lunn.ch>

Hi Andrew,

On 11/15/2026 3:13 AM, Andrew Lunn wrote:
>>> Is this a synthesis parameter? No other switch that i know of has it
>>> in DT. The driver hard codes the value based on the compatible. Why
>>> does that not work for you?
>>    Yes, MAX_LEARNING_ENTRIES is a Vivado synthesis parameter of the IP
>>    (256 to 1920), and no register reports it
> I assume that will be fixed in the next version of the IP?
     Exposing synthesis parameters is standard behavior for FPGA IPs, 
and not all of these are exposed through registers.
     Hence, I am afraid there is no plan to change this in the IP.
     For Xilinx/AMD FPGA IPs, these values can vary depending on the 
Vivado configuration,
     so the same compatible may have different values for the same 
property depending on the design.
     We have similar cases in the AXI Ethernet driver, for example, 
xlnx,rxcsum and xlnx,txcsum, which are based on synthesis parameters.
>
> Are there many other synthesis parameter which are not exported in
> registers? I just want to get an idea if this is a one off, or you are
> going to add lots of DT parameters in the next set of patches.
   Yes, there are a few additional parameters that we plan to expose 
through DT properties in the upcoming series.
   The TSN subsystem has several configurable parameters, and I 
understand that DT should describe the hardware irrespective of its 
usage by software.
   But given the volume of such parameters, we are considering adding DT 
properties in an incremental fashion, as and when there are consumers.

>
>>    The number of ports is fixed by the IP. The switch always has two
>>    external MAC ports and one internal endpoint port, and no configuration
>>    has more external MACs, so the binding never needs to grow another port.
> And that is signed off by top management? The next switch you design
> will be a fresh design, no reuse of the existing IP and will require a
> whole new DSA driver?
>
>>    The switch node follows the IP's register map. The switch fabric and the
>>    two MAC blocks are separate register windows of the switch IP, and each
>>    MAC window also holds that MAC's MDIO controller and PTP block. The PTP
>>    timer interrupt is shared by the whole switch, not owned by one port.
>>
>>    For these reasons I would prefer to keep the per-MAC resources on the
>>    switch node
>>
>>>> +        switch@38000 {
>>>> +            compatible = "xlnx,tsn-switch";
>>>> +            reg = <0x38000 0x8000>,
>>>> +                  <0x00000 0x14000>,
>>>> +                  <0x20000 0x14000>;
>>>> +            reg-names = "switch", "mac1", "mac2";
> I ask, because it would not be too hard to swap this address map
> around, put the switch registers first, and then the port registers,
> and you could have as many ports as you want.
>
> Back to what you just said:
>
>> each
>> MAC window also holds that MAC's MDIO controller and PTP block.
> So the MDIO controller and the PTP block are MAC properties, so should
> be inside the MAC node.
>
>> The PTP
>> timer interrupt is shared by the whole switch
> So that should be at the switch level.
>
> 	Andrew
   Yes, I agree with your suggestion. I will move the MAC and MDIO 
properties under ethernet-ports in the next series.

Thanks
Srinivas Neeli

  reply	other threads:[~2026-11-20  6:12 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-12 18:46 [PATCH net-next v4 0/8] Add Xilinx TSN Endpoint Ethernet MAC driver Srinivas Neeli
2026-11-12 18:46 ` [PATCH net-next v4 1/8] dt-bindings: net: add Xilinx TSN Endpoint Ethernet MAC Srinivas Neeli
2026-11-13 13:20   ` Andrew Lunn
2026-11-13 14:56     ` Neeli, Srinivas
2026-11-14 21:43       ` Andrew Lunn
2026-11-20  6:12         ` Neeli, Srinivas [this message]
2026-11-13 13:23   ` Andrew Lunn
2026-11-17 13:14   ` netdev-bot+sashiko
2026-11-12 18:46 ` [PATCH net-next v4 2/8] net: xilinx: tsn: add TSN endpoint wrapper driver Srinivas Neeli
2026-11-14 12:05   ` sashiko-bot
2026-11-17 13:14   ` netdev-bot+sashiko
2026-11-12 18:46 ` [PATCH net-next v4 3/8] net: xilinx: tsn: add endpoint MAC driver skeleton Srinivas Neeli
2026-11-12 18:46 ` [PATCH net-next v4 4/8] net: xilinx: tsn: parse endpoint DMA channel configuration Srinivas Neeli
2026-11-17 13:14   ` netdev-bot+sashiko
2026-11-12 18:46 ` [PATCH net-next v4 5/8] net: xilinx: tsn: bring up the endpoint MCDMA channels Srinivas Neeli
2026-11-12 18:46 ` [PATCH net-next v4 6/8] net: xilinx: tsn: add the endpoint RX data path Srinivas Neeli
2026-11-14 12:05   ` sashiko-bot
2026-11-17 13:14   ` netdev-bot+sashiko
2026-11-12 18:46 ` [PATCH net-next v4 7/8] net: xilinx: tsn: add the endpoint TX " Srinivas Neeli
2026-11-14 12:05   ` sashiko-bot
2026-11-17 13:14   ` netdev-bot+sashiko
2026-11-12 18:46 ` [PATCH net-next v4 8/8] net: xilinx: tsn: deliver endpoint RX frames to DSA user ports Srinivas Neeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c2f1f3d-43a2-440d-8d09-652e159e82ae@amd.com \
    --to=srneeli@amd.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=clrkwllms@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@kernel.org \
    --cc=git@amd.com \
    --cc=krzk+dt@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rt-devel@lists.linux.dev \
    --cc=michal.simek@amd.com \
    --cc=nagadheeraj.rottela@amd.com \
    --cc=neelisrinivas18@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=srinivas.neeli@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox