devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Tudor.Ambarus@microchip.com>
To: <Claudiu.Beznea@microchip.com>, <mturquette@baylibre.com>,
	<sboyd@kernel.org>, <Nicolas.Ferre@microchip.com>,
	<alexandre.belloni@bootlin.com>,
	<Ludovic.Desroches@microchip.com>, <robh+dt@kernel.org>
Cc: <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-clk@vger.kernel.org>, <Eugen.Hristev@microchip.com>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/8] clk: at91: sama7g5: fix compilation error
Date: Thu, 5 Nov 2020 08:55:00 +0000	[thread overview]
Message-ID: <0c3c2191-d01d-2254-32b4-1873ebb1b78d@microchip.com> (raw)
In-Reply-To: <1604511926-29516-2-git-send-email-claudiu.beznea@microchip.com>

On 11/4/20 7:45 PM, Claudiu Beznea wrote:
> pmc_data_allocate() has been changed. pmc_data_free() was removed.
> Adapt the code taking this into consideration. With this the programmable
> clocks were also saved in sama7g5_pmc so that they could be later
> referenced.
> 
> Fixes: cb783bbbcf54 ("clk: at91: sama7g5: add clock support for sama7g5")
> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>

Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Tested-by: Tudor Ambarus <tudor.ambarus@microchip.com>

> ---
>  drivers/clk/at91/sama7g5.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/at91/sama7g5.c b/drivers/clk/at91/sama7g5.c
> index 0db2ab3eca14..a092a940baa4 100644
> --- a/drivers/clk/at91/sama7g5.c
> +++ b/drivers/clk/at91/sama7g5.c
> @@ -838,7 +838,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  	sama7g5_pmc = pmc_data_allocate(PMC_I2S1_MUX + 1,
>  					nck(sama7g5_systemck),
>  					nck(sama7g5_periphck),
> -					nck(sama7g5_gck));
> +					nck(sama7g5_gck), 8);
>  	if (!sama7g5_pmc)
>  		return;
>  
> @@ -980,6 +980,8 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  						    sama7g5_prog_mux_table);
>  		if (IS_ERR(hw))
>  			goto err_free;
> +
> +		sama7g5_pmc->pchws[i] = hw;
>  	}
>  
>  	for (i = 0; i < ARRAY_SIZE(sama7g5_systemck); i++) {
> @@ -1052,7 +1054,7 @@ static void __init sama7g5_pmc_setup(struct device_node *np)
>  		kfree(alloc_mem);
>  	}
>  
> -	pmc_data_free(sama7g5_pmc);
> +	kfree(sama7g5_pmc);
>  }
>  
>  /* Some clks are used for a clocksource */
> 


  reply	other threads:[~2020-11-05  8:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-04 17:45 [PATCH v2 0/8] clk: at91: adapt for dvfs Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 1/8] clk: at91: sama7g5: fix compilation error Claudiu Beznea
2020-11-05  8:55   ` Tudor.Ambarus [this message]
2020-11-04 17:45 ` [PATCH v2 2/8] dt-bindings: clock: at91: add sama7g5 pll defines Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 3/8] clk: at91: sama7g5: allow SYS and CPU PLLs to be exported and referenced in DT Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 4/8] clk: at91: clk-sam9x60-pll: allow runtime changes for pll Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 5/8] clk: at91: sama7g5: remove mck0 from parent list of other clocks Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 6/8] clk: at91: sama7g5: decrease lower limit for MCK0 rate Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 7/8] clk: at91: clk-master: re-factor master clock Claudiu Beznea
2020-11-04 17:45 ` [PATCH v2 8/8] clk: at91: sama7g5: register cpu clock Claudiu Beznea
2020-11-05 14:48 ` [PATCH v2 0/8] clk: at91: adapt for dvfs Claudiu.Beznea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c3c2191-d01d-2254-32b4-1873ebb1b78d@microchip.com \
    --to=tudor.ambarus@microchip.com \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).