From: Krzysztof Kozlowski <krzk@kernel.org>
To: Taniya Das <quic_tdas@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
quic_jkona@quicinc.com, quic_imrashai@quicinc.com
Subject: Re: [PATCH 1/8] dt-bindings: clock: qcom: Add SA8775P video clock controller
Date: Fri, 21 Jun 2024 08:41:51 +0200 [thread overview]
Message-ID: <0c5d89e7-b5cf-4a51-9bd7-24fbae1b7c62@kernel.org> (raw)
In-Reply-To: <ac8781fe-e8f1-4ba7-8f7d-ebfcbaadbcee@quicinc.com>
On 21/06/2024 06:24, Taniya Das wrote:
>
>
> On 6/13/2024 12:58 PM, Krzysztof Kozlowski wrote:
>> On 12/06/2024 12:47, Taniya Das wrote:
>>> Add device tree bindings for the video clock controller on Qualcomm
>>> SA8775P platform.
>>
>> You claim it is a v1, but I saw it and already commented on this. No
>> changelog, no versioning, so my comments were ignored?
>>
>> Please go back to previous comments, implement then, respond and then
>> send v3 with all comments addressed.
>>
>
> Krzysztof, I mentioned the below in the cover letter of this series. Did
> I still miss something?
>
> Add support for videocc, camcc, dispcc0 and dispcc1 on Qualcomm SA8775P
> platform.
>
> These multimedia clock controller and device tree patches are split
> from the below series.
> https://lore.kernel.org/all/20240531090249.10293-1-quic_tdas@quicinc.com/
But this does not invalidate patch history. If you sent patch in foo
patchset, then sending v2 of this patch in bar patchset is still v2, not
v1. You still need changelog and proper versioning.
So again - respond to previous comments and/or implement them, then
provide changelog what happened.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-21 6:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-12 10:47 [PATCH 0/8] Add support for SA8775P Multimedia clock controllers Taniya Das
2024-06-12 10:47 ` [PATCH 1/8] dt-bindings: clock: qcom: Add SA8775P video clock controller Taniya Das
2024-06-13 7:28 ` Krzysztof Kozlowski
2024-06-21 4:24 ` Taniya Das
2024-06-21 6:41 ` Krzysztof Kozlowski [this message]
2024-06-12 10:47 ` [PATCH 2/8] clk: qcom: Add support for Video clock controller on SA8775P Taniya Das
2024-06-12 10:47 ` [PATCH 3/8] dt-bindings: clock: qcom: Add SA8775P camera clock controller Taniya Das
2024-06-13 7:29 ` Krzysztof Kozlowski
2024-07-04 12:20 ` Markus Elfring
2024-07-04 12:51 ` Conor Dooley
2024-06-12 10:47 ` [PATCH 4/8] clk: qcom: Add support for Camera Clock Controller on SA8775P Taniya Das
2024-06-12 10:47 ` [PATCH 5/8] dt-bindings: clock: qcom: Add SA8775P display clock controllers Taniya Das
2024-06-13 7:30 ` Krzysztof Kozlowski
2024-06-12 10:47 ` [PATCH 6/8] clk: qcom: Add support for Display clock Controllers on SA8775P Taniya Das
2024-06-13 16:46 ` Konrad Dybcio
2024-06-21 4:33 ` Taniya Das
2024-07-03 17:47 ` Taniya Das
2024-07-05 15:04 ` Dmitry Baryshkov
2024-07-06 12:25 ` Konrad Dybcio
2024-06-12 10:47 ` [PATCH 7/8] arm64: dts: qcom: Add support for multimedia clock controllers Taniya Das
2024-06-12 10:47 ` [PATCH 8/8] arm64: dts: qcom: Update sleep_clk frequency to 32000 on SA8775P Taniya Das
2024-06-13 16:42 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c5d89e7-b5cf-4a51-9bd7-24fbae1b7c62@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=bartosz.golaszewski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).